walkero/cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity
21,833 Commits 13 Branches 88 Tags
Commit Graph

209 Commits

Author SHA1 Message Date
Daniel Marjamäki
31bddb6ae0 astyle formatting 
[ci skip]
 2019-12-26 15:48:29 +01:00
Paul Fultz II
ce1fc56e96 Fix issue 6890: ValueFlow: min/max value for variable, after condition (#2460) 
* Set bounds when combining values

* Adust bounds when they are negated

* Try to infer conditional values

* Switch false and true

* Fix checking of conditions

* Fix compare

* Fix remaining tests

* Fix overflows
 2019-12-26 15:47:53 +01:00
Paul Fultz II
4aa6385a97 Regression test for 9106: False positive duplicateCondition for struct member (#2434) 2019-12-09 06:51:58 +01:00
Daniel Marjamäki
7cd7aff60a Fixed #9285 (Misleading warning message) 2019-11-16 17:24:54 +01:00
Daniel Marjamäki
fadf209e18 Add test for #9326 (FP knownConditionTrueFalse - Returning bool variable treated as condition) 2019-11-03 08:49:39 +01:00
Daniel Marjamäki
df8bdabddd Testing; Readded tests 2019-11-03 08:45:34 +01:00
Daniel Marjamäki
9094ff01d3 Fixed #9363 (knownConditionTrueFalse: False positive about function parameter) 2019-10-31 08:34:09 +01:00
Paul Fultz II
0df4876059 Fix issue 9367: FP knownConditionTrueFalse (#2209) 2019-09-24 08:15:03 +02:00
Paul Fultz II
a903aa7070 Fix issue 9351: false negative: (style) Condition '...' is always true (#2201) 2019-09-23 08:49:04 +02:00
Paul Fultz II
c1961cec1c Fix issue 9362: FP: (style) Condition '(v&1)==0' is always false (#2200) 2019-09-21 19:53:54 +02:00
Paul Fultz II
40f1635c35 Fix issue 9361: false positive: (style) Condition 'isdigit(c)!=0' is always true (#2199) 2019-09-21 08:19:54 +02:00
Paul Fultz II
ad8abdb0c3 Add impossible values to ValueFlow (#2186) 
* Add impossible category

* Replace values

* Try to adjust known values

* Add ! for impossible values

* Add impossible with possible values

* Remove contradictions

* Add values when the branch is not dead

* Only copy possible values

* Dont bail on while loops

* Load std lib in valueflow

* Check for function calls

* Fix stl errors

* Fix incorrect impossible check

* Fix heap-after-use error

* Remove impossible values when they are lowered

* Show the bound and remove overlaps

* Infer conditions

* Dont push pointer values through dynamic_cast

* Add test for dynamic_cast issue

* Add shifttoomanybits test

* Add test for div by zero

* Add a test for issue 9315

* Dont make impossible value inconclusive

* Fix FP with shift operator

* Improve handleKnownValuesInLoop for impossible values

* Fix cppcheck warning

* Fix impossible values for ctu

* Bailout for streams

* Check equality conditions

* Fix overflows

* Add regression test for 9332

* Remove duplicate conditions

* Skip impossible values for invalid value

* Check for null

* Rename bound to range

* Formatting
 2019-09-20 15:06:37 +02:00
Paul Fultz II
dc0b3527ad Fix issue 9311: False positive duplicateCondition "same if condition" with pointer inside array of struct (#2166) 
* Check for typeOf through an array

* Handle array constructors

* Format

* Fix compile error on gcc 4.8
 2019-09-10 19:41:35 +02:00
Paul Fultz II
70cad280ea Fix issue 9319: FP knownConditionTrueFalse related to aggregate initialization of struct (#2147) 2019-09-05 19:36:45 +02:00
Paul Fultz II
9e140831eb Fix issue 9329: FP knownConditionTrueFalse - vector modified by function calls (#2145) 2019-09-05 16:42:26 +02:00
Paul Fultz II
ee7fe3aaa1 Fix FP: Unitialized variable when using a pointer 
This fixes the FP in cases like this:

```cpp
void f() {
    bool b;
    bool * x = &b;
    if (x != nullptr)
        x = 1;
}
```

It tracks the indirection of the uninit value in valueflow.
 2019-08-17 07:36:41 +02:00
Paul Fultz II
3e0d1141d3 Fix issue 9277: FP: Dont warn for knwon conditions in if constexpr (#2085) 2019-08-16 07:56:39 +02:00
Paul Fultz II
0c1dff5c93 Fix issue 9268: false negative: (style) Condition '...' is always true (#2080) 
* Fix issue 9268: false negative: (style) Condition '...' is always true

* Fix copy and paste mistake
 2019-08-14 06:34:27 +02:00
Paul Fultz II
c0c6f92221 Fix issue 8431 and 8776: Size of constant string 
Fixes these cases:

```cpp
void f(void) {
        const std::string msg="xyz";
        if(!msg.empty()){} // Always true
}
```

And out of bounds access:

```cpp
#include <string>
char fstr1(){const std::string s = "<a><b>"; return s[42]; }
wchar_t fwstr1(){const std::wstring s = L"<a><b>"; return s[42]; }
```
 2019-08-12 20:24:16 +02:00
Paul Fultz II
aadc404958 Issue 8634: false negative: (style) Condition '...' is always true (#2075) 2019-08-12 11:04:01 +02:00
Paul Fultz II
bd02ca5ccb Fix issue 9207: Not detected 'always true' and unreachable code 2019-08-08 07:46:47 +02:00
Paul Fultz II
ffdd2dc793 Fix issue 8924: Re-enable valueFlowTerminatingCondition 2019-08-05 07:18:06 +02:00
Paul Fultz II
bb52a63c4e Add check for const variables 
When a local reference is declared, this will check if that local reference can be declared as `const`.
 2019-07-24 09:59:01 +02:00
Daniel Marjamäki
0eedcfc160 Fixed #7464 (warn about opposite if and else-if conditions) 2019-06-30 23:26:49 +02:00
Daniel Marjamäki
175070ca50 Revert "Fixed #8938 (FP identicalInnerCondition)" 
This reverts commit 0edf0b562855f0c6d5569a3995cb380ed1d5fc6e.

This bailout seems to cause many false negatives
 2019-06-22 21:57:19 +02:00
Daniel Marjamäki
57c6628732 Revert 'Cleaning up unsimplified templates'. This fix caused problems. 2019-05-16 21:11:04 +02:00
Paul Fultz II
195da2b3d2 Fix issue 8993: False positive duplicateCondition related to auto (#1831) 2019-05-14 08:57:36 +02:00
Daniel Marjamäki
d58d4273f9 Cleaning up unsimplified templates 2019-05-11 13:00:03 +02:00
Daniel Marjamäki
0e8f2cdf63 Use multiline in testing 2019-04-28 07:48:38 +02:00
Paul Fultz II
c4325bbec3 Fix issue 9103: False positive duplicateConditionAssign (#1808) 
* Fix issue 9103: False positive duplicateConditionAssign

* Update conditional message
 2019-04-26 12:30:41 +02:00
Daniel Marjamäki
76e13c45c7 temporarily disable duplicateConditionalAssign 2019-04-25 07:44:19 +02:00
Daniel Marjamäki
0edf0b5628 Fixed #8938 (FP identicalInnerCondition) 2019-04-22 16:54:59 +02:00
Daniel Marjamäki
648acd1cbf astyle formatting 
[ci skip]
 2019-04-18 20:21:00 +02:00
Paul Fultz II
103002578d Add check for duplicate condition and assignment (#1799) 
* Add check duplicate condition and expression

* Format

* Add assign token

* Add to classInfo

* Change note messages
 2019-04-18 20:20:24 +02:00
Paul Fultz II
774464eabb Fix issue 8996: False positive duplicateCondition 
This fixes issue 8996 by improving the alias checking by using lifetime analysis. It also extends the lifetime checker to handle constructors and initializer lists for containers and arrays.
 2019-03-19 06:25:10 +01:00
Daniel Marjamäki
3dc34f1515 Disable all simplified checks 2019-03-16 09:17:50 +01:00
Daniel Marjamäki
f40a80c349 Use 'normal' checking instead of 'simplified' 2019-03-16 07:19:48 +01:00
Paul Fultz II
0ee3f678b5 Fix issue 8987: False positive knownConditionTrueFalse (#1678) 2019-02-20 15:28:31 +01:00
Daniel Marjamäki
bd7790fd8c Update copyright year 2019-02-09 07:24:06 +01:00
rikardfalkeborn
a05079fef7 Add regression test for #8780 (#1619) 
Ticket #8780 was fixed in b839ad60dd4d9658444982d2d21c282d187c5ab6.
Add a test to avoid regressions.
 2019-01-25 07:48:18 +01:00
rikardfalkeborn
8356ec6774 Add regression test for #6906 and #7284 (#1614) 
* Add regression test for #6906

Ticket #6906 was fixed in f65cf220ba05c84a0dc0c8376c29455939408197.
Add a test to make sure there are no regressions.

* Add regression test for #7284

Ticket #7284 was fixed in 5d1fdf7958290d098998ba8afd7af391cc14d5a8.
Add tests to avoid regressions.
 2019-01-23 09:09:03 +01:00
Paul Fultz II
4b37f276c2 ValueFlow: Set arrays to true when converting to a boolean 
This sets it by checking the parent. It doesn't handle function parameters yet.
 2019-01-21 20:05:35 +01:00
rikardfalkeborn
f7d85e9df2 Add regression test for #6904 (#1611) 
Ticket #6904 was fixed in 34dbc3c00ceac490c54e68e767104c04341e3f58.
Add a regression test to make sure it doesn't reappear.
 2019-01-20 10:05:09 +01:00
amai2012
738fef6c27 Run astyle 2019-01-12 21:51:39 +01:00
Daniel Marjamäki
8dd641b8be Use OVERRIDE in test 2019-01-12 15:45:25 +01:00
rikardfalkeborn
49bad106bb Add regression test for 8168 (#1588) 
Ticket 8168 was fixed in 713f6071680d20666a0699bcba234edc17cb69a5.
Add a regression test to make sure the bug doesn't reappear.
 2019-01-11 14:11:48 +01:00
Paul Fultz II
5fa956a597 Fix issue 8932: False positive knownConditionTrueFalse - valueflow ignores operator < (#1584) 2019-01-11 08:39:23 +01:00
Paul Fultz II
4e147a4c59 Add a check for duplicate if statements 
This will warn for this:

```cpp
int f(int val)
{
	int i = 0;
	if( val & 0xff)
		i = 1;
	if( val & 0xff)
		i = 1;
        return i;
}
```
 2019-01-09 20:41:01 +01:00
practicalswift
0a1b3a9d6f Fix typos (#1568) 2019-01-06 17:15:57 +01:00
Daniel Marjamäki
39ceb53578 Comment out code in valueFlowArray. There was too many false positives. 2019-01-02 19:57:11 +01:00