65b2755098
Extract common check and run it first
2017-10-26 23:42:38 +03:00
94031ef11d
Fix for conditional memory allocation inside if-condition ( #986 )
...
* Add test cases for allocation inside if-condition
* Fix missed memory leak and false positive double free for allocation inside if-condition
2017-10-26 19:11:00 +02:00
a38854451f
Warn for signed values passed as scanf targets with "x" conversion
2017-10-25 21:22:17 +03:00
eaa12db761
scanf with %zd expects ssize_t, not ptrdiff_t
2017-10-24 22:01:23 +03:00
eb6bf1bcae
Cache and reuse value
2017-10-23 00:42:56 +03:00
1de8f771e9
Cache and reuse value
2017-10-23 00:41:29 +03:00
46f726c049
Cache and reuse value
2017-10-23 00:36:05 +03:00
539258f7a3
Fix FP for pointer addition checker
2017-10-22 23:13:12 +02:00
28cfee2d4f
Fixed #8250 (New check: Pointer calculation result cant be NULL unless there is overflow)
2017-10-22 14:32:54 +02:00
002f6679d5
Fix syntax error
2017-10-21 22:17:07 +02:00
c4c76aa1ad
Use MathLib::bigint_bits
2017-10-21 22:08:34 +02:00
4cb3548e2b
unsafeClassDivZero: change severity to style
2017-10-21 21:51:58 +02:00
5de3c43209
changed id for new checker to unsafeClassDivZero
2017-10-21 21:45:04 +02:00
64e61d28ba
Add an ability to use address sanitizer ( #979 )
2017-10-21 21:04:14 +02:00
15d814e609
classPublicInterfaceDivZero: Try to make the error message a bit better. Added variable name and what the bad input value is.
2017-10-21 13:00:52 +02:00
7a67bced71
classPublicInterfaceDivZero: extend bailout
2017-10-21 12:40:20 +02:00
299835da2f
classPublicInterfaceDivZero: don't warn in overloaded operators. It is normal behaviour that these are not protected.
2017-10-21 08:56:23 +02:00
05e1e5e0a0
astyle formatting
...
[ci skip]
2017-10-20 22:11:12 +02:00
8a7411abdb
CheckClass: Fix wrong 'public interface' warnings
2017-10-20 22:10:55 +02:00
819862ddcb
Fix compiler errors
2017-10-20 17:38:15 +02:00
1d5e3e4f0c
Fixed #8247 (False positive knownConditionTrueFalse)
2017-10-20 17:31:58 +02:00
86c84029e3
New check: Check public interface of classes ( #8248 )
2017-10-20 02:02:51 +02:00
afbfc914bc
astyle formatting
...
[ci skip]
2017-10-20 01:53:20 +02:00
5040491ee6
Size computation code not required outside this translation unit
2017-10-19 19:01:41 +03:00
606e28a3c5
Extract and reuse size computation
2017-10-19 00:25:21 +03:00
34a8d2431f
Extract and reuse size computation
2017-10-19 00:20:04 +03:00
8709490903
Clarify expressions with parentheses
2017-10-18 23:40:43 +03:00
e356ccca22
Revert "Clarify expression with parentheses"
...
This reverts commit bbf0a81c2d
2017-10-18 23:31:44 +03:00
bbf0a81c2d
Clarify expression with parentheses
2017-10-18 23:24:31 +03:00
aaafa72bc8
Use a 'negative cache' for tokens / enumerator checks ( #980 )
...
Checking whether a token is an enumerator in all the available scopes
is expensive. Once we determined that a token is not an enumerator,
skip all the expensive checks.
2017-10-18 18:01:36 +02:00
151ace2581
Use Platform for char limits computation ( #972 )
2017-10-18 17:30:47 +02:00
ad1749738e
Fixed #6153 (ValueFlowBeforeCondition: Handle global variables)
2017-10-17 16:55:37 +02:00
f1e5f64690
wxwidgets.cfg: Added support for wxMenu:Append().
2017-10-17 10:59:23 +02:00
6e737082da
Store the defined types in a map, for faster lookup
2017-10-17 09:00:14 +02:00
cccf035535
Memoize token nature computation
2017-10-17 09:00:14 +02:00
4700b75ded
Clarify error message 'condition is always true/false'
2017-10-16 22:05:00 +02:00
6d59290858
Fixed #10 (ValueFlow: condition variable has known value in switch case)
2017-10-16 21:51:30 +02:00
0425f1d46d
Fixed #8241 (FP: Same expression on both sides of operator)
2017-10-16 17:39:50 +02:00
352fd7a381
SymbolDatabase: Add support for functions in unions. ( #973 )
2017-10-15 11:49:36 +02:00
e4de220a2d
Only check pointer that can be null at that point
2017-10-14 19:09:42 +03:00
288ee96cc7
Avoid recomputing loop range end
2017-10-14 18:57:27 +03:00
db787369b9
#8243 : Changed order of includes. Moved mathlib include at first place.
2017-10-14 16:30:10 +02:00
1656ecd73b
Revert changes I committed by mistake
2017-10-11 17:15:28 +02:00
cc82288ff6
Travis: Suppress false positive
2017-10-11 17:14:02 +02:00
2d1c47b474
Omit repeated map access
2017-10-11 17:36:43 +03:00
e4cdb51f7f
#8240 Fix test error due to path handling
2017-10-11 08:45:29 +02:00
fbccb3ae55
Add errorpath for accessMoved message
2017-10-10 15:49:15 +02:00
abc3779e61
Tweaked the --check-library output so configured methods will not be shown
2017-10-10 10:18:03 +02:00
d3c9d06aa4
astyle formatting
...
[ci skip]
2017-10-08 14:16:45 +02:00
9d27917fea
c++98 compatibility
2017-10-08 14:16:18 +02:00
9c0e6986da
Passing string literals into printf as %p is fine
2017-10-08 11:14:10 +03:00
be2c65eb58
Simplify int vs bool
2017-10-08 07:54:39 +02:00
a29b33b833
Set version to 1.81.99/1.82 dev
2017-10-07 23:22:31 +02:00
cebf34e718
1.81: Set versions
2017-10-07 12:55:36 +02:00
b1c730405f
Code cleanup
2017-10-06 22:45:37 +02:00
a1053dd7dd
--check-library: Report unconfigured scoped functions also
2017-10-06 11:27:01 +02:00
2a6fbe2e3c
astyle formatting
...
[ci skip]
2017-10-05 23:01:42 +02:00
051a18b120
pull request for ticket 8180 (better diagnostic output for bailouts) ( #964 )
...
* sync build instructions from readme.txt
* refactored the patch from ticket 8180. Moved logic from macros to the bailoutInternal function
* adapt to new bailout message format
* adapt to new bailout message format
* adapt to new bailout message format
* compile fix for Microsoft platform
* remove directory part from file locations in bailout message (normalize)
* remove directory part from valueflow message filter
* adapt tests to file format without directory part
* adapt tests to file format without directory part
* new line number agnostic assert_equals methods
* new line number agnostic assert_equals methods
* adapt to new method assertEqualsWithoutLineNumbers()
* adapt to new method assertEqualsWithoutLineNumbers()
* Bugfix: do not replace line number with spaces, remove it
* review changes: const char * -> std::string, size_t -> int, std::to_string() -> MathLib::toString()
* set #line at the beginning to guard against insertions from match compiler
* Bugfix: counting lines can be difficult :-) #line 1 -> #line 2
* added method stripDirectoryPart()
* added method stripDirectoryPart()
* used new method Path::stripDirectoryPart()
* new dependency path.h in lib/valueFlow.cpp
* code cleanup, removing redundant temporary objects and casts
2017-10-05 23:03:13 +02:00
13c0b4131b
--check-library: improved function name output
2017-10-05 21:50:24 +02:00
22483baf72
missed simplification in parsing of std function declaration resulted in ( #967 )
...
wrong type detection
2017-10-03 22:10:13 +02:00
2bee664ec9
Return non-const object to enable move compiler optimization ( #966 )
2017-10-03 18:24:18 +02:00
4601e40615
Simplify code for finding string format token
2017-10-02 18:03:55 +03:00
d9ef5c5a85
Improved const correctness of local variables.
2017-10-01 14:24:37 +02:00
406ddc5c10
cleanup dead code, spotted by dmitry-me!
2017-09-30 23:05:42 +02:00
9ce23203cc
Fix includes
2017-09-30 12:45:25 +02:00
885f8452e4
reuse case insensitive string comparison function
2017-09-30 11:25:46 +02:00
9fdfada4b5
Compute value earlier and reuse it
2017-09-28 23:41:29 +03:00
7308901add
Omit duplicate and opposite checks
2017-09-28 17:59:55 +03:00
d18e8466a9
Cache and reuse values
2017-09-27 00:51:04 +03:00
04c2be33a6
Unit testing visual studio import
2017-09-24 22:57:24 +02:00
30e6a05aa0
ImportProject: Macro names in visual studio solutions/projects are case insensitive
2017-09-24 22:36:20 +02:00
9f306cf3aa
Added C++14 option
2017-09-22 22:00:00 +02:00
5993c40d5b
Improve 'opposite inner condition' check
2017-09-22 14:01:20 +02:00
5e618418d5
Refactoring, use early continue in loop
2017-09-21 22:53:15 +02:00
411c5e5f7e
Fixed #8190 (False positive constStatement - return (struct media_frames_per_second) {0};)
2017-09-21 22:50:46 +02:00
89b9f57759
Fix corrupt Token::Match pattern
2017-09-21 15:01:34 +02:00
71d207c034
Fixed #8226 (Tokenizer: Wrong handling of string literal u"abc")
2017-09-21 13:33:14 +02:00
aa38556e1c
SymbolDatabase: Simplification of code. My assumption is that start and end of scope is never null.
2017-09-20 23:06:19 +02:00
ba8222de1c
ValueFlow: Put 'inconclusive' state in the ValueKind. A value can't be both known and inconclusive.
2017-09-20 22:41:36 +02:00
e61222126f
Fixed #8176 (ValueFlow: variable might be changed if it's passed by reference to method)
2017-09-20 22:09:09 +02:00
5f4b06c0f4
isVariableChangedByFunctionCall: Fix FN when constructor argument is const reference
2017-09-20 14:03:56 +02:00
3e231a9325
Refactoring: Reuse function numberOfArguments() for counting arguments
2017-09-20 13:28:45 +02:00
2103726d54
Stop counting arguments properly
2017-09-20 13:00:43 +02:00
4318521fc1
Fixed #8187 (isVariableChangedByFunctionCall: Constructor reference argument)
2017-09-20 12:53:25 +02:00
87c35cd60e
ValueFlowForward: Refactoring handling of compound assignments
2017-09-20 11:45:28 +02:00
3d587d2704
Revert "Fix CID 1368511"
...
This reverts commit 41a79152a9
2017-09-19 23:13:40 +02:00
1a057bc23a
Revert "Remove redundant safety logic (CID 1368511)"
...
This reverts commit d892031f28
2017-09-19 23:13:31 +02:00
d892031f28
Remove redundant safety logic (CID 1368511)
2017-09-19 23:07:02 +02:00
41a79152a9
Fix CID 1368511
2017-09-19 22:35:00 +03:00
05d58f5c51
Unify classEnd check for scope
2017-09-19 22:13:50 +03:00
840c7eb258
checkFloatToIntegerOverflow: check all calculations, not only in function bodies
2017-09-19 19:30:24 +02:00
9268c2034a
checkSignConversion: check all calculations, not only in function bodies
2017-09-19 19:25:33 +02:00
f6e30eee19
checkIntegerOverflow: handle long and long long also
2017-09-19 19:14:29 +02:00
cac7146cac
checkIntegerOverflow: check all calculations, not only in function bodies
2017-09-19 14:43:48 +02:00
6bc0df2908
checkTooBigBitwiseShift: Separate id for signed shift overflow
2017-09-19 09:21:20 +02:00
be0ad20a04
checkTooBigBitwiseShift: bitshift overflow when lhs is signed
2017-09-19 09:08:44 +02:00
0cf551351b
tooBigBitwiseShift: check all calculations, not only in function bodies
2017-09-19 08:50:19 +02:00
696c5b8100
Reduce duplication, omit building unneeded string
2017-09-18 03:06:35 +03:00
7d6ef71c4d
More selective match pattern
2017-09-18 02:45:02 +03:00
2e6d78bd08
Fixed #8184 (Syntax error: case outside switch)
2017-09-15 22:37:31 +02:00
1dbcba4dd6
Fixed #8221 (ValueFlow: value for static variable that is not written)
2017-09-15 15:58:19 +02:00
d79762cfc3
Fixed #7449 (reademptycontainer (inconclusive) when variable changed in function )
2017-09-15 10:49:58 +02:00
349a28705a
Clarify code with assertions
2017-09-15 01:11:27 +03:00
0fe82335ac
Remove duplicated method call
2017-09-15 00:53:44 +03:00
f28524fefa
Unify variable names
2017-09-15 00:44:59 +03:00
ef1f3fbee6
Fixed #8173 (ValueFlow: use AST when setting values in assignment RHS ((n=42) && n=='A'))
2017-09-14 22:49:47 +02:00
927b14b60f
Fixed #8217 (Crash in isVariableChanged())
2017-09-14 15:45:15 +02:00
bb20c0504e
CheckCondition: Fix FP in daca (iqtree) 'in >> ch'
2017-09-13 22:46:36 +02:00
5c7cf584ef
bump simplecpp
2017-09-12 22:42:10 +02:00
37dea8a5cf
Only check the value if it wasn't surely set by previous code
2017-09-12 23:20:07 +03:00
a4c20b3606
Break loop early
2017-09-12 07:48:06 +03:00
4126fab1d5
Simplify code with temporary
2017-09-12 07:46:38 +03:00
caebf137bc
Cache and reuse value
2017-09-12 00:21:36 +03:00
9ff04b4df1
Resolve CID 1368512
...
Wrong pointer was being checked
2017-09-11 23:50:42 +03:00
988de6422e
Omit repeated computations
2017-09-11 18:36:44 +03:00
56544ac936
Fixed #8211 (Crash on incomplete code in isVariableChanged ())
2017-09-11 13:45:36 +02:00
db321c2617
CheckCondition: Fix FP when there is increment/decrement in condition (daca icu)
2017-09-10 22:58:05 +02:00
c34fdd1905
CheckCondition: Fix FP for undeclared variables (daca)
2017-09-10 22:30:41 +02:00
b9b47809f9
Fixed #8197 (iscast: '(b)&1' is not a cast)
2017-09-08 22:52:16 +02:00
b81b4fcb78
Fixed #8208 (CheckCondition: Use Library to determine if function is const)
2017-09-08 18:08:32 +02:00
899ad8479d
CheckCondition: Fixed FP when condition contains global static variable
2017-09-08 15:44:56 +02:00
d9adb5432a
astyle formatting
...
[ci skip]
2017-09-08 15:41:14 +02:00
9cbfa0e383
Fix #7803 : false negative: condition is always true 'if (flags & A)' ( #938 )
2017-09-08 14:30:42 +02:00
58db814d72
Rephraze /Same/Identical/
2017-09-08 12:41:33 +02:00
97125acabd
Fixed #7365 (False positive: Use of erased iterator)
2017-09-08 09:45:30 +02:00
57004ed533
Fixed #7663 (False positive: uninitialized variable (multi variables in inner scopes))
2017-09-07 23:08:55 +02:00
120d0f86d0
CheckCondition: Fix FP about same condition when switch case is used (daca)
2017-09-07 22:05:01 +02:00
1d2b58e828
Correctify explicit usage ( #951 )
2017-09-07 13:03:45 +02:00
64eccd780c
Don't use static where not needed ( #952 )
2017-09-07 13:01:07 +02:00
f0b5327450
Fix codestyle ( #953 )
2017-09-07 13:00:46 +02:00
0fc35c1350
Name all params ( #956 )
2017-09-07 12:59:53 +02:00
4c30a5af25
CheckCondition: Break out code to check if function call is non-const
2017-09-06 22:51:21 +02:00
e0c7f7f8f2
CheckCondition: Fix FP when there are method calls in condition
2017-09-06 22:26:00 +02:00
68f6cad2aa
Omit repeated search when no insertion occurs
2017-09-06 18:02:27 +03:00
66524ef645
Clarify code using temporary
2017-09-06 18:00:23 +03:00
35f5515931
Fix CID 1360383
2017-09-06 00:12:09 +03:00
58a64702b7
add "internalAstError" id so we can easily track ast errors on daca.
2017-09-05 22:49:16 +02:00
35736364f8
Fixed #8199 (false negative: (warning) Same condition '...', second condition is always false)
2017-09-05 22:45:28 +02:00
e5e6f37e41
Fixed #7405 (false positive: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.)
2017-09-05 22:03:29 +02:00
3127fcf429
Omit repeated computations
2017-09-05 17:56:57 +03:00
0e444aa133
Cache and reuse values
2017-09-05 17:50:36 +03:00
c1000998f0
CheckCondition: Fix FP found in daca results (ace)
2017-09-05 09:33:35 +02:00
d7b91a9e92
Fix CID 1378763
...
Defensive check recovered from earlier version of this code
2017-09-05 00:17:51 +03:00
7e823e6d8e
Extract repeating checks, break loop early
2017-09-05 00:04:48 +03:00
79f74fc4d3
Break loop early
2017-09-05 00:00:02 +03:00
7c8cb29d14
Extract repeating checks
2017-09-04 23:58:14 +03:00
d02d235e5e
Refactoring oppositeInnerCondition checking
2017-09-04 22:54:06 +02:00
d82805b7fe
CheckCondition: Improved checking for same conditions
2017-09-04 22:40:34 +02:00
5885988b1f
Cache and reuse value
2017-09-04 23:33:52 +03:00
aece2254d7
Put faster checks first
2017-09-04 23:33:14 +03:00
Dmitry-Me
Björge Dijkstra
Daniel Marjamäki
Ayaz Salikhov
Sign Bit
Dmitry-Me
orbitcowboy
IOBYTE
orbitcowboy
amai2012
Ayaz Salikhov
PKEuS
hexcoder
Alexey Eryomenko
Oleksandr Redko
orbitcowboy
Nekto89
Matthias Krüger