58db814d72
Rephraze /Same/Identical/
2017-09-08 12:41:33 +02:00
97125acabd
Fixed #7365 (False positive: Use of erased iterator)
2017-09-08 09:45:30 +02:00
57004ed533
Fixed #7663 (False positive: uninitialized variable (multi variables in inner scopes))
2017-09-07 23:08:55 +02:00
120d0f86d0
CheckCondition: Fix FP about same condition when switch case is used (daca)
2017-09-07 22:05:01 +02:00
1d2b58e828
Correctify explicit usage ( #951 )
2017-09-07 13:03:45 +02:00
64eccd780c
Don't use static where not needed ( #952 )
2017-09-07 13:01:07 +02:00
f0b5327450
Fix codestyle ( #953 )
2017-09-07 13:00:46 +02:00
0fc35c1350
Name all params ( #956 )
2017-09-07 12:59:53 +02:00
4c30a5af25
CheckCondition: Break out code to check if function call is non-const
2017-09-06 22:51:21 +02:00
e0c7f7f8f2
CheckCondition: Fix FP when there are method calls in condition
2017-09-06 22:26:00 +02:00
68f6cad2aa
Omit repeated search when no insertion occurs
2017-09-06 18:02:27 +03:00
66524ef645
Clarify code using temporary
2017-09-06 18:00:23 +03:00
35f5515931
Fix CID 1360383
2017-09-06 00:12:09 +03:00
58a64702b7
add "internalAstError" id so we can easily track ast errors on daca.
2017-09-05 22:49:16 +02:00
35736364f8
Fixed #8199 (false negative: (warning) Same condition '...', second condition is always false)
2017-09-05 22:45:28 +02:00
e5e6f37e41
Fixed #7405 (false positive: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.)
2017-09-05 22:03:29 +02:00
3127fcf429
Omit repeated computations
2017-09-05 17:56:57 +03:00
0e444aa133
Cache and reuse values
2017-09-05 17:50:36 +03:00
c1000998f0
CheckCondition: Fix FP found in daca results (ace)
2017-09-05 09:33:35 +02:00
d7b91a9e92
Fix CID 1378763
...
Defensive check recovered from earlier version of this code
2017-09-05 00:17:51 +03:00
7e823e6d8e
Extract repeating checks, break loop early
2017-09-05 00:04:48 +03:00
79f74fc4d3
Break loop early
2017-09-05 00:00:02 +03:00
7c8cb29d14
Extract repeating checks
2017-09-04 23:58:14 +03:00
d02d235e5e
Refactoring oppositeInnerCondition checking
2017-09-04 22:54:06 +02:00
d82805b7fe
CheckCondition: Improved checking for same conditions
2017-09-04 22:40:34 +02:00
5885988b1f
Cache and reuse value
2017-09-04 23:33:52 +03:00
aece2254d7
Put faster checks first
2017-09-04 23:33:14 +03:00
abae5e0156
Fixed #8198 (false positive: (warning) Same condition, second condition is always false)
2017-09-04 22:25:20 +02:00
f7ab8c5ebb
Drop unneeded parentheses
...
Those are a misleading leftover from old code
2017-09-04 22:49:05 +03:00
c29f16a306
Cache and reuse values
2017-09-04 17:55:45 +03:00
5dba8268e7
Better variable name
2017-09-04 17:53:56 +03:00
d838dc2129
CheckCondition::multiCondition2: Fix FN for pointers
2017-09-04 15:58:22 +02:00
095e435031
wxwidgets.cfg: Added support for some wxTextFile functions.
2017-09-04 14:52:10 +02:00
9465dca583
CheckCondition: Fix FPs for aliased variables (daca)
2017-09-04 09:34:03 +02:00
a02fd54a69
ValueFlow: Avoid FPs for aliased variables
2017-09-03 23:24:55 +02:00
ef4a7ba7f2
Fix FP in CheckCondition::multiCondition2
2017-09-03 14:46:37 +02:00
e5c6379d01
CheckCondition: Fix FP in Cppcheck
2017-09-03 11:35:37 +02:00
b9849d9e4e
CheckCondition::multiCondition2: Handle loops better
2017-09-03 11:03:01 +02:00
01e65d3e00
Improved CheckCondition::multiCondition2 so deeper bugs are found
2017-09-03 10:44:22 +02:00
f2ec5f24ce
Fixed #5845 (new check: same condition after noreturn conditional code => second condition is always false)
2017-09-03 10:34:34 +02:00
8aa568f085
Corrected noexcept constructor delegating handling ( #948 )
2017-09-02 22:54:23 +02:00
1ecefa045a
Fixed #8194 (False positive reademptycontainer - range based loop)
2017-09-02 22:22:32 +02:00
30f04a5a96
Fixed #8195 (False positive uninitvar (regression) - valueflow misses variable initialization via istringstream >>)
2017-09-02 21:53:51 +02:00
9eed9adf3c
Fixed CID 1361393, logically dead code in return statement
2017-09-02 10:49:29 +02:00
0b751dcc1b
Opposite conditions: Better matching when outer condition uses &&
2017-09-01 23:24:15 +02:00
3bbcede43b
Fixed #8193 (crash: A = -(-0.2) / (1.0 + B * B) ( daca, lammps))
2017-09-01 22:15:09 +02:00
beba46987d
Remove redundant variable
2017-09-01 18:19:25 +03:00
2133350bf0
More useful default value
2017-09-01 18:17:40 +03:00
4663dc205a
Cache and reuse value
2017-09-01 18:16:08 +03:00
3b4f60fd21
Updated error message
2017-09-01 13:33:47 +02:00
7fad1b9a36
Improved checking for opposite conditions
2017-08-31 22:53:21 +02:00
dce942197c
Fixed #8186 (Inner condition always false inside for loop)
2017-08-31 16:00:12 +02:00
d598a1c278
Fix typo causing two expressions being identical
2017-08-30 22:43:54 +03:00
82527422a8
Fixed #5614 (Incorrect syntax error with function pointer typedef and dependent template types)
2017-08-30 19:18:05 +02:00
59034e17f1
Refactoring, reuse code to skip lambda functions
2017-08-29 22:35:55 +02:00
9c99bc43c2
ValueFlow: Skip wrong handling of lambda functions. TODO: handle lambda functions properly.
2017-08-28 22:39:12 +02:00
017e72d145
Read attribute once, better variable name
2017-08-28 19:11:04 +03:00
7bd3dc5da6
Simplify array access with references
2017-08-28 18:19:03 +03:00
7d19d1ea2e
Better use of temporary
2017-08-28 18:15:15 +03:00
cf6d3ba398
Omit unneeded computations
2017-08-28 18:10:49 +03:00
02a1b7cd2d
Fixed #7965 (valueFlowForward: Improved handling of correlated variables)
2017-08-27 19:50:44 +02:00
713f607168
Fixed #8156 (wrong ast for 'z = (x & (unsigned)1) | (y & (unsigned)2);')
2017-08-26 23:25:45 +02:00
e74e4c6934
Fixed #8030 (False positive 'constStatement' when indexing with {})
2017-08-26 11:59:09 +02:00
cc97834e88
Revert "Combine overlapping patterns"
...
This reverts commit 123f9b67e0
2017-08-26 08:18:24 +03:00
123f9b67e0
Combine overlapping patterns
2017-08-26 07:32:02 +03:00
b9c2a996bf
Break loop early
2017-08-26 07:26:28 +03:00
46c6620691
Token::takeData: dont keep old values or valuetype
2017-08-25 23:32:26 +02:00
ea0db18e0c
Refactor Token::deleteThis()
2017-08-25 23:30:04 +02:00
529b255e99
ValueFlow: Better errorpath for increment/decrement
2017-08-25 23:07:26 +02:00
b1b8e5270a
ValueFlow: Better errorpath for increment/decrement
2017-08-25 22:15:52 +02:00
bab2b26d10
Fixed #8154 (heap use after free in tokenlist)
2017-08-25 17:17:19 +02:00
50636f75ba
ValueFlow: Improved error path for compound assignments
2017-08-24 22:02:49 +02:00
61e290750e
Read attribute once, better variable name
2017-08-24 18:28:52 +03:00
3bcfc33014
Break loop early
2017-08-24 18:26:53 +03:00
45996b1404
Simplify code, read attribute once
2017-08-24 18:23:44 +03:00
eba9ea0ed0
Remove redundant check
2017-08-24 18:11:54 +03:00
2582bbd0f6
Break loop early
2017-08-24 18:10:33 +03:00
d160d27417
Fixed #8172 (False positive uninitvar on sizeof *ptr)
2017-08-23 22:17:49 +02:00
f10634c021
ValueFlow: Dont try to evaluate '/=0;'
2017-08-23 17:53:05 +02:00
7fba6ecef1
Remove and disallow unused copy constructor
2017-08-23 17:54:20 +03:00
167cfb1ac5
valueFlowForward: improve handling of compound assignments
2017-08-23 11:13:47 +02:00
71b0370389
Fixed #1793 (CheckType::checkFloatToIntegerOverflow: assignments)
2017-08-23 05:34:47 +02:00
b7f9e7ed1d
negativeContainerIndex: avoid crash when AST is wrong
2017-08-22 12:30:43 +02:00
2679b576c2
Fixed #1693 (false negative: std::vector, negative index)
2017-08-22 11:04:02 +02:00
0cae823c5d
Fix doxygen comments
2017-08-21 21:13:01 +02:00
e087156e30
CheckUninitVar: Try to activate the valueflow based checking again
2017-08-20 19:54:06 +02:00
3abb62a6d1
Fixed #8036 (valueFlowUninit: strcpy(buf, e = str), free(e);)
2017-08-20 19:47:26 +02:00
92e9744020
Fixed #8148 (Tokenizer: Braces are not added properly in do while)
2017-08-16 18:55:34 +02:00
2a4f68ccf8
Resolve CID 1365361
...
* work around possible null pointer dereference in case of missing attributes
2017-08-16 17:53:04 +03:00
1d491bd332
Treat noexcept correctly
...
Converts the noexcept to the already correctly handled noexcept(true)
2017-08-16 11:31:19 +02:00
5c733c8f22
Fixed #8152 (Garbage code cause crash '0|\0|0>;')
2017-08-15 23:19:42 +02:00
705e5e3468
Fix for http://trac.cppcheck.net/ticket/8151 ( #942 )
...
* Taking care of incorrect template syntax (missing close)
Forward the incorrectness via throw, as there is no direct access to the
syntaxError method, without converting the function to a member function
2017-08-15 22:40:55 +02:00
6303437163
Resolve C4800
2017-08-15 17:42:56 +03:00
d3d9c76f01
Fix off by one, resolve C4334
2017-08-14 18:07:36 +03:00
b995e59ff2
No need for counting here
2017-08-14 18:06:23 +03:00
ca6109b40c
threadsafety: Fix static data in Token::values()
2017-08-13 14:15:24 +02:00
fb37f3503a
Fix GCC compiler warning about missing enum constant PlatformFile in switch
2017-08-12 00:17:55 +02:00
45032f7d3b
Use std mechanism to detect signedness
2017-08-11 18:44:14 +03:00
1c71c789d6
Stop parsing a define with value at the '='. ( #937 )
2017-08-09 20:02:25 +02:00
b8cd7dbb5c
Use nullptr instead of 0 or NULL ( #936 )
2017-08-09 20:00:26 +02:00
61e47208eb
Removed hard coded avr8 platform and moved it into a platform file (avr8.xml).
2017-08-09 11:58:27 +02:00
7a9d4b820f
Fixed #8158 (Custom platform configuration seems to be not used)
2017-08-09 11:06:31 +02:00
c0890b5255
ImportProject: Improve cppcheckDefines()
2017-08-08 22:57:11 +02:00
9861240e79
ImportProject: Only expose Cppcheck Visual Studio defines for Cppcheck
2017-08-08 22:27:08 +02:00
729af993fe
Fix absolute pathes import from vcxproj ( #934 )
...
Fixed importing vcxproj that contains files with absolute pathes.
2017-08-07 23:51:12 +02:00
5fa7a4edc4
GUI: save dumpfiles in buildDir if possible
2017-08-03 22:54:38 +02:00
53002e40f6
Fix ImportProject
2017-08-03 20:38:24 +02:00
ccea0b17b3
ImportProject: Read system includes and standard from compile database
2017-08-03 20:33:56 +02:00
61eccd7070
Fix dump
2017-08-03 18:03:59 +02:00
4eb43a5557
Fixed some recent regression in ImportProject for vcxproj projects
2017-08-02 22:51:22 +02:00
da3846f752
Add Timer copy constructor ( #932 )
...
- Satisfy the rule of three
2017-08-02 22:34:28 +02:00
39955973e9
Merge pull request #931 from IOBYTE/master
...
Fixed #8142 (false positive: The class 'B' has 'copy constructor' but lack of 'operator='
2017-08-02 21:16:29 +02:00
f7514fcd2c
Fix issue detected by Coverity, dereference tok3 and then check if its null.
2017-08-02 08:38:36 +02:00
e977cea04c
Fix issue detected by Coverity, either null pointer check is useless or there is null pointer dereference
2017-08-02 08:24:16 +02:00
32422c815b
Fix issue found by Coverity, scope cant be null since scope is dereferenced on all paths before the while and also unconditionally inside while
2017-08-02 08:17:29 +02:00
462ae455c8
Fix issue detected by Coverity, missing check if _settings is null
2017-08-02 08:04:35 +02:00
60f819dbe7
Refactoring, use continue in loop
2017-08-02 08:00:52 +02:00
5abf39503a
Fix issue detected by Coverity, in case solution does not specify platform configuration the platform will be uninitialized
2017-08-02 07:59:25 +02:00
05cdda3f4c
Fix issue detected by Coverity, XMLElement::Attribute might return null
2017-08-02 07:56:22 +02:00
55aec0ef1b
Fix issue detected by Coverity, vt2 is null checked and then dereferenced
2017-08-02 07:48:11 +02:00
f5044bb65f
Fixed #8142 (false positive: The class 'B' has 'copy constructor' but lack of 'operator='.)
...
Do not count static member variables when trying to figure out if
'operator =' is needed.
2017-08-01 19:52:41 -04:00
9b6d371762
checkbufferoverrun: remove dead store
...
the variable was declared inside a loop and the dead store also took place inside the loop (guarded by a condition) without further access of the value after that store.
Found by clang analyzer.
Was:
lib/checkbufferoverrun.cpp:1223:17: warning: Value stored to 'tok' is never read
tok = tok->next();
^ ~~~~~~~~~~~
2017-08-01 16:53:00 +02:00
9ef9d0e4a8
Fixed #8128 (False negative: variable is assigned value that is not read)
2017-08-01 14:56:53 +02:00
1758c3b4e7
Fix suspicious code found by Coverity, dont check if scope->function is null and then dereference it
2017-08-01 13:26:35 +02:00
058c439b2a
Coverity detected useless function call, cleanup code
2017-08-01 12:45:37 +02:00
0c8a899f59
Fix issue detected by Coverity, there was dead code because the wrong variable was used in condition
2017-08-01 11:45:51 +02:00
be998773ee
Minor refactoring, fixes FP from Coverity
2017-08-01 11:33:24 +02:00
6cc7f46696
Fix issue detected by Coverity, ternary condition is always true
2017-08-01 11:25:28 +02:00
267a2e154d
Fixed #8127 (cppcheck 1.80 compilation by MINGW32 gcc 6.3 failed)
2017-07-31 18:30:20 +02:00
cdeae918a8
Fix issue detected by Coverity (ternary operator false expression is unreachable)
2017-07-31 17:58:07 +02:00
a024f339dd
Fix issue detected by Coverity (ternary operator false expression is unreachable)
2017-07-31 17:55:15 +02:00
fec0c46af0
Refactoring, use continue in loop
2017-07-30 14:53:58 +02:00
29265cdd49
Refactoring, use continue
2017-07-30 12:46:04 +02:00
9558877458
Set version to 1.80.99/1.81 dev
2017-07-30 08:48:47 +02:00
f76ff9e7bf
Tokenizer: Put struct in anonymous namespace
2017-07-29 19:46:18 +02:00
91eb0f1fad
Removed XML version 1
2017-07-29 18:56:22 +02:00
baedfa6718
1.80: Set versions
2017-07-29 12:55:53 +02:00
a78fd23732
Refactoring, skipEnumBody
2017-07-29 12:13:32 +02:00
abf525e46d
Fix Cppcheck warning
2017-07-29 11:58:00 +02:00
aa35462add
Ticket #8091 : Don't replace std types within enum definitions. ( #922 )
2017-07-29 11:56:09 +02:00
01f023dc0a
CheckClass: Refactor hasAssignSelf to use AST
2017-07-28 23:49:11 +02:00
0e575ce12c
Modernize: make use of 'nullptr' and added a rule-file for finding non-nullptr (zero) initializations.
2017-07-28 15:20:43 +02:00
c4bd70210c
GUI: Rename methods in FileList and PathMatch
2017-07-28 10:55:51 +02:00
a4dd8f0aa4
modernize, use nullptr
2017-07-27 18:36:33 +02:00
5ae962194d
revert mode change for lib/checkstl.cpp
2017-07-26 23:51:30 +02:00
27af3edc5b
CheckStl: Safer use of AST
2017-07-26 23:43:39 +02:00
eb288ec2a1
CheckStl: Use AST to handle iterator comparisons better
2017-07-26 23:13:01 +02:00
a3916c501c
Refactor loop, use continue
2017-07-26 22:03:55 +02:00
da26ef0650
Refactoring: Use continue in loop
2017-07-26 21:13:49 +02:00
32940c023a
Refactoring: Use continue in loop
2017-07-26 20:32:14 +02:00
2d4f64027a
Refactoring: Use continue in loop
2017-07-26 20:29:13 +02:00
2f38d3d80e
CheckStl: Use ValueType
2017-07-26 20:19:36 +02:00
b802b98136
Do not warn when unique pointers are passed by value
...
A unique pointer should only be passed by value or by const reference.
Passing by value means transferring ownership it makes no sense to have a pass by value Warning for unique_ptr
Signed-off-by: Andreas Pokorny <andreas.pokorny@siemens.com>
2017-07-25 11:17:56 +02:00
0a03bbb320
Fixed #6315 (false positive - unreadVariable - variable is used via pointer)
2017-07-23 23:32:14 +02:00
b41350e8d8
Token::expressionString(): Fixed output of library types
2017-07-22 16:42:42 +02:00
bf5040e3d6
Fixed #7701 (ValueFlow: handle 64-bit unsigned values )
2017-07-22 12:19:46 +02:00
12b7843937
astyle formatting
...
[ci skip]
2017-07-21 09:17:25 +02:00
255d0410a4
Fixed #8085 (Token::expressionString: unsigned long long)
2017-07-21 09:16:42 +02:00
76a50e60b9
Merge pull request #926 from mathbunnyru/asalikhov/fix_warnings_macro
...
Fix warnings
2017-07-17 22:46:40 +02:00
4bbc830a85
Fix warnings
2017-07-17 10:13:11 +03:00
354a773bfe
Fix #8020 (ValueType: no value type for iterator + constant)
2017-07-16 11:27:32 -04:00
fabe07ffd6
Merge pull request #924 from IOBYTE/master
...
Fixed #6985 (SymbolDatabase: Function pointer not set when calling bas…
2017-07-16 14:04:25 +02:00
b0aec042a6
Fixed #6985(SymbolDatabase: Function pointer not set when calling base class function)
...
Use using namespace when looking up types.
2017-07-15 19:14:15 -04:00
814d2ae2a4
Fixed #7028 (False positive: opposite conditions (const method modifies variable))
2017-07-10 23:12:45 +02:00
fb7230ce05
importSln: Handle absolute paths for vcxproj
2017-07-10 11:12:48 +02:00
f85e43d21f
Fixed #8059 (Tokenizer::simplifyWhile0: for loop that modifies local variable)
2017-07-09 22:44:10 +02:00
dff9d13758
Fixed #8115 (Tokenizer: links not properly set in r-value template 'Foo<int> && foo')
2017-07-09 13:26:59 +02:00
ea598d5284
refactoring, use early return
2017-07-09 13:09:36 +02:00
32fe0aba41
Fixed #8037 (ValueFlow: global variable might be modified by function call)
2017-07-09 12:50:17 +02:00
0a91ced941
refactoring, use continue in loop instead of nesting
2017-07-09 12:36:33 +02:00
ac85b78e2a
Fixed #5619 (false positive: unusedVariable - array accessed by pointer variable only)
2017-07-09 11:19:00 +02:00
7161daefbd
Fixed #8040 (False positive resourceLeak - handle assigned to class instead of scalar)
2017-07-08 22:28:31 +02:00
6417be4a71
Fixed #8054 (Tokenizer::simplifyKnownVariables(): Wrong simplification for global variables)
2017-07-08 22:12:01 +02:00
6c2002a150
minor constness fix
2017-07-08 21:41:57 +02:00
6b48781fdc
Fixed #7105 (False positive resourceLeak - socket handle wiped after close)
2017-07-07 21:51:48 +02:00
211d8c6020
Refactoring checking for unused variables (avoid FN when not taking address)
2017-07-01 22:45:51 +02:00
d6f066482e
Fixed #6542 (FP: Variable 'lcount' is not assigned a value - using address of integer array)
2017-07-01 11:31:51 +02:00
db01ea1408
Fixed #6261 (false positive: Variable used in ternary expression within function argument list)
2017-07-01 11:03:49 +02:00
4827751b04
improve constness
2017-07-01 09:10:23 +02:00
f847631cdb
Fixed #5273 (FP memleak: Unknown if() condition should make error inconclusive)
2017-06-30 23:05:09 +02:00
b97f5d909e
Fixed #6570 (False positive unusedFunction - function called from within template function)
2017-06-30 14:34:28 +02:00
22919da9a8
Fixed #6246 (Defect: False positive due to ignoring struct initialisation when nested in a loop and assigned to a member)
2017-06-30 13:41:19 +02:00
3ab8466415
refactoring, use early continue in for loop
2017-06-30 12:45:48 +02:00
15b0eb42bd
import solution: Support system environment variables
2017-06-27 12:41:25 +02:00
dc37034687
Merge pull request #917 from x29a/unique_includes
...
Unique includes
2017-06-23 20:21:38 +02:00
ef86ac04b4
Add OpenCL support
...
OpenCL is basically C99.
2017-06-22 17:34:07 -07:00
b3a747d606
fix brainfart
2017-06-22 16:53:13 +02:00
cde17935ea
only use each include path once
2017-06-22 16:49:36 +02:00
1e12ec241c
reuse simplecpp::simplifyPath
2017-06-21 14:27:46 +02:00
f86d8244fa
Fixed #8022 (DacaWrongData: checkIgnoredReturnValue, hana)
2017-06-10 08:23:26 +02:00
453058c059
AST: Better handling of C++11 initializer lists
2017-06-09 22:35:46 +02:00
fd74d455ce
AST: Better handling of case
2017-06-08 15:32:35 +02:00
da87fdbb90
Refactoring TemplateSimplifier::simplifyCalculations, Token::Match patterns
2017-06-08 08:18:40 +02:00
c1ea873e1c
TemplateSimplifier::simplifyCalculations: Add some more tests and make sure they pass
2017-06-08 08:15:05 +02:00
cb48e63f92
TemplateSimplifier: Fixed bug in simplifyCalculations. Now template58 test case does not throw InternalError
2017-06-08 00:49:46 +02:00
d2e7df2c04
TemplateSimplifier: Broke out code into separate function
2017-06-08 00:16:43 +02:00
2740736136
Avoid 'deleteThis' in TemplateSimplifier::simplifyCalculations as it can cause 'use after free' see #6021
2017-06-07 20:09:06 +02:00
d335412858
Avoid 'deleteThis' in TemplateSimplifier::simplifyCalculations as it can cause 'use after free' see #6021
2017-06-07 19:46:02 +02:00
18abe4a142
Fixed #6021 (TemplateSimplifier::simplifyCalculations causes heap corruption on invalid code)
2017-06-07 19:32:56 +02:00
60e36492e2
Refactoring, renamed local variable
2017-06-07 12:37:44 +02:00
Daniel Marjamäki
Ayaz Salikhov
Dmitry-Me
Matthias Krüger
orbitcowboy
Hinterwaeldlers
Heiko Eißfeldt
Alexander Mai
Gennady Feldman
orbitcowboy
Nekto89
Veli-Matti Visuri
amai2012
Robert Reif
PKEuS
Simon Martin
Andreas Pokorny
Ayaz Salikhov
rsBNT
x29a
neheb