115f17cfe6
ValueFlow: Improve the starting point for uninitialized variables to find more uninitialized usages after many conditionals ( #4930 )
2023-04-04 21:55:09 +02:00
d5e2ee411e
Fix 11578: FP accessMoved with range-based for loop ( #4931 )
...
* Fix 11578: FP accessMoved with range-based for loop
* Format
2023-04-03 19:44:47 +02:00
86efca28a3
Fix crash in constPointer() ( #4932 )
...
* Fix crash in constPointer()
* Format
2023-04-03 19:44:08 +02:00
b2b0962067
Fix #11629 debug: Scope::checkVariable found variable 'np' with varid 0. ( #4915 )
2023-04-03 15:41:19 +02:00
a336048d14
Fix #11599 false negative: constParameter ( #4902 )
...
* Partial fix for #11599 false negative: constParameter
* Adjust test
* Update testother.cpp
* Update testother.cpp
* Fix #11599 false negative: constParameter
* Fix new warnings
* Format
* Add difference_type
* Remove isAliased()
* Undo
* Adjust test
* Add test
* Improve const check
* Tweak constness, add tests
* Add tests
* Use new helper function, fixtest
* Remove bailout, fix check for cast
* Prevent FP
* Fix constVariable check, add tests
* Format
* Format
* Add test for #11632
2023-04-02 20:36:23 +02:00
634f5e254f
Fix 11512: FN containerOutOfBounds when empty vector is returned ( #4928 )
2023-04-02 11:58:04 +02:00
2359b9ff82
valueflow: limit valueflow in functions that have many ifs
2023-04-01 20:58:15 +02:00
7503aca0e2
Fix #11621 FP functionConst when assigning init list ( #4895 )
...
* Fix #11621 FP functionConst when assigning init list
* Add comment
* Merge
2023-04-01 18:54:26 +02:00
01a22159b8
Fix autoNoType with std::begin() / function returning smart ptr ( #4919 )
...
* Fix autoNoType with std::begin()
* Suppress warning for const lambda
* Fix autoNoType with function returning smart ptr
* Handle more complex expression
* Fix scope with auto and smart ptr
* Handle smart pointers and iterators first
2023-04-01 09:38:40 +02:00
89ec148199
Partial fix for #11638 Library::getFunctionName: SIGSEGV ( #4920 )
...
* Partial fix for #11638 Library::getFunctionName: SIGSEGV
* Fix test
* simpleMatch()
2023-03-30 07:25:26 +02:00
4d72e0f5b5
Fix #11625 FP constVariable when returning by reference ( #4921 )
2023-03-30 07:24:36 +02:00
3836367d95
Fix FN passedByValue with array access, range-based for ( #4922 )
...
* Fix FN passedByValue with array access, range-based for
* Format
* Fix/suppress new warnings
2023-03-30 07:24:23 +02:00
fc24f760cc
Fix #11627 Infinite loop in ReverseTraversal ( #4916 )
2023-03-30 07:22:41 +02:00
13e12da08f
Fix #11639 findGarbageCode(): SIGSEGV ( #4917 )
2023-03-28 11:24:52 +02:00
7bf6b359b1
Fix #11616 false negative: functionConst ( #4887 )
2023-03-27 17:54:19 +02:00
5791561a45
Partial fix for #11543 checkLibraryFunction warning for smartpointer in container ( #4900 )
2023-03-27 17:50:33 +02:00
c79d859f8b
Tokenizer::simplifyTypedef: new faster simplification.
...
It performs a more "lightweight" simplification of global typedefs that are not shadowed.
If a "heavy" simplification is needed that will be executed afterwards.
2023-03-26 17:16:45 +02:00
7231d1cece
Update the isVariableChanged to correctly check the const bit ( #4912 )
2023-03-26 15:12:49 +02:00
fd8a7b9537
ValueFlow: Evaluate if statement for function returns ( #4908 )
2023-03-24 13:31:26 +01:00
cd21f55cdf
Fix 11630 and 11620 lifetime issues ( #4913 )
2023-03-24 13:29:43 +01:00
e1a4a18528
Fix 11609: False positive: Returning iterator to local container 'k' that will be invalid when returning where 'k' is an iterator. ( #4907 )
2023-03-21 23:18:01 +01:00
d4b030694b
Move some checks for variable changed from constVariable check to isVariableChanged ( #4905 )
2023-03-21 18:16:40 +01:00
0d02c0a1a7
Fix #11624 FP uninitvar with array passed to function ( #4903 )
2023-03-20 19:54:31 +01:00
6316479782
Fix FP unusedStructMember with std::map ( #4899 )
2023-03-20 19:40:57 +01:00
3d965b5b81
Fix #11618 FP functionConst with call to static function ( #4898 )
2023-03-20 19:29:49 +01:00
19eef2c584
Partial fix for #11599 false negative: constParameter ( #4901 )
2023-03-19 17:43:23 +01:00
3b61ecd973
Fix FP missingOverride ( #4894 )
2023-03-18 16:39:45 +01:00
716fcc5e96
Fix crash in valueFlowForwardLifetime() ( #4891 )
2023-03-18 14:53:49 +01:00
319baf8d0f
No WRONG_DATA for function pointer with unknown return type ( #4893 )
2023-03-18 14:52:29 +01:00
3ccd0505cd
Enable and mitigate readability-simplify-boolean-expr ( #4897 )
2023-03-17 13:51:55 +01:00
8324caf8b9
Fix 11557: FP derefInvalidIteratorRedundantCheck in and/or condition ( #4892 )
2023-03-16 15:00:27 +01:00
a4d2178f3c
Fix ctuuninitvar false positive for struct that is partly initialized
2023-03-13 20:55:11 +01:00
322a1a5e8c
Partial fix for #11378 internalAstError regressions (iscpp11init) ( #4889 )
2023-03-13 16:30:27 +01:00
a6c5bb28c1
Fix crash in LoopAnalyzer ( #4888 )
2023-03-13 15:44:34 +01:00
61e8b84578
Fix 11610: false negative: knownConditionTrueFalse with address of variable ( #4883 )
2023-03-12 19:57:11 +01:00
a75392307f
Partial fix for #11604 : no DacaWrongData for function pointer ( #4867 )
2023-03-12 15:49:37 +01:00
e2b2fc2684
Fix #10946 Debug warning: autoNoType with lambda ( #4824 )
2023-03-12 15:48:20 +01:00
980c92d19d
Partial fix for #11378 internalAstError regressions (iscpp11init) ( #4884 )
2023-03-12 15:39:02 +01:00
e2f38fdaf3
removed `experimental` and `safe` from `Certainty` ( #4819 )
2023-03-12 14:15:29 +01:00
9ed21fb917
Fix #11513 FN functionConst with comparison as argument ( #4738 )
2023-03-12 11:39:18 +01:00
809430631f
Partial fix for #11611 FP constStatement with typedef and unknown macro ( #4881 )
2023-03-12 11:13:58 +01:00
7881b99547
Fix #10259 debug: SymbolDatabase couldn't resolve all user defined types ( #4879 )
2023-03-10 19:04:46 +01:00
f4b32d74c7
dump: update <TemplateSimplifier> info in dump file
2023-03-09 21:58:33 +01:00
901b2ab838
Preprocessor: provide suppressions separately from settings ( #4878 )
2023-03-09 20:15:53 +01:00
a5b0fd38fd
Fix FP functionConst with ternary ( #4874 )
2023-03-09 20:07:44 +01:00
3db05cf3a4
Pass settings to isVariableChanged() ( #4871 )
2023-03-09 20:05:44 +01:00
49c5a5aabd
Fix #11602 "debug: Executable scope 'x' with unknown function" ( #4869 )
2023-03-09 20:04:55 +01:00
30131837b5
refs #11603 - deprecated `--enable=information` implicitly enabling `missingInclude` ( #4865 )
2023-03-09 20:04:20 +01:00
c76b05ad75
Fix #11607 FP constVariable with auto and std::map ( #4877 )
2023-03-09 20:01:50 +01:00
6e1cc11eff
Fix #11606 internalAstError with empty initializer list ( #4875 )
2023-03-09 20:01:06 +01:00
2d5cabed4b
Add std::*begin and std::*end cfg ( #4796 )
2023-03-09 17:06:53 +01:00
9351eddbca
Fix 11605: FN useStlAlgo with multiple conditions ( #4873 )
2023-03-09 17:06:27 +01:00
b0e8ed3117
dump: add more template info to dumpfile
2023-03-08 18:59:34 +01:00
f2238e717b
Fix crash in isTemporary() ( #4866 )
2023-03-07 12:44:54 +01:00
00fd3d92c6
made `ForwardTraversal::mSettings` and `ReverseTraversal::mSettings` references / adjusted some calling code to use references as well ( #4858 )
2023-03-07 12:26:17 +01:00
63f439dc1e
enabled and fixed `performance-noexcept-move-constructor` clang-tidy warnings ( #4864 )
2023-03-07 12:24:01 +01:00
20db3ff368
SymbolDatabase: made `mTokenizer` and `mSettings` references ( #4857 )
2023-03-07 12:22:06 +01:00
a3cacf1ba1
TemplateSimplifier: made `mTokenizer` and `mSettings` references ( #4856 )
2023-03-07 12:12:31 +01:00
e8e00d8fdf
Unused Var: Fix FP when initialization is made in macro
2023-03-05 15:31:53 +01:00
ad6c5d80ff
removed unused `ErrorLogger::reportInfo()` / small `*Executor` cleanup ( #4852 )
2023-03-04 17:29:34 +01:00
a00b6e1f8a
simplified `ThreadExecutor` class by moving some code out of it / fixed some thread safety issues ( #4849 )
2023-03-04 12:05:17 +01:00
9291421840
Fix #11595 FN useStlAlgorithm with complex condition ( #4848 )
2023-03-04 11:58:12 +01:00
b4c90f8b2a
Fix #11597 FP uninitvar with nested enum ( #4847 )
2023-03-04 11:57:12 +01:00
350a1f2dfc
AST: do not produce AST for function pointer declaration 'void *(*var[2])(int)'
2023-03-04 11:09:55 +01:00
f4e0ae3b84
Tokenizer: Improved removing of function pointer arguments to avoid false positives
2023-03-04 11:09:55 +01:00
7fd4118d60
Fix #10039 (integrate `--check-config` include findings with normal analysis) / also fixes #11283 ( #3229 )
2023-03-04 09:02:35 +01:00
50eb0641b9
iwyu.yml: added `clang-include-cleaner` job / cleaned up includes based on `include-what-you-use` ( #4844 )
2023-03-04 08:53:19 +01:00
0ec2d84f1a
optimized suppression lookups a bit when no suppressions exist ( #4839 )
2023-03-03 18:37:09 +01:00
5af6ca6637
made `Platform` a member of `Settings` instead of inheriting from it / cleanups ( #4791 )
2023-03-03 18:36:27 +01:00
8023eff7c0
removed `TokenList::getSettings()` and replaced usage in ValueFlow with provided settings ( #4843 )
2023-03-03 18:31:38 +01:00
f9c67ef907
fixed `functionConst` selfcheck warnings ( #4846 )
2023-03-03 11:02:51 +01:00
b70e1d5461
avoid some unchecked pointer dereferences ( #4811 )
2023-03-02 22:05:41 +01:00
215124461e
Fix #11499 FN functionConst with operator usage ( #4722 )
2023-03-02 21:51:58 +01:00
381361629e
Preprocessor: removed unreachable `ConfigurationNotChecked` finding ( #4790 )
2023-03-02 21:50:57 +01:00
bd1ae69b00
cleaned up includes based on `include-what-you-use` ( #4599 )
2023-03-02 21:50:14 +01:00
8f5f06add7
some `Tokenizer` construction and related other cleanups ( #4799 )
2023-03-02 21:48:14 +01:00
dac578e8b9
ValueFlow: avoid unnecessary `Value` copies ( #4835 )
2023-03-02 21:46:23 +01:00
491299048b
Amend fix for #11449 Function call not recognized ( #4838 )
2023-03-02 21:45:15 +01:00
75619db1d5
symboldatabase.cpp: use `Keywords` / added TODOs ( #4828 )
2023-03-02 21:20:56 +01:00
51c5a79150
Fix #11586 FP ctuArrayIndex with unknown typedef ( #4831 )
2023-03-02 21:19:53 +01:00
7f62d8ff98
Fix #11594 internalAstError with immediately instantiated enum ( #4841 )
2023-03-02 21:17:39 +01:00
3ec4da0f8a
improved library loading in tests ( #4806 )
2023-03-02 21:10:51 +01:00
e99d7c6531
fixed some `-Wdeprecated-copy-dtor` Clang compiler warnings ( #4836 )
2023-03-02 21:02:29 +01:00
072e822020
Set ValueType for free function returning iterator ( #4837 )
2023-03-02 21:01:20 +01:00
cfba046408
Fixed #11593 (function pointer => false negatives (ast? valueflow?))
2023-03-02 20:08:22 +01:00
17e776861e
Get type from auto with index operator ( #4826 )
2023-02-28 15:05:45 +01:00
80050b11dd
SymbolDatabase: Fix handling of function pointer arguments
2023-02-27 15:10:25 +01:00
65fc31cba9
Tokenizer: tweaked simplification of function pointers. Argument types are kept.
2023-02-26 18:03:24 +01:00
a0cc35e3fa
Remove simplifyQtSignalsSlots(), update qt.cfg ( #4807 )
2023-02-25 15:58:57 +01:00
29b651f264
Partial fix for #11543 checkLibraryFunction warning for smartpointer in container ( #4781 )
2023-02-25 15:47:02 +01:00
5d9c157f5e
keywords.cpp: fixed accidental omissions in C++03 keywords / added missing keywords in latest standards ( #4825 )
2023-02-25 00:19:04 +01:00
a250e6b569
enabled and mitigated `-Wunreachable-code` Clang warnings ( #4818 )
2023-02-24 21:57:44 +01:00
92b42255da
Fix #11559 FN functionConst ( #4795 )
2023-02-24 21:44:57 +01:00
674231ae52
added clean C/C++ keyword lists and use them in `TokenList` ( #3774 )
2023-02-24 21:43:27 +01:00
da09a92b0a
test/cfg: enabled `information` and `--inconclusive` in all cases / some cleanups ( #4784 )
2023-02-24 21:37:56 +01:00
8583fcf96e
avoid more cases of returning non-const pointers from `const` objects ( #4821 )
2023-02-24 21:22:08 +01:00
d65cc696b0
Get type from auto with scope ( #4822 )
2023-02-24 21:05:26 +01:00
a030970160
Fix #11531 FP constParameter with const/non-const overload / #8700 FP functionConst ( #4802 )
2023-02-24 07:05:18 +01:00
d1e1f951df
Don't show checkLibraryNoReturn for functions with visible declaration ( #11523 , #11190 ) ( #4809 )
2023-02-24 06:49:28 +01:00
103ff907b6
Fix #11572 Broken AST with brace-init and bitwise and ( #4812 )
2023-02-24 06:31:20 +01:00
e5a22e3436
Revert "improved `Path` handling of mixed separators ( #4808 )"
...
This reverts commit 0797867758
2023-02-24 06:21:02 +01:00
50c8a0dbe1
Fix #11553 pop_back on empty container is UB ( #4789 )
2023-02-24 01:10:19 +01:00
ce3ba5c015
token.cpp: removed unreachable cases from `multiComparePercent()` ( #4814 )
2023-02-23 22:58:10 +01:00
96887c8130
Fix #11561 FN nullPointer with unnamed parameter ( #4805 )
2023-02-23 22:56:03 +01:00
0797867758
improved `Path` handling of mixed separators ( #4808 )
2023-02-23 22:34:05 +01:00
346ecdb53a
Improve valueflow after pushing to container ( #4803 )
2023-02-23 18:05:31 +01:00
91d2526c41
Fix reverse analysis when modifying variable with function ( #4800 )
2023-02-23 18:04:16 +01:00
fb88883813
Fix #11576 FP comparePointers / FN cstyleCast when taking address ( #4817 )
...
* Fix FN cstyleCast when taking address
* Fix #11576 FP comparePointers with member variable
* Use getParentLifetime()
* Fix test case number
2023-02-23 17:27:47 +01:00
9b62caf0ef
Fix FP#11508 ( #4774 )
...
* Add tests to cover the issue
* Set lifetime of pointer to data passed as view to SubFunction
* Move isContainerOfPointers to separate function
* Revert "Set lifetime of pointer to data passed as view to SubFunction"
This reverts commit 30dafe23e40354606776d2573653608025cae754.
* Skip propagating lifetime of iterators/pointers for views
* Add indents to test cases
* Skip all non-local values in container view lifetime
2023-02-18 17:38:51 +01:00
ff0eee4d77
Fix #11558 FP knownConditionTrueFalse when checking for zero character ( #4794 )
...
* Fix #11558 FP knownConditionTrueFalse when checking for zero characte
* Fix test
* Set impossible value only for non-Boolean conditions, rename
* Fix condition
2023-02-18 17:35:12 +01:00
1c11d3039d
Fix FP returnTempReference ( #4793 )
...
* Fix FP returnTempReference
* Fix mismatch between token and variable ValueType
* Format, clang-tidy
* Add test
* Format
2023-02-17 07:17:37 +01:00
33a03f2c35
Don't throw internalAstError for parameter pack in template argument list ( #4773 )
2023-02-15 19:43:18 +01:00
4f8329b2df
Fix #11545 FP unreadVariable with std::span ( #4792 )
2023-02-14 06:11:24 +01:00
d651b6baf1
dump: Fix concurrency problem with dump files ( #4757 )
...
* dump: Fix concurrency problem with dump files
This adds the process ID for the cppcheck process to the filenames
of the .dump and .ctu-info files that the process generates.
So
lib/cppcheck.cpp.dump
becomes
lib/cppcheck.cpp.<PID>.dump
For example:
lib/cppcheck.cpp.2637871.dump
The reason for this change is that if there is a buildsystem which
supports concurrency, multiple instances of cppcheck may be run for
the same file. For example, if the same file is compiled in multiple
build variants, or for multiple targets.
If running the MISRA plugin over such a project with concurrency
enabled in the buildsystem, the plugin ends up crashing as multiple
jobs attempt to create/trample/delete the same files while other
jobs are using them.
For more information see:
https://sourceforge.net/p/cppcheck/discussion/general/thread/02c757b4af/
* dump: Include pid in filename if dump not explicit
Only change the dump and ctu-info filenames to include the PID if
they are being generated due to an addon.
This means that existing scripts that use `--dump` will still work
if they depend on the previous naming behaviour. The more robust
filenames containing the pid will be used when the dump files are
used as an internal implementation detail for passing data to addons.
However this means that anything that does explicitly use `--dump`
will be susceptible to concurrency problems.
* test: Update addon dump file test to account for pid
This test causes a dump file to be created by enabling the misra
addon. Since the dump files now include the cppcheck process pid
this test had to be updated to account for the change.
2023-02-13 20:54:21 +01:00
2379239aed
Fix FP ignoredReturnValue ( #4783 )
2023-02-11 10:46:04 +01:00
132a5a31cf
improved setting of platform in tests / also improved platform tests ( #4787 )
...
* fixture.h: added TODO
* TestPlatform: improved tests for built-in platforms
* TestPlatform: changed tests to TODO asserts
* testfilelister.cpp: added TODO
* fixture.h: added `PLATFORM` macro to load platform / use `PLATFORM` in tests
* platform.h: corrected capitalization in `Platform::platformString(PlatformType)` and bail on unknown type
* fixture.h: fixed `readability-redundant-string-cstr` clang-tidy warning
* testplatform.cpp: fixed `functionConst` selfcheck warnings
2023-02-11 10:44:56 +01:00
2b9af94b9a
Fix 11548: FP knownConditionTrueFalse with empty() == false ( #4788 )
...
* Fix 11548: FP knownConditionTrueFalse with empty() == false
* Format
* Fix test
2023-02-11 10:42:13 +01:00
f7a415dbf3
Token: do not return non-`const` pointer from `const` methods - part 1 ( #4761 )
2023-02-08 21:07:16 +01:00
8ef14dad98
fixed and enabled `performance-faster-string-find` clang-tidy warning ( #4769 )
2023-02-08 21:01:51 +01:00
14e78e1800
greatly improved error handling in Cppcheck project file parsing / some cleanups ( #4752 )
2023-02-08 20:30:43 +01:00
271ccbc8f3
Fix FP constVariable with reference to std::array ( #4777 )
2023-02-08 08:25:43 +01:00
66758d65f9
updated precompiled headers based on `ClangBuildAnalyzer` ( #4775 )
2023-02-08 08:19:21 +01:00
1fcea5fb03
Don't crash on C++23 code ( #4771 )
2023-02-07 22:36:42 +01:00
55292d476a
Fix #11535 "debug: Executable scope 'x' with unknown function" ( #4770 )
2023-02-07 22:35:58 +01:00
c3225781f3
Fix #11533 Infinite recursion in typeDecl() ( #4767 )
2023-02-07 22:02:59 +01:00
4d9caa99f3
improved testing of missing includes / made it possible to clear the include cache in simplecpp ( #4704 )
2023-02-07 22:02:12 +01:00
132ae52428
Don't show checkLibraryFunction warning for types with unusedvar configuration ( #4765 )
2023-02-07 21:58:44 +01:00
8af1026696
Set functions for calls through iterators ( #4763 )
2023-02-07 21:57:59 +01:00
d06f93aebf
Fix #11458 nullPointer false positive ( #4758 )
2023-02-06 22:06:04 +01:00
a666e31801
Fix #11517 FP constVariable with dynamic_cast ( #4753 )
2023-02-06 22:05:07 +01:00
4f915499d4
Fix #11091 FP: Using object that is a temporary ( #4754 )
2023-02-06 22:04:27 +01:00
7dde6c5d29
CheckExceptionSafety: moved `CWE` objects into source file ( #4759 )
2023-02-06 22:01:31 +01:00
5818520b4b
Fix FN stlcstrAssignment ( #4764 )
2023-02-03 14:10:27 +01:00
e8c3a80678
Improve --check-library error message ( #4755 )
2023-02-01 14:53:57 +01:00
e1b313ba76
GUI: Generate compliance report
2023-01-30 14:59:45 +01:00
7c7ccdf7c0
Check: disallow more than one instance per check ( #4749 )
2023-01-29 17:23:03 +01:00
1a460d7bc0
bumped version to 2.11 ( #4751 )
2023-01-29 15:18:22 +01:00
afd13ea11d
ValueFlow: some interface and namespace cleanups ( #4746 )
2023-01-28 10:20:47 +01:00
464fbe8d53
Update copyright year
2023-01-28 10:16:34 +01:00
7eb1da9ffc
Fix #11506 debug: simplifyUsing: unmatched body end ( #4728 )
2023-01-27 08:19:32 +01:00
3ccc0adbca
Fix #11182 checkLibraryFunction with overloaded method / #11198 inconsistent reporting of checkLibraryNoReturn ( #4740 )
2023-01-26 22:29:49 +01:00
fd15811215
de-coupled `--check-library` from `information` severity and other dependencies ( #3861 )
2023-01-26 22:28:04 +01:00
ca0c13e27d
Fix crash in iscpp11init_impl() ( #4743 )
2023-01-26 22:25:49 +01:00
bea6aec2b2
extracted `ValueFlow::Value` to `vfvalue.{cpp|h}` ( #4642 )
2023-01-26 22:23:22 +01:00
b5a06d045e
Fix #11497 debug: CheckClass::isMemberVar found used member variable 'x' with varid 0 (inconclusive) ( #4736 )
2023-01-26 22:19:51 +01:00
a0f51d1e21
Improve <type-checks><unusedvar> error message ( #4735 )
2023-01-26 22:18:55 +01:00
a0b1285f4a
added CMake option `BUILD_CORE_DLL` to build lib as `cppcheck-core.dll` with Visual Studio ( #4733 )
2023-01-26 22:13:07 +01:00
c3aa0940be
fix truncation of token flags ( #4727 )
2023-01-26 22:11:37 +01:00
3a8d9b8c87
Fix #11510 FP CastIntegerToAddressAtReturn with ternary operator ( #4732 )
2023-01-26 22:09:55 +01:00
e5572835c0
fixed `platforms` lookup / set proper platform type for `unix32-unsigned` and `unix64-unsigned` / copy `platforms` in CMake ( #4464 )
2023-01-26 22:05:40 +01:00
Paul Fultz II
chrchr-github
Daniel Marjamäki
Oliver Stöneberg
Mateusz Michalak
Michael Drake
Robert Reif