Commit Graph

14 Commits

Author SHA1 Message Date
Andrew C. Martin 4a73c93750 Fix compiler warnings and comment/string typos
- fix g++ warning:

> lib/checkother.cpp:3779: warning: comparison between signed and unsigned integer expressions

 - fix suncc warning (see [everything2](http://everything2.com/title/C%252B%252B%253A+static+extern+%2522C%2522)):

> "lib/checkmemoryleak.cpp", line 578: Warning (Anachronism): Formal argument __compar of type extern "C" int(*)(const void*,const void*) in call to bsearch(const void*, const void*, unsigned long, unsigned long, extern "C" int(*)(const void*,const void*)) is being passed int(*)(const void*,const void*).

- prefer empty() / isEmpty() over "size() > 0" (cases not caught by stlSize)

- fix word misspellings (mostly comments, a few output lines)

  - Parenthesis => Parentheses (both variations were used in the codebase)

  - fix typo and wording ("never alwayw") in gui/test/data/benchmark/simple.cpp's CheckOther::unsignedPositive():

```
-  "An unsigned variable will never alwayw be positive so it is either pointless or "
+  "An unsigned variable can't be negative so it is either pointless or "
```
2013-01-16 07:37:07 -07:00
Reijo Tomperi 5d5f7085bf Updating year 2012 -> 2013 to .cpp and .h files and man page. 2013-01-01 18:29:08 +02:00
PKEuS 7c8f6173c1 Don't need parent of QObject to be set in Report -> Increase constness of ResultsView::Save()
- our code already deletes all Report instances; there is no need for garbage collector
2012-10-27 12:22:56 +02:00
PKEuS d7bdb90bc9 Refactorizations in Report classes:
- Base class destructor already calls Close() - removed redundant call
- Avoid creation of temporary variable
2012-10-21 10:33:11 +02:00
PKEuS b1a768e5ec Cleanup of includes in GUI (Removed redundant includes, use forward declarations) - Build speedup by 3% in VS10 (LINKCORE=yes, Qt 4.8.3) 2012-10-07 12:25:34 +02:00
Reijo Tomperi 8cae17fda8 Update year to 2012 2012-01-01 01:05:37 +02:00
Daniel Marjamäki 6f8e42a5af changed the astyle formatting flags 2011-10-13 20:53:06 +02:00
Kimmo Varis 4c24b6a804 GUI: Rename ErrorItem::id to ErrorItem::errorId. 2011-10-12 22:19:08 +03:00
Kimmo Varis f9c97c7b56 GUI: Add support for inconclusive errors.
This is the first (and quick) support for the inconclusive errors.
We simply add [Inconclusive] to begin of the summary. This is
temporary solution until better GUI is implemented. XML v1 won't
be supporting inconclusive errors. For XML v2 we need still to
decide what to do.
2011-04-16 14:07:33 +03:00
Kimmo Varis 7c589384d2 GUI: Use severity enum in ErrorItem.
Convert from using string to enum values for severity in ErrorItem.
Storing and handling severity as string was the easy way earlier
but it is not convenient or efficient way to handle severities.
This commit is the first step in converting severity handling to
use the enum values instead of strings.
2011-03-07 21:10:30 +02:00
Kimmo Varis f279fcd351 GUI: Unquote special characters when reading XML.
Unquote the quoted data from XML file when reading. We don't want
quoted chars to be visible in the GUI.
2011-02-05 16:07:59 +02:00
Kimmo Varis d31703e452 GUI: Read ErrorItems instead of ErrorLines from XML report.
XML report format 1 only had error "lines" that we promoted to "items"
when adding to GUI. XML report format 2 contains error "items" so
change the code to read items and do the promotion directly when
reading and parsing the data.
2011-02-05 12:41:29 +02:00
Kimmo Varis 299e200d45 GUI: Quote special chars in the XML output.
Fixes ticket #2543 (GUI: Xml report does not quote special characters)
2011-02-05 00:23:25 +02:00
Kimmo Varis df231aa738 GUI: Add base class for XML report classes.
A base class is needed for e.g. some common routines that can be
shared between the formats.
2011-02-04 23:56:14 +02:00