Commit Graph

1480 Commits

Author SHA1 Message Date
Paul Fultz II ad8abdb0c3 Add impossible values to ValueFlow (#2186)
* Add impossible category

* Replace values

* Try to adjust known values

* Add ! for impossible values

* Add impossible with possible values

* Remove contradictions

* Add values when the branch is not dead

* Only copy possible values

* Dont bail on while loops

* Load std lib in valueflow

* Check for function calls

* Fix stl errors

* Fix incorrect impossible check

* Fix heap-after-use error

* Remove impossible values when they are lowered

* Show the bound and remove overlaps

* Infer conditions

* Dont push pointer values through dynamic_cast

* Add test for dynamic_cast issue

* Add shifttoomanybits test

* Add test for div by zero

* Add a test for issue 9315

* Dont make impossible value inconclusive

* Fix FP with shift operator

* Improve handleKnownValuesInLoop for impossible values

* Fix cppcheck warning

* Fix impossible values for ctu

* Bailout for streams

* Check equality conditions

* Fix overflows

* Add regression test for 9332

* Remove duplicate conditions

* Skip impossible values for invalid value

* Check for null

* Rename bound to range

* Formatting
2019-09-20 15:06:37 +02:00
warmsocks a56bc006b7 Fixed a typo in lib/checkother.cpp. Corrected spelling errors found by codespell. (#2170) 2019-09-11 19:21:38 +02:00
fu7mu4 bcc9f81a6e cppcheck_ja.ts is updated (#2140) 2019-09-02 18:57:50 +02:00
PKEuS ee856ca3bb Updated german translation 2019-09-01 13:37:08 +02:00
Daniel Marjamäki c32261c737 Updated copyright year 2019-09-01 11:49:43 +02:00
Daniel Marjamäki a3845b6180 GUI: Updated translations 2019-09-01 11:47:52 +02:00
Daniel Marjamäki 22d7ca648d GUI: Remove the 'Safe Checks' tab in project settings. We need to tweak these checks and settings further. 2019-08-25 18:53:01 +02:00
Daniel Marjamäki cb119f5910 Fixed #8977 (GUI : Inspecting Cppcheck results) 2019-08-23 21:27:32 +02:00
Daniel Marjamäki c7b452c4f6 GUI: keep hidden results 2019-08-22 21:32:18 +02:00
Daniel Marjamäki d661ab09ce GUI: Fixed suppressions when reanalyzing files 2019-08-19 12:59:44 +02:00
Daniel Marjamäki 5d021cb41d GUI: Revert my theme changes. The theme selection will only be for the code editor again. 2019-08-18 21:11:46 +02:00
Daniel Marjamäki 2d9a131817 Refactoring: Rename variables. Do not use leading _. Renamed 'col' to 'column' 2019-08-18 12:19:05 +02:00
Daniel Marjamäki a17f2a6f05 Compiling/Installing : The CFGDIR parameter was removed. Use FILESDIR instead. 2019-08-17 10:53:07 +02:00
Daniel Marjamäki 831f2009f5 GUI: Set current dir when starting the GUI so results are shown properly 2019-08-14 10:23:36 +02:00
Daniel Marjamäki db57769c64 Try to make Travis happy 2019-08-11 17:57:59 +02:00
Daniel Marjamäki 6c55d27f19 Fixed #9240 (GUI: Issue with file names in suppressions (undesired expansion to full path)) 2019-08-11 15:53:23 +02:00
Daniel Marjamäki 0fbbe2ff23 Refactor load/write of cppcheck project. Reuse same string constants in cli and gui. 2019-08-09 21:15:02 +02:00
Daniel Marjamäki 16dc8a0540 GUI: Suppressing addon warnings 2019-08-09 19:00:09 +02:00
Daniel Marjamäki 6b662c7353 Fixed #8777 (GUI: Wrong platform used and shown in "Analysis Log") 2019-07-29 11:22:57 +02:00
Scott Furry 88e2e82039 Correct Signal/Slot signatures (#2035)
Previous commit had updated declarations in Code Editor Style Dialog to use
const QColor& and const QFont::Weight& variables. This change was not totally
complete as const usage was not propagated to Signal/Slot connect statements.

This commit corrects that oversight.
2019-07-25 08:29:42 +02:00
Daniel Marjamäki 37a345c7d0 Fixed constParameter warnings 2019-07-24 08:30:36 +02:00
Daniel Marjamäki 3ec45acc43 astyle formatting
[ci skip]
2019-07-24 08:22:12 +02:00
Daniel Marjamäki 46686c6c20 GUI: Fix test-projectfile testing 2019-07-23 18:09:00 +02:00
Daniel Marjamäki 681bd0a911 GUI: Better settings for extended safe checks 2019-07-23 11:54:38 +02:00
Daniel Marjamäki 8f9912d245 gui.pro: added -Wno-deprecated-declarations 2019-07-23 10:35:20 +02:00
Daniel Marjamäki dab0845ef1 Travis: Revert width=>horizontalAdvance change to fix CI 2019-07-23 10:28:45 +02:00
Daniel Marjamäki 896d953aa3 GUI: Fix a few Wdeprecated warnings 2019-07-22 22:40:11 +02:00
Daniel Marjamäki 70e0c66c35 GUI: Use theme in whole program 2019-07-22 15:55:51 +02:00
Daniel Marjamäki 82c6a72b48 Rename variable pDlg to dlg 2019-07-22 12:50:42 +02:00
Daniel Marjamäki 40600cbc38 GUI: Fixed build directory, use project file path by default 2019-07-17 16:01:54 +02:00
Daniel Marjamäki 97838f104c Fixed #8517 (GUI: Can't copy filename with right click) 2019-07-15 12:58:25 +02:00
fu7mu4 8e4f0c2d89 Update japanese translation (#1997)
* add MATCHCOMPILER=yes flag into readme in Japanese

* remove Donations from readmeja.md

* add cmake instructions in Japanese

* minor improvement in Japanese

* add Japanese translation on gui/cppcheck_ja.ts
2019-07-15 08:47:11 +02:00
Daniel Marjamäki 4854f0034d Fix Cppcheck warning 2019-07-14 22:55:35 +02:00
Wolfgang Stöggl 1c32455ae1 Fix some typos (#1983) 2019-07-12 17:55:44 +02:00
Daniel Marjamäki 68a48daf1f Fix Cppcheck warning 2019-07-12 08:27:10 +02:00
Daniel Marjamäki 4a70208e0e GUI: Activate 'human knowledge' options 2019-07-11 21:05:52 +02:00
Daniel Marjamäki 8eaa50c050 GUI: Tweak the 'Human knowledge' tab 2019-07-11 14:00:46 +02:00
Daniel Marjamäki e0f258db0c GUI: Start adding some 'human knowledge' configuration options 2019-07-11 10:27:18 +02:00
Scott Furry da213d1534 More Zero/Null as pointer constant corrections (#1947)
Further to pull request #1938. Changes were missed in previous commit.

Resolve warnings `warning: zero as null pointer constant` in code by
using C++ 11 recommended `nullptr`.
2019-07-02 20:37:44 +02:00
Scott Furry e459762bcd Suppress Code semantic and syntax warnings (#1936)
Sources were built with Clang but with increased verbosity of error detection.

A number of syntax and semantic warnings were encountered. Commit adds
changes to correct these warnings.

Some changes involve removing extra, and unncessary, semi-colons at EOL
(e.g. at end of switch clause).

Project astyle settings are not currently setup to detect if a file is to
have an extra carriage return after the last line of data. Two files were
altered to ensure an extra carriage return.

An advisory to enhance code was encountered in triage code. Clang advisory
on a for-loop interation value suggested that:
`use reference type 'const QString &' to prevent copying`
2019-06-30 21:43:25 +02:00
Scott Furry a195477470 Correct Zero/Null as pointer constant (#1938)
Building with enhanced clang warnings indicated a large number of
instances with the warning:

`warning: zero as null pointer constant`

Recommended practice in C++11 is to use `nullptr` as value for
a NULL or empty pointer value. All instances where this warning
was encountered were corrected in this commit.

Where warning was encountered in dependency code (i.e. external library)
no chnages were made. Patching will be offered upstream.
2019-06-30 21:39:22 +02:00
PKEuS 21f4574e74 lupdate and lrelease
Updated german translation
2019-06-29 09:50:53 +02:00
Daniel Marjamäki 84cc09d17c Update Copyright 2019-06-29 07:49:14 +02:00
Daniel Marjamäki d8daca30bf lupdate gui.pro 2019-06-29 07:47:36 +02:00
Daniel Marjamäki 0ab3d07f75 Revert "GUI: Show information label if Cppcheck is outdated"
I plan to add something like this again after the release.
2019-06-28 22:36:19 +02:00
Daniel Marjamäki 5f759e89b3 GUI: Show information label if Cppcheck is outdated 2019-06-28 20:13:59 +02:00
Scott Furry 6d3d44835a Add keyboard shortcuts for CodeEditor Widget (#1931)
Functionality for `copy` and `select all` text already exists as part
of widget construction. Commit adds connection of those existing
functions to execution with keyboard shortcuts user would normally expect.
(e.g. CTRL+C for copy text)

Qt does translation of keyboard shortcuts for platform
(i.e. Mac OS uses command key rather than control).
2019-06-28 17:17:24 +02:00
Scott Furry 158194d923 Propagate Monospaced Font to Line Number Area in Code Editor (#1923)
Styling change missed in #1913.
2019-06-25 20:22:02 +02:00
versat b1e2b9d61b astyle formatting
[ci skip]
2019-06-25 15:29:15 +02:00
Daniel Marjamäki b0e56f873f GUI: Use --cli option when running addons to get results in json format 2019-06-25 01:22:50 +02:00
Scott Furry 0d76d078e2 Implement User Selectable Code Editor Style in cppcheck-gui (#1913)
Building on #1874, commit adds user controls to choose
or edit style in cppcheck-gui ONLY. Commit does not
address CodeEditor style usage in triage app at this time.

Code Editor style can be altered from the added "Code Editor"
tab in the user preferences. The user has the option to select
default light, default dark, or to customize.

If user leaves the style set to light or dark defaults, this
will be reflected in the choices shown in the preferences
dialog.

User choice for Code Editor Style is saved in the cppcheck-gui
preferences under the heading "EditorStyle".
2019-06-23 19:04:53 +02:00
Daniel Marjamäki 0947a36c4f astyle formatting
[ci skip]
2019-06-08 07:24:38 +02:00
Scott Furry 32f45490e2 CodeEditor Widget Styling (#1874)
* CodeEditor Widget Styling

With profileration of Qt5 styling methods, problems with presentation
can occur when using cppcheck-gui and user choosen themes. With a dark
theme, a highlighted line in the CodeEditor appears with white text on
a light background or dark colors on a dark background.

Commit makes changes to enforce a default style on the Code Editor widget.
Mechanism is provided, if desired, where a user defined styling can
be provided to CodeEditor widget.

* CodeEditor Widget Styling

With profileration of Qt5 styling methods, problems with presentation
can occur when using cppcheck-gui and user choosen themes. With a dark
theme, a highlighted line in the CodeEditor appears with white text on
a light background or dark colors on a dark background.

Commit makes changes to enforce a default style on the Code Editor widget.
Mechanism is provided, if desired, where a user defined styling can
be provided to CodeEditor widget.

2nd commit - remove declarations in gui/codeeditorstyle.h to possibly
resolve appveyor window builds.
2019-06-08 07:23:48 +02:00
Scott Furry a5c1884810 Minor changes to gui code to silence repeated build warnings (#1872)
Compile of gui would result in repeated warnings from two conditions:

1) gui/erroritem.h:104:30: warning: extra ‘;’ [-Wpedantic]
Message points to Qt Macro Q_DECLARE_METATYPE usage.
Semi Colon at EOL removed.

2) gui/resultstree.h:201:10: warning [-Woverloaded-virtual]
Message is indicating that function ResultsTree::selectionChanged
is being iterpreted as overloading function of the same name
in base clase (QTreeView::selectionChanged).
Refactored - function renamed to ResultsTree::treeSelectionChanged
2019-06-05 10:13:37 +02:00
Scott Furry dc5a38e61c Modify Qt5 CMake and include Qt Charts Option (#1837)
Update CMake search for Qt5 componets to be consistent
with recommended practice from Kitware.
(see https://blog.kitware.com/cmake-finding-qt5-the-right-way/)

Incorporate ability to build cppcheck-gui with Qt Charts
via CMake switch. Option "WITH_QCHARTS" will enable
search for Qt Charts to Qt5 component search and add
build flag "HAVE_QCHART".
2019-05-17 10:17:51 +02:00
Daniel Marjamäki 5b07901253 GUI: Add C++20 option 2019-05-05 10:44:09 +02:00
Daniel Marjamäki 0053476bef Fix Cppcheck warnings 2019-04-30 01:46:02 +02:00
Daniel Marjamäki ff8cf4fe25 gui/test: Add projectfile test 2019-04-20 19:07:14 +02:00
Daniel Marjamäki 3327102aa4 GUI: Test ProjectFile::getCheckSuppressions() 2019-04-19 15:09:55 +02:00
Daniel Marjamäki ae3e53f391 Travis: Try to fix gui/test 2019-04-19 13:45:14 +02:00
Daniel Marjamäki 91c000c09d Travis: Try to reactivate the gui/test tests 2019-04-19 11:57:52 +02:00
Daniel Marjamäki 93b27b2022 cleanup gui/test 2019-04-19 09:41:58 +02:00
Daniel Marjamäki d89923386d Removed gui/test/xmlreport 2019-04-19 08:41:48 +02:00
Daniel Marjamäki fee01099a9 GUI: Fix tests 2019-04-19 07:39:43 +02:00
Daniel Marjamäki b2e3af5869 Fixed #8637 (GUI: Supression filename should accept relative paths) 2019-04-18 09:52:29 +02:00
Daniel Marjamäki ccc830870c GUI: Updated selection of files/folders. Prefer relative paths. 2019-04-16 10:32:34 +02:00
Daniel Marjamäki a0dd853642 analyzing one vs config (first debug config that matches platform) 2019-04-13 20:01:40 +02:00
Daniel Marjamäki d7e08ce75f GUI: Refactoring handling of setting for c++/c std 2019-04-12 12:12:12 +02:00
Daniel Marjamäki f7be03fcbc GUI: removed -std=posix and added -std=c++17 2019-04-12 11:52:28 +02:00
Daniel Marjamäki dfe417c369 msvc compatibility: /constexpr/const/ 2019-04-11 21:06:37 +02:00
Daniel Marjamäki 3c1f6ae5c2 appveyor: /constexpr/const/ 2019-04-10 21:27:07 +02:00
Daniel Marjamäki 37c540b380 Use constexpr 2019-04-10 16:54:16 +02:00
Daniel Marjamäki f6b410b469 GUI: add setting for 'checkHeaders', 'checkUnusedTemplates' and 'maxCtuDepth' to project 2019-04-10 16:49:24 +02:00
Daniel Marjamäki 7237acdb47 GUI: In the project dialog select libraries in a listbox 2019-04-06 16:44:43 +02:00
Sebastian 08d41ab8af
Load std.cfg before all other libraries (#1740)
- CLI: Save the libraries that should be loaded to a list and load them
after the std.cfg has been loaded.
- GUI: Load std.cfg (and windows.cfg / posix.cfg when applicable) before
setting other options and loading the other libraries.
In the project-file-dialog the std.cfg is searched first. If some
other library fails to load is is retried with first loading std.cfg.
- boost.cfg: Enable containers that depend on std containers.
2019-03-15 06:59:37 +01:00
Daniel Marjamäki 6717f49f20 Try to give some credit to the 3rd party libraries we use. 2019-02-10 17:16:53 +01:00
Daniel Marjamäki bd7790fd8c Update copyright year 2019-02-09 07:24:06 +01:00
Daniel Marjamäki 7ac43eda79 lupdate gui.pro 2019-02-09 07:20:17 +01:00
Lauri Nurmi a7a0a54557 Show a clear button in the Quick Filter text field in GUI. (#1603) 2019-01-15 10:35:23 +01:00
Daniel Marjamäki f629fa3d66 Fix Cppcheck warning
[ci skip]
2019-01-12 18:29:34 +01:00
amai2012 e259e7bc6c #8626 twin include. Remove redundant include 2018-12-31 19:47:23 +01:00
Oliver Schode 1dd4c7a71e Fixed typo in warning about modified variable inside assertion (#1542) 2018-12-28 15:24:50 +01:00
Sebastian b51f19d530
Fix some doxygen warnings/issues in the comments (#1537) 2018-12-21 21:23:03 +01:00
fu7mu4 2abb3aa263 fix japanese translation typo and manual version (#1515) 2018-12-09 09:06:56 +01:00
Daniel Marjamäki d9db20db96 Update copyright year 2018-12-08 07:53:28 +01:00
Daniel Marjamäki 7ad93fa1a2 lupdate 2018-12-08 07:51:03 +01:00
Daniel Marjamäki 2c5a31594c fix argument name 2018-12-08 07:37:27 +01:00
Daniel Marjamäki f5c2abaefa Fix shadow warning 2018-11-19 10:21:02 +01:00
Markus Elfring 02c2018f25 Addition of a null pointer check in ProjectFileDialog::removeSuppression() (#1457)
The function “QListWidget::takeItem” is documented in the way
that a null pointer can be returned. This result was not checked
by the function “ProjectFileDialog::removeSuppression” so far.
Thus add a corresponding check so that an inappropriate pointer access
should not happen any more here.

Link: https://sourceforge.net/p/cppcheck/discussion/development/thread/d1d0b65245/#a1bf
Link: https://trac.cppcheck.net/ticket/8814
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
2018-10-29 14:21:56 +01:00
Daniel Marjamäki 4533eb0bd6 GUI: cleanup the code 2018-10-22 21:00:04 +02:00
tompollok ae657d49e8 enable AA_UseHighDpiPixmaps (#1446)
enables AA_UseHighDpiPixmaps for less pixeled icons on 4K displays
2018-10-22 19:07:02 +02:00
Daniel Marjamäki 1a75084d75 GUI: Refactor comparisons 2018-10-20 16:30:40 +02:00
fu7mu4 b31b4706c5 cppcheck_ja.ts is updated (#1435) 2018-10-17 16:03:41 +02:00
Alexander ee2cea026a Fixed bug with incorrect platform used for check if check is run from UI and platform settings is taken from xml file. (#1434) 2018-10-17 12:44:41 +02:00
Markus Elfring 937da6bd46 Put XmlReportV2 object on the stack in ResultsView::readErrorsXml() (#1430)
Dynamic memory allocation was used for a XmlReportV2 object
in the function “ResultsView::readErrorsXml”.
This object was put on the stack instead so that this software
became a bit safer and more efficient.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
2018-10-17 06:38:14 +02:00
Daniel Marjamäki 7833ade128 Updated copyright year 2018-10-13 18:20:31 +02:00
Daniel Marjamäki f9157f2aeb lupdate gui.pro 2018-10-13 18:17:43 +02:00
PKEuS 8f32811b80 Updated german translation 2018-10-13 09:31:02 +02:00
alex babafd75e3 Added support for -U option to the GUI. 2018-10-09 15:05:05 +02:00
Daniel Marjamäki 59731d70e8 triage: set error line properly 2018-09-01 06:39:22 +02:00