/* * Cppcheck - A tool for static C/C++ code analysis * Copyright (C) 2007-2009 Daniel Marjamäki and Cppcheck team. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program. If not, see <http://www.gnu.org/licenses/>. */ #include "tokenize.h" #include "checkstl.h" #include "testsuite.h" #include <sstream> extern std::ostringstream errout; class TestStl : public TestFixture { public: TestStl() : TestFixture("TestStl") { } private: void run() { TEST_CASE(iterator1); TEST_CASE(iterator2); TEST_CASE(iterator3); TEST_CASE(iterator4); TEST_CASE(iterator5); TEST_CASE(dereference); TEST_CASE(dereference_member); TEST_CASE(STLSize); TEST_CASE(STLSizeNoErr); TEST_CASE(erase); TEST_CASE(eraseBreak); TEST_CASE(eraseReturn); TEST_CASE(eraseGoto); TEST_CASE(eraseAssign); TEST_CASE(eraseErase); TEST_CASE(pushback1); TEST_CASE(pushback2); TEST_CASE(pushback3); TEST_CASE(pushback4); TEST_CASE(pushback5); TEST_CASE(pushback6); TEST_CASE(pushback7); TEST_CASE(pushback8); TEST_CASE(pushback9); TEST_CASE(insert1); TEST_CASE(invalidcode); TEST_CASE(stlBoundries1); TEST_CASE(stlBoundries2); TEST_CASE(stlBoundries3); // find TEST_CASE(find1); } void check(const std::string &code) { // Tokenize.. Tokenizer tokenizer; std::istringstream istr(code.c_str()); tokenizer.tokenize(istr, "test.cpp"); tokenizer.setVarId(); // Clear the error buffer.. errout.str(""); // Check.. CheckStl checkStl; checkStl.runSimplifiedChecks(&tokenizer, (const Settings *)0, this); } void iterator1() { check("void f()\n" "{\n" " list<int> l1;\n" " list<int> l2;\n" " for (list<int>::iterator it = l1.begin(); it != l2.end(); ++it)\n" " { }\n" "}\n"); ASSERT_EQUALS("[test.cpp:5]: (error) Same iterator is used with both l1 and l2\n", errout.str()); } void iterator2() { check("void foo()\n" "{\n" " list<int> l1;\n" " list<int> l2;\n" " list<int>::iterator it = l1.begin();\n" " while (it != l2.end())\n" " {\n" " ++it;\n" " }\n" "}\n"); ASSERT_EQUALS("[test.cpp:6]: (error) Same iterator is used with both l1 and l2\n", errout.str()); } void iterator3() { check("void foo()\n" "{\n" " list<int> l1;\n" " list<int> l2;\n" " list<int>::iterator it = l1.begin();\n" " l2.insert(it, 0);\n" "}\n"); ASSERT_EQUALS("[test.cpp:6]: (error) Same iterator is used with both l1 and l2\n", errout.str()); } void iterator4() { check("void foo(std::vector<std::string> &test)\n" "{\n" " std::set<int> result;\n" " for (std::vector<std::string>::const_iterator cit = test.begin();\n" " cit != test.end();\n" " ++cit)\n" " {\n" " result.insert(cit->size());\n" " }\n" "}\n"); ASSERT_EQUALS("", errout.str()); } void iterator5() { check("void foo()\n" "{\n" " std::vector<int> ints1;\n" " std::vector<int> ints2;\n" " std::vector<int>::iterator it = std::find(ints1.begin(), ints2.end(), 22);\n" "}\n"); ASSERT_EQUALS("[test.cpp:5]: (error) mismatching containers\n", errout.str()); } // Dereferencing invalid pointer void dereference() { check("void f()\n" "{\n" " std::vector<int> ints;\n" " std::vector<int>::iterator iter;\n" " iter = ints.begin() + 2;\n" " ints.erase(iter);\n" " std::cout << (*iter) << std::endl;\n" "}\n"); ASSERT_EQUALS("[test.cpp:7]: (error) Dereferenced iterator 'iter' has been erased\n", errout.str()); } void dereference_member() { check("void f()\n" "{\n" " std::map<int, int> ints;\n" " std::map<int, int>::iterator iter;\n" " iter = ints.begin();\n" " ints.erase(iter);\n" " std::cout << iter->first << std::endl;\n" "}\n"); ASSERT_EQUALS("[test.cpp:7]: (error) Dereferenced iterator 'iter' has been erased\n", errout.str()); } void STLSize() { check("void foo()\n" "{\n" " std::vector<int> foo;\n" " for (unsigned int ii = 0; ii <= foo.size(); ++ii)\n" " {\n" " foo[ii] = 0;\n" " }\n" "}\n"); ASSERT_EQUALS("[test.cpp:6]: (error) When ii==foo.size(), foo[ii] is out of bounds\n", errout.str()); check("void foo()\n" "{\n" " std::vector<int> foo;\n" " foo.push_back(1);\n" " for (unsigned int ii = 0; ii <= foo.size(); ++ii)\n" " {\n" " }\n" " int ii = 0;\n" " foo[ii] = 0;\n" "}\n"); ASSERT_EQUALS("", errout.str()); } void STLSizeNoErr() { { check("void foo()\n" "{\n" " std::vector<int> foo;\n" " for (unsigned int ii = 0; ii < foo.size(); ++ii)\n" " {\n" " foo[ii] = 0;\n" " }\n" "}\n"); ASSERT_EQUALS("", errout.str()); } { check("void foo()\n" "{\n" " std::vector<int> foo;\n" " for (unsigned int ii = 0; ii <= foo.size(); ++ii)\n" " {\n" " }\n" "}\n"); ASSERT_EQUALS("", errout.str()); } { check("void foo()\n" "{\n" " std::vector<int> foo;\n" " for (unsigned int ii = 0; ii <= foo.size(); ++ii)\n" " {\n" " if (ii == foo.size())\n" " {\n" " }\n" " else\n" " {\n" " foo[ii] = 0;\n" " }\n" " }\n" "}\n"); ASSERT_EQUALS("", errout.str()); } } void erase() { check("void f()\n" "{\n" " for (it = foo.begin(); it != foo.end(); ++it)\n" " {\n" " foo.erase(it);\n" " }\n" "}\n"); ASSERT_EQUALS("[test.cpp:5]: (error) Dangerous usage of erase\n", errout.str()); check("for (it = foo.begin(); it != foo.end(); ++it)\n" "{\n" " foo.erase(it);\n" "}\n" "for (it = foo.begin(); it != foo.end(); ++it)\n" "{\n" " foo.erase(it);\n" "}\n"); ASSERT_EQUALS("[test.cpp:3]: (error) Dangerous usage of erase\n[test.cpp:7]: (error) Dangerous usage of erase\n", errout.str()); check("void f(std::list<int> &ints)\n" "{\n" " std::list<int>::iterator i = ints.begin();\n" " i = ints.erase(i);\n" " *i = 0;\n" " \n" "}\n"); ASSERT_EQUALS("", errout.str()); } void eraseBreak() { check("void f()\n" "{\n" " for (it = foo.begin(); it != foo.end(); ++it)\n" " {\n" " foo.erase(it);\n" " break;\n" " }\n" "}\n"); ASSERT_EQUALS("", errout.str()); } void eraseReturn() { check("void f()\n" "{\n" " for (it = foo.begin(); it != foo.end(); ++it)\n" " {\n" " foo.erase(it);\n" " return;\n" " }\n" "}\n"); ASSERT_EQUALS("", errout.str()); } void eraseGoto() { check("void f()\n" "{\n" " for (it = foo.begin(); it != foo.end(); ++it)\n" " {\n" " foo.erase(it);\n" " goto abc;\n" " }\n" "bar:\n" "}\n"); ASSERT_EQUALS("", errout.str()); } void eraseAssign() { check("void f()\n" "{\n" " for (it = foo.begin(); it != foo.end(); ++it)\n" " {\n" " foo.erase(it);\n" " it = foo.begin();\n" " }\n" "}\n"); ASSERT_EQUALS("", errout.str()); } void eraseErase() { check("void f(std::vector<ints> &ints)\n" "{\n" " std::vector<int>::iterator iter;\n" " iter = ints.begin() + 2;\n" " ints.erase(iter);\n" " ints.erase(iter);\n" "}\n"); TODO_ASSERT_EQUALS("[test.cpp:6]: (error) Erasing invalid iterator\n", errout.str()); } void pushback1() { check("void f(const std::vector<int> &foo)\n" "{\n" " std::vector<int>::const_iterator it = foo.begin();\n" " foo.push_back(123);\n" " *it;\n" "}\n"); ASSERT_EQUALS("[test.cpp:5]: (error) After push_back, the iterator 'it' may be invalid\n", errout.str()); } void pushback2() { check("void f()\n" "{\n" " std::vector<int>::const_iterator it = foo.begin();\n" " foo.push_back(123);\n" " {\n" " int *it = &foo[0];\n" " *it = 456;\n" " }\n" "}\n"); ASSERT_EQUALS("", errout.str()); } void pushback3() { check("void f()\n" "{\n" " std::vector<int> foo;\n" " foo.push_back(10);\n" " std::vector<int>::iterator it;\n" " for (it = foo.begin(); it != foo.end(); ++it)\n" " {\n" " foo.push_back(123);\n" " }\n" "}\n"); ASSERT_EQUALS("[test.cpp:8]: (error) After push_back, the iterator 'it' may be invalid\n", errout.str()); } void pushback4() { check("void f()\n" "{\n" " std::vector<int> ints;\n" " ints.push_back(1);\n" " int *first = &ints[0];\n" " ints.push_back(2);\n" " *first;\n" "}\n"); ASSERT_EQUALS("[test.cpp:7]: (error) Invalid pointer 'first' after push_back / push_front\n", errout.str()); } void pushback5() { check("void f()\n" "{\n" " std::vector<int>::const_iterator i;\n" "\n" " for (i=v.begin(); i!=v.end(); ++i)\n" " {\n" " }\n" "\n" " for (i=rhs.v.begin(); i!=rhs.v.end(); ++i)\n" " {\n" " v.push_back(*i);\n" " }\n" "}"); ASSERT_EQUALS("", errout.str()); } void pushback6() { // ticket #735 check("void f()\n" "{\n" " vector<int> v;\n" " vector.push_back(1);\n" " vector.push_back(2);\n" " for (vector<int>::iterator it = v.begin(); it != v.end(); ++it)\n" " {\n" " if (*it == 1)\n" " v.push_back(10);\n" " }\n" "}\n"); ASSERT_EQUALS("[test.cpp:9]: (error) After push_back, the iterator 'it' may be invalid\n", errout.str()); check("void f()\n" "{\n" " std::vector<int> v;\n" " vector.push_back(1);\n" " vector.push_back(2);\n" " for (std::vector<int>::iterator it = v.begin(); it != v.end(); ++it)\n" " {\n" " if (*it == 1)\n" " v.push_back(10);\n" " }\n" "}\n"); ASSERT_EQUALS("[test.cpp:9]: (error) After push_back, the iterator 'it' may be invalid\n", errout.str()); } void pushback7() { check("void f()\n" "{\n" " std::vector<int> foo;\n" " foo.push_back(10);\n" " std::vector<int>::iterator it;\n" " for (it = foo.begin(); it != foo.end(); it++)\n" " {\n" " foo.push_back(123);\n" " }\n" "}\n"); ASSERT_EQUALS("[test.cpp:8]: (error) After push_back, the iterator 'it' may be invalid\n", errout.str()); } void pushback8() { check("void f()\n" "{\n" " std::vector<int> ints;\n" " std::vector<int>::const_iterator end = ints.end();\n" " ints.push_back(10);\n" " std::vector<int>::iterator it;\n" " unsigned int sum = 0;\n" " for (it = ints.begin(); it != end; ++it)\n" " {\n" " sum += *it;\n" " }\n" "}\n"); ASSERT_EQUALS("[test.cpp:8]: (error) After push_back, the iterator 'end' may be invalid\n", errout.str()); } void pushback9() { check("struct A {\n" " std::vector<int> ints;\n" "};\n" "\n" "void f()\n" "{\n" " std::vector<int> ints;\n" " A a;\n" " std::vector<int>::const_iterator i = ints.begin();\n" " std::vector<int>::const_iterator e = ints.end();\n" " while (i != e)\n" " {\n" " a.ints.push_back(*i);\n" " ++i;\n" " }\n" "}\n"); ASSERT_EQUALS("", errout.str()); } void insert1() { check("void f(std::vector<int> &ints)\n" "{\n" " std::vector<int>::iterator iter = ints.begin() + 5;\n" " ints.insert(ints.begin(), 1);\n" " ++iter;\n" "}\n"); ASSERT_EQUALS("[test.cpp:5]: (error) After insert, the iterator 'iter' may be invalid\n", errout.str()); check("void f()\n" "{\n" " std::vector<int> ints;\n" " std::vector<int>::iterator iter = ints.begin();\n" " ints.insert(iter, 1);\n" "}\n"); ASSERT_EQUALS("", errout.str()); check("void f()\n" "{\n" " std::vector<int> ints;\n" " std::vector<int>::iterator iter = ints.begin();\n" " ints.insert(iter, 1);\n" " ints.insert(iter, 2);\n" "}\n"); ASSERT_EQUALS("[test.cpp:6]: (error) After insert, the iterator 'iter' may be invalid\n", errout.str()); } void invalidcode() { errout.str(""); const std::string src = "void f()\n" "{\n" " for ( \n" "}\n"; Tokenizer tokenizer(0, this); std::istringstream istr(src); ASSERT_EQUALS(false, tokenizer.tokenize(istr, "test.cpp")); ASSERT_EQUALS("[test.cpp:3]: (error) Invalid number of character ((). Can't process file.\n", errout.str()); } void stlBoundries1() { const int STL_CONTAINER_LIST = 9; const std::string stlCont[STL_CONTAINER_LIST] = {"deque", "list", "set", "multiset", "map", "multimap", "hash_map", "hash_multimap", "hash_set" }; for (int i = 0; i < STL_CONTAINER_LIST; ++i) { check("void f()\n" "{\n" " std::" + stlCont[i] + "<int>::iterator it;\n" " for (it = ab.begin(); it < ab.end(); ++it)\n" " ;\n" "}\n"); ASSERT_EQUALS("[test.cpp:4]: (error) " + stlCont[i] + " range check should use != and not < since the order of the pointers isn't guaranteed\n", errout.str()); } } void stlBoundries2() { check("void f()\n" "{\n" " std::vector<std::string> files;\n" " std::vector<std::string>::const_iterator it;\n" " for (it = files.begin(); it < files.end(); it++) { }\n" " for (it = files.begin(); it < files.end(); it++) { };\n" "}\n"); ASSERT_EQUALS("", errout.str()); } void stlBoundries3() { check("void f()\n" "{\n" " set<int> files;\n" " set<int>::const_iterator current;\n" " for (current = files.begin(); current != files.end(); ++current)\n" " {\n" " assert(*current < 100)\n" " }\n" "}\n"); ASSERT_EQUALS("", errout.str()); } void find1() { check("void f(std::vector<int> &ints)\n" "{\n" " std::vector<int>::iterator it = std::find(ints.begin(), ints.end(), 33);\n" " *it = 11;\n" "}\n"); ASSERT_EQUALS("", errout.str()); } }; REGISTER_TEST(TestStl)