/* * Cppcheck - A tool for static C/C++ code analysis * Copyright (C) 2007-2009 Daniel Marjamäki and Cppcheck team. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program. If not, see tokens(); while (tok) { unsigned int varId = 0; // Search for a variable declaration while (tok) { if (Token::Match(tok, "int %var% ;")) { varId = tok->next()->varId(); break; } tok = tok->next(); } if (!tok) break; // Skip ahead a little with tok.. tok = tok->tokAt(2); if (!tok) break; // Now take a look at the variable usage.. if (varId == 0) continue; // Search for bad input.. for (const Token *tok2 = tok; tok2; tok2 = tok2->next()) { if (Token::Match(tok2, "cin >> %varid%", varId)) unvalidatedInput(tok2); if (Token::Match(tok2, "fscanf ( %var% , %str% , %varid%", varId)) unvalidatedInput(tok2); if (Token::Match(tok2, "scanf ( %str% , %varid%", varId)) unvalidatedInput(tok2); } } } /** * Read data from Form/GUI * Todo: This function must be more customizable to be usable */ void CheckSecurity::gui() { // input control classes whose values are insecure.. const char *inputclass[] = {"TEdit", 0}; // functions that parse value without validating it.. const std::string dangerousfunc("atoi|atof|strtol|strtoul"); for (unsigned int i = 0; inputclass[i]; ++i) { const std::string classname(inputclass[i]); for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next()) { // Declaration.. if (Token::Match(tok, (classname + " * %var% ;|=").c_str())) { // Variable name.. const std::string varname(tok->strAt(2)); // Getting the value.. const Token *tok2 = Token::findmatch(tok, (dangerousfunc + " ( " + varname + " .").c_str()); if (tok2) unvalidatedInput(tok2); } } } } void CheckSecurity::unvalidatedInput(const Token *tok) { reportError(tok, "security", "unvalidatedInput", "Unvalidated input"); }