/* * Cppcheck - A tool for static C/C++ code analysis * Copyright (C) 2007-2010 Daniel Marjamäki and Cppcheck team. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program. If not, see . */ #include "tokenize.h" #include "checkobsoletefunctions.h" #include "testsuite.h" #include extern std::ostringstream errout; class TestObsoleteFunctions : public TestFixture { public: TestObsoleteFunctions() : TestFixture("TestObsoleteFunctions") { } private: void run() { TEST_CASE(testbsd_signal); TEST_CASE(testgethostbyname); TEST_CASE(testgethostbyaddr); TEST_CASE(testusleep); TEST_CASE(testindex); TEST_CASE(testrindex); // no false positives for variables TEST_CASE(var); } void check(const char code[]) { // Tokenize.. Tokenizer tokenizer; std::istringstream istr(code); tokenizer.tokenize(istr, "test.cpp"); tokenizer.simplifyTokenList(); // Assign variable ids tokenizer.setVarId(); // Fill function list tokenizer.fillFunctionList(); // Clear the error buffer.. errout.str(""); // Check for obsolete functions.. Settings settings; settings._checkCodingStyle = true; settings.inconclusive = true; CheckObsoleteFunctions checkObsoleteFunctions(&tokenizer, &settings, this); checkObsoleteFunctions.obsoleteFunctions(); } void testbsd_signal() { check("void f()\n" "{\n" " bsd_signal(SIGABRT, SIG_IGN);\n" "}\n"); ASSERT_EQUALS("[test.cpp:3]: (style) Found obsolete function 'bsd_signal'. It is recommended that new applications use the 'sigaction' function\n", errout.str()); check("int f()\n" "{\n" " int bsd_signal(0);\n" " return bsd_signal;\n" "}\n"); ASSERT_EQUALS("", errout.str()); } void testgethostbyname() { check("void f()\n" "{\n" " struct hostent *hp;\n" " if(!hp = gethostbyname('127.0.0.1')) {\n" " exit(1);\n" " }\n" "}\n"); ASSERT_EQUALS("[test.cpp:4]: (style) Found obsolete function 'gethostbyname'. It is recommended that new applications use the 'getnameinfo' function\n", errout.str()); } void testgethostbyaddr() { check("void f()\n" "{\n" " long addr;\n" " addr = inet_addr('127.0.0.1');\n" " if(!hp = gethostbyaddr((char *) &addr, sizeof(addr), AF_INET)) {\n" " exit(1);\n" " }\n" "}\n"); ASSERT_EQUALS("[test.cpp:5]: (style) Found obsolete function 'gethostbyaddr'. It is recommended that new applications use the 'getaddrinfo' function\n", errout.str()); } void testusleep() { check("void f()\n" "{\n" " usleep( 1000 );\n" "}\n"); ASSERT_EQUALS("[test.cpp:3]: (style) Found obsolete function 'usleep'. It is recommended that new applications use the 'nanosleep' or 'setitimer' function\n", errout.str()); } void testindex() { check("namespace n1 {\n" " int index(){};\n" "}\n" "int main()\n" "{\n" " n1::index();\n" "}\n"); ASSERT_EQUALS("", errout.str()); check("std::size_t f()\n" "{\n" " std::size_t index(0);\n" " index++;\n" " return index;\n" "}\n"); ASSERT_EQUALS("", errout.str()); check("int f()\n" "{\n" " return this->index();\n" "}\n"); ASSERT_EQUALS("", errout.str()); check("void f()\n" "{\n" " int index( 0 );\n" "}\n"); ASSERT_EQUALS("", errout.str()); check("const char f()\n" "{\n" " const char var[6] = 'index';\n" " const char i = index(var, 0);\n" " return i;\n" "}\n"); ASSERT_EQUALS("[test.cpp:4]: (style) Found obsolete function 'index'. It is recommended to use the function 'strchr' instead\n", errout.str()); } void testrindex() { check("void f()\n" "{\n" " int rindex( 0 );\n" "}\n"); ASSERT_EQUALS("", errout.str()); check("void f()\n" "{\n" " const char var[7] = 'rindex';\n" " print(rindex(var, 0));\n" "}\n"); ASSERT_EQUALS("[test.cpp:4]: (style) Found obsolete function 'rindex'. It is recommended to use the function 'strrchr' instead\n", errout.str()); } void var() { check("class Fred {\n" "public:\n" " Fred() : index(0) { }\n" " int index;\n" "};\n"); ASSERT_EQUALS("", errout.str()); } }; REGISTER_TEST(TestObsoleteFunctions)