106 lines
3.7 KiB
C++
106 lines
3.7 KiB
C++
/*
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|
* Copyright (C) 2007-2023 Cppcheck team.
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
|
|
#include "checkboost.h"
|
|
#include "errortypes.h"
|
|
#include "settings.h"
|
|
#include "fixture.h"
|
|
#include "tokenize.h"
|
|
|
|
#include <sstream> // IWYU pragma: keep
|
|
|
|
class TestBoost : public TestFixture {
|
|
public:
|
|
TestBoost() : TestFixture("TestBoost") {}
|
|
|
|
private:
|
|
const Settings settings = settingsBuilder().severity(Severity::style).severity(Severity::performance).build();
|
|
|
|
void run() override {
|
|
TEST_CASE(BoostForeachContainerModification);
|
|
}
|
|
|
|
#define check(code) check_(code, __FILE__, __LINE__)
|
|
void check_(const char code[], const char* file, int line) {
|
|
// Clear the error buffer..
|
|
errout.str("");
|
|
|
|
// Tokenize..
|
|
Tokenizer tokenizer(&settings, this);
|
|
std::istringstream istr(code);
|
|
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
|
|
|
|
// Check..
|
|
runChecks<CheckBoost>(tokenizer, this);
|
|
}
|
|
|
|
void BoostForeachContainerModification() {
|
|
check("void f() {\n"
|
|
" vector<int> data;\n"
|
|
" BOOST_FOREACH(int i, data) {\n"
|
|
" data.push_back(123);\n"
|
|
" }\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside.\n", errout.str());
|
|
|
|
check("void f() {\n"
|
|
" set<int> data;\n"
|
|
" BOOST_FOREACH(int i, data) {\n"
|
|
" data.insert(123);\n"
|
|
" }\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside.\n", errout.str());
|
|
|
|
check("void f() {\n"
|
|
" set<int> data;\n"
|
|
" BOOST_FOREACH(const int &i, data) {\n"
|
|
" data.erase(123);\n"
|
|
" }\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside.\n", errout.str());
|
|
|
|
// Check single line usage
|
|
check("void f() {\n"
|
|
" set<int> data;\n"
|
|
" BOOST_FOREACH(const int &i, data)\n"
|
|
" data.clear();\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside.\n", errout.str());
|
|
|
|
// Container returned as result of a function -> Be quiet
|
|
check("void f() {\n"
|
|
" BOOST_FOREACH(const int &i, get_data())\n"
|
|
" data.insert(i);\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// Break after modification (#4788)
|
|
check("void f() {\n"
|
|
" vector<int> data;\n"
|
|
" BOOST_FOREACH(int i, data) {\n"
|
|
" data.push_back(123);\n"
|
|
" break;\n"
|
|
" }\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
};
|
|
|
|
REGISTER_TEST(TestBoost)
|