137 lines
4.0 KiB
C++
137 lines
4.0 KiB
C++
/*
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|
* Copyright (C) 2007-2011 Daniel Marjamäki and Cppcheck team.
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
|
|
#include "tokenize.h"
|
|
#include "checkexceptionsafety.h"
|
|
#include "testsuite.h"
|
|
#include <sstream>
|
|
|
|
extern std::ostringstream errout;
|
|
|
|
class TestExceptionSafety : public TestFixture {
|
|
public:
|
|
TestExceptionSafety() : TestFixture("TestExceptionSafety")
|
|
{ }
|
|
|
|
private:
|
|
|
|
void run() {
|
|
TEST_CASE(destructors);
|
|
TEST_CASE(deallocThrow1);
|
|
TEST_CASE(deallocThrow2);
|
|
TEST_CASE(rethrowCopy1);
|
|
TEST_CASE(rethrowCopy2);
|
|
TEST_CASE(rethrowCopy3);
|
|
}
|
|
|
|
void check(const std::string &code) {
|
|
// Clear the error buffer..
|
|
errout.str("");
|
|
|
|
Settings settings;
|
|
settings.addEnabled("all");
|
|
|
|
// Tokenize..
|
|
Tokenizer tokenizer(&settings, this);
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.simplifyTokenList();
|
|
|
|
// Check char variable usage..
|
|
CheckExceptionSafety checkExceptionSafety(&tokenizer, &settings, this);
|
|
checkExceptionSafety.runSimplifiedChecks(&tokenizer, &settings, this);
|
|
}
|
|
|
|
void destructors() {
|
|
check("x::~x()\n"
|
|
"{\n"
|
|
" throw e;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Throwing exception in destructor\n", errout.str());
|
|
}
|
|
|
|
void deallocThrow1() {
|
|
check("int * p;\n"
|
|
"void f(int x)\n"
|
|
"{\n"
|
|
" delete p;\n"
|
|
" if (x)\n"
|
|
" throw 123;\n"
|
|
" p = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Throwing exception in invalid state, p points at deallocated memory\n", errout.str());
|
|
}
|
|
|
|
void deallocThrow2() {
|
|
check("void f() {\n"
|
|
" int* p = 0;\n"
|
|
" delete p;\n"
|
|
" throw 1;\n"
|
|
" p = new int;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void rethrowCopy1() {
|
|
check("void f() {\n"
|
|
" try\n"
|
|
" {\n"
|
|
" foo();\n"
|
|
" }\n"
|
|
" catch(const exception& err)\n"
|
|
" {\n"
|
|
" throw err;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (style) Throwing a copy of the caught exception instead of rethrowing the original exception\n", errout.str());
|
|
}
|
|
|
|
void rethrowCopy2() {
|
|
check("void f() {\n"
|
|
" try\n"
|
|
" {\n"
|
|
" foo();\n"
|
|
" }\n"
|
|
" catch(exception err)\n"
|
|
" {\n"
|
|
" throw err;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (style) Throwing a copy of the caught exception instead of rethrowing the original exception\n", errout.str());
|
|
}
|
|
|
|
void rethrowCopy3() {
|
|
check("void f() {\n"
|
|
" try\n"
|
|
" {\n"
|
|
" foo();\n"
|
|
" }\n"
|
|
" catch(exception err)\n"
|
|
" {\n"
|
|
" exception err2;\n"
|
|
" throw err2;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
};
|
|
|
|
REGISTER_TEST(TestExceptionSafety)
|
|
|