142 lines
4.7 KiB
C++
142 lines
4.7 KiB
C++
/*
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|
* Copyright (C) 2007-2020 Cppcheck team.
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "config.h"
|
|
#include "exprengine.h"
|
|
#include "settings.h"
|
|
#include "tokenize.h"
|
|
#include "testsuite.h"
|
|
|
|
class TestBughuntingChecks : public TestFixture {
|
|
public:
|
|
TestBughuntingChecks() : TestFixture("TestBughuntingChecks") {
|
|
settings.platform(cppcheck::Platform::Unix64);
|
|
}
|
|
|
|
private:
|
|
Settings settings;
|
|
|
|
void run() OVERRIDE {
|
|
#ifdef USE_Z3
|
|
settings.inconclusive = true;
|
|
LOAD_LIB_2(settings.library, "std.cfg");
|
|
TEST_CASE(uninit);
|
|
TEST_CASE(uninit_array);
|
|
TEST_CASE(uninit_function_par);
|
|
TEST_CASE(uninit_malloc);
|
|
TEST_CASE(ctu);
|
|
#endif
|
|
}
|
|
|
|
void check(const char code[]) {
|
|
Tokenizer tokenizer(&settings, this);
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
errout.str("");
|
|
ExprEngine::runChecks(this, &tokenizer, &settings);
|
|
}
|
|
|
|
void uninit() {
|
|
check("void foo() { int x; x = x + 1; }");
|
|
ASSERT_EQUALS("[test.cpp:1]: (error) Cannot determine that 'x' is initialized\n", errout.str());
|
|
|
|
check("void foo() { int x; int y = x + 1; }");
|
|
ASSERT_EQUALS("[test.cpp:1]: (error) Cannot determine that 'x' is initialized\n", errout.str());
|
|
|
|
check("void foo() { int x; x++; }");
|
|
ASSERT_EQUALS("[test.cpp:1]: (error) Cannot determine that 'x' is initialized\n", errout.str());
|
|
}
|
|
|
|
void uninit_array() {
|
|
check("void foo(int x) {\n"
|
|
" int a[10];\n"
|
|
" if (x > 0) a[0] = 32;\n"
|
|
" return a[0];\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Cannot determine that 'a[0]' is initialized\n", errout.str());
|
|
}
|
|
|
|
void uninit_function_par() {
|
|
// non constant parameters may point at uninitialized data
|
|
// constant parameters should point at initialized data
|
|
|
|
check("char foo(char id[]) { return id[0]; }");
|
|
ASSERT_EQUALS("[test.cpp:1]: (error) Cannot determine that 'id[0]' is initialized\n", errout.str());
|
|
|
|
check("char foo(const char id[]) { return id[0]; }");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("char foo(const char id[]);\n"
|
|
"void bar() { char data[10]; foo(data); }");
|
|
ASSERT_EQUALS("[test.cpp:2]: (error) Cannot determine that 'data[0]' is initialized\n", errout.str());
|
|
|
|
check("char foo(char id[]);\n"
|
|
"void bar() { char data[10]; foo(data); }");
|
|
ASSERT_EQUALS("[test.cpp:2]: (error, inconclusive) Cannot determine that 'data[0]' is initialized. It is inconclusive if there would be a problem in the function call.\n", errout.str());
|
|
|
|
check("void foo(int *p) { if (p) *p=0; }");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void uninit_malloc() {
|
|
check("void foo() { char *p = malloc(10); return *p; }");
|
|
ASSERT_EQUALS("[test.cpp:1]: (error) Cannot determine that '*p' is initialized\n", errout.str());
|
|
}
|
|
|
|
void ctu() {
|
|
check("void init(int &x) {\n"
|
|
" x = 1;\n"
|
|
"}\n"
|
|
"\n"
|
|
"void foo() {\n"
|
|
" int x;\n"
|
|
" init(x);\n"
|
|
" x++;\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void init(int a, int &x) {\n"
|
|
" if (a < 10)\n"
|
|
" x = 1;\n"
|
|
"}\n"
|
|
"\n"
|
|
"void foo(int a) {\n"
|
|
" int x;\n"
|
|
" init(a, x);\n"
|
|
" x++;\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:9]: (error) Cannot determine that 'x' is initialized\n", errout.str());
|
|
|
|
check("void init(int a, int &x) {\n"
|
|
" if (a < 10)\n"
|
|
" x = 1;\n"
|
|
" else\n"
|
|
" x = 3;\n"
|
|
"}\n"
|
|
"\n"
|
|
"void foo(int a) {\n"
|
|
" int x;\n"
|
|
" init(a, x);\n"
|
|
" x++;\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
};
|
|
|
|
REGISTER_TEST(TestBughuntingChecks)
|