3008 lines
84 KiB
C++
3008 lines
84 KiB
C++
/*
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|
* Copyright (C) 2007-2009 Daniel Marjamäki and Cppcheck team.
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
|
|
|
|
#define private public
|
|
#include "../src/tokenize.h"
|
|
#include "../src/checkmemoryleak.h"
|
|
#undef private
|
|
#include "testsuite.h"
|
|
|
|
#include <sstream>
|
|
|
|
extern std::ostringstream errout;
|
|
|
|
|
|
class TestMemleak : private TestFixture
|
|
{
|
|
public:
|
|
TestMemleak() : TestFixture("TestMemleak")
|
|
{ }
|
|
|
|
private:
|
|
void run()
|
|
{
|
|
TEST_CASE(testFunctionReturnType);
|
|
}
|
|
|
|
CheckMemoryLeak::AllocType functionReturnType(const char code[])
|
|
{
|
|
// Tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.setVarId();
|
|
|
|
return ((const CheckMemoryLeak *)0)->functionReturnType(tokenizer.tokens());
|
|
}
|
|
|
|
void testFunctionReturnType()
|
|
{
|
|
{
|
|
const char code[] = "const char *foo()\n"
|
|
"{ return 0; }";
|
|
ASSERT_EQUALS(CheckMemoryLeak::No, functionReturnType(code));
|
|
}
|
|
|
|
{
|
|
const char code[] = "Fred *newFred()\n"
|
|
"{ return new Fred; }";
|
|
ASSERT_EQUALS(CheckMemoryLeak::New, functionReturnType(code));
|
|
}
|
|
|
|
{
|
|
const char code[] = "char *foo()\n"
|
|
"{ return new char[100]; }";
|
|
ASSERT_EQUALS(CheckMemoryLeak::NewArray, functionReturnType(code));
|
|
}
|
|
|
|
{
|
|
const char code[] = "char *foo()\n"
|
|
"{\n"
|
|
" char *p = new char[100];\n"
|
|
" return p;\n"
|
|
"}";
|
|
ASSERT_EQUALS(CheckMemoryLeak::NewArray, functionReturnType(code));
|
|
}
|
|
}
|
|
};
|
|
|
|
static TestMemleak testMemleak;
|
|
|
|
|
|
|
|
|
|
|
|
class TestMemleakInFunction : public TestFixture
|
|
{
|
|
public:
|
|
TestMemleakInFunction() : TestFixture("TestMemleakInFunction")
|
|
{ }
|
|
|
|
private:
|
|
void check(const char code[], bool showAll = false)
|
|
{
|
|
// Tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.setVarId();
|
|
tokenizer.simplifyTokenList();
|
|
|
|
// Clear the error buffer..
|
|
errout.str("");
|
|
|
|
// Check for memory leaks..
|
|
Settings settings;
|
|
settings._debug = true;
|
|
settings._showAll = showAll;
|
|
tokenizer.fillFunctionList();
|
|
CheckMemoryLeakInFunction checkMemoryLeak(&tokenizer, &settings, this);
|
|
checkMemoryLeak.check();
|
|
}
|
|
|
|
|
|
void run()
|
|
{
|
|
// Check that getcode works correctly..
|
|
TEST_CASE(testgetcode);
|
|
|
|
// Todo: check that call_func works correctly..
|
|
|
|
// Check that simplifycode works correctly..
|
|
TEST_CASE(simplifycode);
|
|
|
|
// Check that errors are found..
|
|
TEST_CASE(findleak);
|
|
|
|
TEST_CASE(simple5);
|
|
TEST_CASE(simple7);
|
|
TEST_CASE(simple9); // Bug 2435468 - member function "free"
|
|
TEST_CASE(simple11);
|
|
TEST_CASE(new_nothrow);
|
|
|
|
TEST_CASE(staticvar);
|
|
TEST_CASE(externvar);
|
|
|
|
TEST_CASE(alloc_alloc_1);
|
|
|
|
TEST_CASE(ifelse6);
|
|
TEST_CASE(ifelse7);
|
|
TEST_CASE(ifelse8);
|
|
TEST_CASE(ifelse9);
|
|
TEST_CASE(ifelse10);
|
|
|
|
TEST_CASE(if1);
|
|
TEST_CASE(if4);
|
|
TEST_CASE(if7); // Bug 2401436
|
|
TEST_CASE(if8); // Bug 2458532
|
|
TEST_CASE(if9); // if (realloc)
|
|
TEST_CASE(if10); // else if (realloc)
|
|
TEST_CASE(if11);
|
|
|
|
TEST_CASE(forwhile5);
|
|
TEST_CASE(forwhile6);
|
|
TEST_CASE(forwhile8); // Bug 2429936
|
|
TEST_CASE(forwhile9);
|
|
TEST_CASE(forwhile10);
|
|
TEST_CASE(forwhile11);
|
|
|
|
TEST_CASE(switch2);
|
|
TEST_CASE(switch3);
|
|
|
|
TEST_CASE(ret5); // Bug 2458436 - return use
|
|
TEST_CASE(ret6);
|
|
TEST_CASE(ret7);
|
|
TEST_CASE(ret8);
|
|
|
|
TEST_CASE(mismatch1);
|
|
TEST_CASE(mismatch2);
|
|
TEST_CASE(mismatch3);
|
|
TEST_CASE(mismatch4);
|
|
|
|
TEST_CASE(func3);
|
|
TEST_CASE(func4);
|
|
TEST_CASE(func5);
|
|
TEST_CASE(func6);
|
|
TEST_CASE(func7);
|
|
TEST_CASE(func9); // Embedding the function call in a if-condition
|
|
TEST_CASE(func10); // Bug 2458510 - Function pointer
|
|
TEST_CASE(func11); // Bug 2458510 - Function pointer
|
|
TEST_CASE(func12);
|
|
TEST_CASE(func13);
|
|
TEST_CASE(func14);
|
|
TEST_CASE(func15);
|
|
TEST_CASE(func16);
|
|
|
|
TEST_CASE(allocfunc1);
|
|
TEST_CASE(allocfunc2);
|
|
|
|
TEST_CASE(throw1);
|
|
TEST_CASE(throw2);
|
|
|
|
TEST_CASE(linux_list_1);
|
|
|
|
TEST_CASE(sizeof1);
|
|
|
|
TEST_CASE(realloc1);
|
|
TEST_CASE(realloc2);
|
|
TEST_CASE(realloc3);
|
|
TEST_CASE(realloc4);
|
|
TEST_CASE(realloc5);
|
|
TEST_CASE(realloc6);
|
|
|
|
TEST_CASE(assign);
|
|
|
|
TEST_CASE(varid);
|
|
|
|
TEST_CASE(cast1);
|
|
|
|
// Using deallocated memory:
|
|
// * It is ok to take the address to deallocated memory
|
|
// * It is not ok to dereference a pointer to deallocated memory
|
|
TEST_CASE(dealloc_use);
|
|
|
|
// free a free'd pointer
|
|
TEST_CASE(freefree1);
|
|
TEST_CASE(freefree2);
|
|
TEST_CASE(strcpy_result_assignment);
|
|
TEST_CASE(strcat_result_assignment);
|
|
|
|
TEST_CASE(all1); // Extra checking when --all is given
|
|
|
|
TEST_CASE(malloc_constant_1); // Check that the malloc constant matches the type
|
|
|
|
// Calls to unknown functions.. they may throw exception, quit the program, etc
|
|
TEST_CASE(unknownFunction1);
|
|
TEST_CASE(unknownFunction2);
|
|
TEST_CASE(unknownFunction3);
|
|
TEST_CASE(unknownFunction4);
|
|
TEST_CASE(unknownFunction5);
|
|
|
|
// VCL..
|
|
TEST_CASE(vcl1);
|
|
TEST_CASE(vcl2);
|
|
|
|
TEST_CASE(autoptr1);
|
|
TEST_CASE(if_with_and);
|
|
TEST_CASE(assign_pclose);
|
|
|
|
// Using the function "exit"
|
|
TEST_CASE(exit2);
|
|
TEST_CASE(exit4);
|
|
TEST_CASE(exit5);
|
|
TEST_CASE(stdstring);
|
|
|
|
TEST_CASE(strndup_function);
|
|
TEST_CASE(tmpfile_function);
|
|
TEST_CASE(fcloseall_function);
|
|
TEST_CASE(file_functions);
|
|
TEST_CASE(getc_function);
|
|
|
|
TEST_CASE(open_function);
|
|
TEST_CASE(creat_function);
|
|
TEST_CASE(close_function);
|
|
TEST_CASE(fd_functions);
|
|
|
|
TEST_CASE(opendir_function);
|
|
TEST_CASE(fdopendir_function);
|
|
TEST_CASE(closedir_function);
|
|
TEST_CASE(dir_functions);
|
|
|
|
TEST_CASE(pointer_to_pointer);
|
|
TEST_CASE(dealloc_and_alloc_in_func);
|
|
|
|
// Unknown syntax
|
|
TEST_CASE(unknownSyntax1);
|
|
TEST_CASE(knownFunctions);
|
|
}
|
|
|
|
|
|
|
|
std::string getcode(const char code[], const char varname[]) const
|
|
{
|
|
// Tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.simplifyTokenList();
|
|
|
|
const unsigned int varid(Token::findmatch(tokenizer.tokens(), varname)->varId());
|
|
|
|
// getcode..
|
|
CheckMemoryLeakInFunction checkMemoryLeak(&tokenizer, 0, 0);
|
|
std::list<const Token *> callstack;
|
|
callstack.push_back(0);
|
|
CheckMemoryLeak::AllocType allocType, deallocType;
|
|
allocType = deallocType = CheckMemoryLeak::No;
|
|
bool all = false;
|
|
Token *tokens = checkMemoryLeak.getcode(tokenizer.tokens(), callstack, varid, allocType, deallocType, false, all, 1);
|
|
|
|
// stringify..
|
|
std::ostringstream ret;
|
|
for (const Token *tok = tokens; tok; tok = tok->next())
|
|
ret << tok->str();
|
|
|
|
Tokenizer::deleteTokens(tokens);
|
|
|
|
return ret.str();
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
void testgetcode()
|
|
{
|
|
// alloc;
|
|
ASSERT_EQUALS(";;alloc;", getcode("int *a = malloc(100);", "a"));
|
|
ASSERT_EQUALS(";;alloc;", getcode("int *a = new int;", "a"));
|
|
ASSERT_EQUALS(";;alloc;", getcode("int *a = new int[10];", "a"));
|
|
ASSERT_EQUALS(";;alloc;", getcode("int * const a = new int[10];", "a"));
|
|
ASSERT_EQUALS(";;alloc;", getcode("const int * const a = new int[10];", "a"));
|
|
|
|
// alloc; return use;
|
|
ASSERT_EQUALS(";;alloc;returnuse;", getcode("int *a = new int[10]; return a;", "a"));
|
|
ASSERT_EQUALS(";;alloc;returnuse;", getcode("char *a = new char[100]; return (char *)a;", "a"));
|
|
|
|
// alloc; return;
|
|
ASSERT_EQUALS(";;alloc;return;", getcode("char *s = new char[100]; return 0;", "s"));
|
|
|
|
// lock/unlock..
|
|
ASSERT_EQUALS(";;alloc;", getcode("int a; __cppcheck_lock();", ""));
|
|
ASSERT_EQUALS(";;callfunc;", getcode("int a; __cppcheck_lock();", "a"));
|
|
ASSERT_EQUALS(";;dealloc;", getcode("int a; __cppcheck_unlock();", ""));
|
|
ASSERT_EQUALS(";;callfunc;", getcode("int a; __cppcheck_unlock();", "a"));
|
|
|
|
// dealloc;
|
|
ASSERT_EQUALS(";;dealloc;", getcode("char *s; free(s);", "s"));
|
|
ASSERT_EQUALS(";;dealloc;", getcode("char *s; free((void *)s);", "s"));
|
|
TODO_ASSERT_EQUALS(";;dealloc;", getcode("char *s; free((void *)(s));", "s"));
|
|
ASSERT_EQUALS(";;dealloc;", getcode("char *s; free(reinterpret_cast<void *>(s));", "s"));
|
|
ASSERT_EQUALS(";;dealloc;", getcode("char *s; delete s;", "s"));
|
|
ASSERT_EQUALS(";;dealloc;", getcode("char *s; delete (s);", "s"));
|
|
TODO_ASSERT_EQUALS(";;dealloc;", getcode("char *s; delete (void *)(s);", "s"));
|
|
ASSERT_EQUALS(";;dealloc;", getcode("char *s; delete [] s;", "s"));
|
|
ASSERT_EQUALS(";;dealloc;", getcode("char *s; delete [] (s);", "s"));
|
|
ASSERT_EQUALS(";;dealloc;", getcode("void *p; foo(fclose(p));", "p"));
|
|
|
|
// if..
|
|
ASSERT_EQUALS(";;if{}", getcode("char *s; if (a) { }", "s"));
|
|
ASSERT_EQUALS(";;dealloc;ifv{}", getcode("FILE *f; if (fclose(f)) { }", "f"));
|
|
ASSERT_EQUALS(";;if(!var){}else{}", getcode("char *s; if (!s) { } else { }", "s"));
|
|
ASSERT_EQUALS(";;if{}", getcode("char *s; if (a && s) { }", "s"));
|
|
ASSERT_EQUALS(";;if(!var){}", getcode("char *s; if (a && !s) { }", "s"));
|
|
ASSERT_EQUALS(";;;if{dealloc;};if{dealloc;return;}assign;returnuse;", getcode("char *buf, *tmp; tmp = realloc(buf, 40); if (!(tmp)) { free(buf); return; } buf = tmp; return buf;", "buf"));
|
|
|
|
// switch..
|
|
ASSERT_EQUALS(";;switch{case;;break;};", getcode("char *s; switch(a){case 1: break;};", "s"));
|
|
|
|
// loop..
|
|
ASSERT_EQUALS(";;loop{}", getcode("char *s; while (a) { }", "s"));
|
|
ASSERT_EQUALS(";;loopcallfunc{}", getcode("char *s; while (a()) { }", "s"));
|
|
ASSERT_EQUALS(";;loop{}", getcode("char *s; while (s) { }", "s"));
|
|
ASSERT_EQUALS(";;loop{}", getcode("char *s; for (a;b;c) { }", "s"));
|
|
ASSERT_EQUALS(";;loop{alloc;}", getcode("char *s; for (a;b;c) { s=malloc(10); }", "s"));
|
|
ASSERT_EQUALS(";;do{}loop;", getcode("char *s; do { } while (a);", "s"));
|
|
ASSERT_EQUALS(";;while1{}", getcode("char *s; while(true) { }", "s"));
|
|
ASSERT_EQUALS(";;while1{}", getcode("char *s; for(;;) { }", "s"));
|
|
|
|
// asprintf..
|
|
ASSERT_EQUALS(";;alloc;", getcode("char *s; asprintf(&s, \"xyz\");", "s"));
|
|
ASSERT_EQUALS(";;alloc;", getcode("char *s; asprintf(&s, \"s: %s\", s);", "s"));
|
|
ASSERT_EQUALS(";;;", getcode("char *s; asprintf(&p, \"s: %s\", s);", "s"));
|
|
|
|
// Since we don't check how the return value is used we must bail out
|
|
ASSERT_EQUALS("", getcode("char *s; int ret = asprintf(&s, \"xyz\");", "s"));
|
|
TODO_ASSERT_EQUALS(";;alloc;", getcode("char *s; int ret; ret=asprintf(&s, \"xyz\"); if (ret==-1) return;", "s"));
|
|
|
|
// use..
|
|
ASSERT_EQUALS(";;use;", getcode("char *s; a(s);", "s"));
|
|
ASSERT_EQUALS(";;use;", getcode("char *s; (*a)(s);", "s"));
|
|
ASSERT_EQUALS(";;use;", getcode("char *s; abc.a(s);", "s"));
|
|
ASSERT_EQUALS(";;use;", getcode("char *s; s2 = s;", "s"));
|
|
ASSERT_EQUALS(";;use;", getcode("char *s; s2 = s + 10;", "s"));
|
|
|
|
// return..
|
|
ASSERT_EQUALS(";;return;", getcode("char *s; return;", "s"));
|
|
ASSERT_EQUALS(";;returnuse;", getcode("char *s; return s;", "s"));
|
|
|
|
// assign..
|
|
ASSERT_EQUALS(";;assign;", getcode("char *s; s = 0;", "s"));
|
|
ASSERT_EQUALS(";;;", getcode("char *s; s = strcpy(s, p);", "s"));
|
|
|
|
// callfunc..
|
|
ASSERT_EQUALS(";;assigncallfunc;", getcode("char *s; s = a();", "s"));
|
|
ASSERT_EQUALS(";;callfunc;", getcode("char *s; a();", "s"));
|
|
ASSERT_EQUALS(";;callfunc;", getcode("char *s; abc.a();", "s"));
|
|
|
|
// exit..
|
|
ASSERT_EQUALS(";;exit;", getcode("char *s; exit(0);", "s"));
|
|
ASSERT_EQUALS(";;exit;", getcode("char *s; _exit(0);", "s"));
|
|
ASSERT_EQUALS(";;exit;", getcode("char *s; abort();", "s"));
|
|
ASSERT_EQUALS(";;exit;", getcode("char *s; err(0);", "s"));
|
|
ASSERT_EQUALS(";;if{exit;}", getcode("char *s; if (a) { exit(0); }", "s"));
|
|
|
|
// open/close
|
|
ASSERT_EQUALS(";;alloc;if(var){dealloc;}", getcode("int f; f=open(); if(f>=0)close(f);", "f"));
|
|
ASSERT_EQUALS(";;alloc;ifv{;}", getcode("int f; f=open(); if(f!=-1 || x);", "f"));
|
|
}
|
|
|
|
|
|
|
|
std::string simplifycode(const char code[], bool &all) const
|
|
{
|
|
// Tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// replace "if ( ! var )" => "if(!var)"
|
|
for (Token *tok = tokenizer._tokens; tok; tok = tok->next())
|
|
{
|
|
if (Token::simpleMatch(tok, "if ( var )"))
|
|
{
|
|
Token::eraseTokens(tok, tok->tokAt(4));
|
|
tok->str("if(var)");
|
|
}
|
|
|
|
else if (Token::simpleMatch(tok, "if ( ! var )"))
|
|
{
|
|
Token::eraseTokens(tok, tok->tokAt(5));
|
|
tok->str("if(!var)");
|
|
}
|
|
}
|
|
|
|
Settings settings;
|
|
settings._showAll = all;
|
|
CheckMemoryLeakInFunction checkMemoryLeak(&tokenizer, &settings, NULL);
|
|
all = false;
|
|
checkMemoryLeak.simplifycode(tokenizer._tokens, all);
|
|
|
|
std::ostringstream ret;
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
ret << (tok->previous() ? " " : "") << tok->str();
|
|
|
|
return ret.str();
|
|
}
|
|
|
|
std::string simplifycode(const char code[])
|
|
{
|
|
bool all = false;
|
|
const std::string str1 = simplifycode(code, all);
|
|
ASSERT_EQUALS(0, all ? 1 : 0);
|
|
|
|
all = true;
|
|
const std::string str2 = simplifycode(code, all);
|
|
ASSERT_EQUALS(all ? 1 : 0, (str1 != str2) ? 1 : 0);
|
|
|
|
return all ? (str1 + "\n" + str2) : str1;
|
|
}
|
|
|
|
|
|
|
|
// Test that the CheckMemoryLeaksInFunction::simplifycode works
|
|
void simplifycode()
|
|
{
|
|
ASSERT_EQUALS(";", simplifycode("; ; ; ;"));
|
|
ASSERT_EQUALS(";", simplifycode("; if ;"));
|
|
ASSERT_EQUALS("alloc ;", simplifycode("alloc ; if ; if(var) ; ifv ; if(!var) ;"));
|
|
ASSERT_EQUALS("alloc ;", simplifycode("alloc ; if ; else ;"));
|
|
|
|
// if, else..
|
|
ASSERT_EQUALS("; alloc ; if break ; dealloc ;", simplifycode("; alloc ; if { break; } dealloc ;"));
|
|
ASSERT_EQUALS("; alloc ; if continue ; dealloc ;", simplifycode("; alloc ; if { continue; } dealloc ;"));
|
|
ASSERT_EQUALS("; alloc ;", simplifycode("; alloc; if { return use; }"));
|
|
ASSERT_EQUALS("; alloc ; dealloc ;", simplifycode("; alloc; if(!var) { return; } dealloc;"));
|
|
ASSERT_EQUALS("; alloc ;", simplifycode("; if { alloc; } else { return; }"));
|
|
ASSERT_EQUALS("; alloc ; dealloc ;", simplifycode("; alloc ; if(!var) { alloc ; } dealloc ;"));
|
|
ASSERT_EQUALS("; use ;", simplifycode("; if(var) use ;"));
|
|
ASSERT_EQUALS("; break ;", simplifycode("; if break ; else break ;"));
|
|
|
|
ASSERT_EQUALS("; alloc ; dealloc ;\n; alloc ;", simplifycode("; alloc ; if(!var) { return ; } if { dealloc ; }"));
|
|
ASSERT_EQUALS("; if alloc ; else assign ; return use ;", simplifycode("; callfunc ; if callfunc { alloc ; } else { assign ; } return use ;"));
|
|
|
|
// "if ; .."
|
|
ASSERT_EQUALS("; if xxx ;", simplifycode("; if ; else xxx ;"));
|
|
ASSERT_EQUALS("; if(var) xxx ;", simplifycode("; if(!var) ; else xxx ;"));
|
|
ASSERT_EQUALS("; if(!var) xxx ;", simplifycode("; if(var) ; else xxx ;"));
|
|
ASSERT_EQUALS("; ifv xxx ;", simplifycode("; ifv ; else xxx ;"));
|
|
ASSERT_EQUALS("; alloc ;", simplifycode("; alloc; if { dealloc; return; }"));
|
|
ASSERT_EQUALS("; alloc ;", simplifycode("; alloc; if { return use; }"));
|
|
ASSERT_EQUALS("; alloc ; return ;", simplifycode(";alloc;if{return;}return;"));
|
|
|
|
// switch..
|
|
ASSERT_EQUALS("; alloc ; dealloc ;", simplifycode(";alloc;switch{case;break;};dealloc;"));
|
|
|
|
// loops..
|
|
ASSERT_EQUALS(";", simplifycode("; loop { break; }"));
|
|
ASSERT_EQUALS(";", simplifycode("; loop { if { break; } }"));
|
|
ASSERT_EQUALS("; loop alloc ;", simplifycode("; loop { alloc ; }"));
|
|
ASSERT_EQUALS("; alloc ; alloc ;", simplifycode("; alloc ; do { alloc ; } loop ;"));
|
|
ASSERT_EQUALS("; exit ;", simplifycode("; alloc ; do { } loop ; exit ;"));
|
|
|
|
ASSERT_EQUALS("; alloc ; use ;", simplifycode("; alloc ; while1 { if { dealloc ; return ; } }"));
|
|
|
|
// callfunc..
|
|
ASSERT_EQUALS("; callfunc ;\n;", simplifycode(";callfunc;"));
|
|
|
|
// exit..
|
|
ASSERT_EQUALS("; exit ;", simplifycode("; alloc; exit;"));
|
|
ASSERT_EQUALS("; exit ;", simplifycode("; alloc; if { loop ; } dealloc; exit;"));
|
|
ASSERT_EQUALS(";", simplifycode("; if { alloc; exit; }"));
|
|
ASSERT_EQUALS("; alloc ;", simplifycode("; alloc ; if { use; exit; }"));
|
|
ASSERT_EQUALS("; alloc ;", simplifycode("; alloc ; if(!var) { exit; }"));
|
|
TODO_ASSERT_EQUALS(";", simplifycode("; alloc ; if(var) { exit; }"));
|
|
TODO_ASSERT_EQUALS(";\n; alloc ;", simplifycode("; alloc ; ifv { exit; }"));
|
|
}
|
|
|
|
|
|
|
|
// is there a leak in given code? if so, return the linenr
|
|
int dofindleak(const char code[], bool all = false) const
|
|
{
|
|
// Tokenize..
|
|
Settings settings;
|
|
settings._debug = true;
|
|
Tokenizer tokenizer(&settings, NULL);
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// replace "if ( ! var )" => "if(!var)"
|
|
for (Token *tok = tokenizer._tokens; tok; tok = tok->next())
|
|
{
|
|
if (Token::simpleMatch(tok, "if ( var )"))
|
|
{
|
|
Token::eraseTokens(tok, tok->tokAt(4));
|
|
tok->str("if(var)");
|
|
}
|
|
|
|
else if (Token::simpleMatch(tok, "if ( ! var )"))
|
|
{
|
|
Token::eraseTokens(tok, tok->tokAt(5));
|
|
tok->str("if(!var)");
|
|
}
|
|
}
|
|
|
|
const Token *tok = CheckMemoryLeakInFunction::findleak(tokenizer.tokens(), all);
|
|
return (tok ? tok->linenr() : -1);
|
|
}
|
|
|
|
void findleak()
|
|
{
|
|
ASSERT_EQUALS(1, dofindleak("alloc;"));
|
|
ASSERT_EQUALS(1, dofindleak("; use; { alloc; }"));
|
|
ASSERT_EQUALS(2, dofindleak("alloc;\n return;"));
|
|
ASSERT_EQUALS(-1, dofindleak("alloc; return use;"));
|
|
ASSERT_EQUALS(2, dofindleak("alloc;\n callfunc;"));
|
|
ASSERT_EQUALS(-1, dofindleak("alloc; use;"));
|
|
ASSERT_EQUALS(-1, dofindleak("assign; alloc; dealloc;"));
|
|
ASSERT_EQUALS(-1, dofindleak("assign; if alloc; dealloc;"));
|
|
|
|
// if alloc..
|
|
ASSERT_EQUALS(2, dofindleak("if alloc;\n return;"));
|
|
ASSERT_EQUALS(-1, dofindleak("if alloc;\n return use;"));
|
|
ASSERT_EQUALS(-1, dofindleak("if alloc;\n use;"));
|
|
|
|
// if..
|
|
ASSERT_EQUALS(-1, dofindleak("alloc; ifv { dealloc; }"));
|
|
ASSERT_EQUALS(2, dofindleak("alloc;\n if return;\n dealloc;"));
|
|
ASSERT_EQUALS(3, dofindleak("alloc;\n if\n return;\n dealloc;"));
|
|
ASSERT_EQUALS(-1, dofindleak("alloc; if { dealloc ; return; } dealloc;"));
|
|
ASSERT_EQUALS(-1, dofindleak("alloc; if { dealloc ; return; } dealloc;"));
|
|
ASSERT_EQUALS(-1, dofindleak("alloc; if { dealloc ; alloc; } dealloc;"));
|
|
ASSERT_EQUALS(-1, dofindleak("alloc;\n if(!var)\n { callfunc;\n return;\n }\n use;"));
|
|
|
|
ASSERT_EQUALS(-1, dofindleak("alloc; if { return use; } dealloc;"));
|
|
ASSERT_EQUALS(-1, dofindleak("alloc; if { dealloc; return; } dealloc;"));
|
|
|
|
// assign..
|
|
ASSERT_EQUALS(2, dofindleak("alloc;\n assign;\n dealloc;"));
|
|
ASSERT_EQUALS(-1, dofindleak("alloc;\n if(!var) assign;\n dealloc;"));
|
|
ASSERT_EQUALS(2, dofindleak("alloc;\n if assign;\n dealloc;"));
|
|
|
|
// loop..
|
|
ASSERT_EQUALS(1, dofindleak("; loop { alloc ; if break; dealloc ; }"));
|
|
ASSERT_EQUALS(1, dofindleak("; loop { alloc ; if continue; dealloc ; }"));
|
|
ASSERT_EQUALS(1, dofindleak("; loop alloc ;"));
|
|
ASSERT_EQUALS(1, dofindleak("; loop alloc ; dealloc ;"));
|
|
|
|
// Todo..
|
|
ASSERT_EQUALS(-1, dofindleak("; alloc;\n if { dealloc; }\n ;"));
|
|
TODO_ASSERT_EQUALS(3, dofindleak("; alloc;\n if { dealloc; }\n ;"));
|
|
}
|
|
|
|
|
|
void simple5()
|
|
{
|
|
check("static char *f()\n"
|
|
"{\n"
|
|
" struct *str = new strlist;\n"
|
|
" return &str->s;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void simple7()
|
|
{
|
|
// A garbage collector may delete f automaticly
|
|
check("class Fred;\n"
|
|
"void foo()\n"
|
|
"{\n"
|
|
" Fred *f = new Fred;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void simple9()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" MyClass *c = new MyClass();\n"
|
|
" c->free(c);\n"
|
|
" delete c;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void simple11()
|
|
{
|
|
check("void Fred::aaa()\n"
|
|
"{ }\n"
|
|
"\n"
|
|
"void Fred::foo()\n"
|
|
"{\n"
|
|
" char *s = NULL;\n"
|
|
" if (a)\n"
|
|
" s = malloc(10);\n"
|
|
" else if (b)\n"
|
|
" s = malloc(10);\n"
|
|
" else\n"
|
|
" f();\n"
|
|
" g(s);\n"
|
|
" if (c)\n"
|
|
" h(s);\n"
|
|
" free(s);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
|
|
void new_nothrow()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" int *p = new(std::nothrow) int;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Memory leak: p\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" using std::nothrow;\n"
|
|
" int *p = new(nothrow) int;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: p\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" int *p = new(std::nothrow) int[10];\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Memory leak: p\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" using namespace std;\n"
|
|
" int *p = new(nothrow) int[10];\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: p\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" int *p = new(std::nothrow) int;\n"
|
|
" delete [] p;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Mismatching allocation and deallocation: p\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" int *p = new(std::nothrow) int[10];\n"
|
|
" delete p;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Mismatching allocation and deallocation: p\n", errout.str());
|
|
}
|
|
|
|
|
|
void staticvar()
|
|
{
|
|
check("int f()\n"
|
|
"{\n"
|
|
" static char *s = 0;\n"
|
|
" free(s);\n"
|
|
" s = malloc(100);\n"
|
|
" return 123;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void externvar()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" extern char *s;\n"
|
|
" s = malloc(100);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
|
|
void alloc_alloc_1()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *str;\n"
|
|
" str = new char[10];\n"
|
|
" str = new char[20];\n"
|
|
" delete [] str;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: str\n", errout.str());
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
void ifelse6()
|
|
{
|
|
check("static char *f()\n"
|
|
"{\n"
|
|
" char *s = new char[100];\n"
|
|
" if ( a == b )\n"
|
|
" {\n"
|
|
" return s;\n"
|
|
" }\n"
|
|
" return NULL;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (error) Memory leak: s\n", errout.str());
|
|
}
|
|
|
|
|
|
void ifelse7()
|
|
{
|
|
check("static char *f()\n"
|
|
"{\n"
|
|
" char *s;\n"
|
|
" if ( abc )\n"
|
|
" {\n"
|
|
" s = new char[10];\n"
|
|
" }\n"
|
|
" return s;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void ifelse8()
|
|
{
|
|
check("static char *f()\n"
|
|
"{\n"
|
|
" char *s = new char[10];\n"
|
|
" if ( s )\n"
|
|
" {\n"
|
|
" return s;\n"
|
|
" }\n"
|
|
" return 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void ifelse9()
|
|
{
|
|
check("static char *f()\n"
|
|
"{\n"
|
|
" char *s = new char[10];\n"
|
|
" if ( ghfgf )\n"
|
|
" {\n"
|
|
" delete [] s;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void ifelse10()
|
|
{
|
|
check("static char *f()\n"
|
|
"{\n"
|
|
" char *s = new char[10];\n"
|
|
" if ( ghfgf )\n"
|
|
" {\n"
|
|
" str[0] = s;\n"
|
|
" }\n"
|
|
" else\n"
|
|
" {\n"
|
|
" str[0] = s;\n"
|
|
" }\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
|
|
|
|
void if1()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" struct abc *p = new abc;\n"
|
|
" p->a = new char[100];\n"
|
|
" if ( ! p->a )\n"
|
|
" return;\n"
|
|
" foo(p);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Memory leak: p\n", errout.str());
|
|
}
|
|
|
|
|
|
void if4()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *s;\n"
|
|
" bool b = true;\n"
|
|
" if (b && (s = malloc(256)))\n"
|
|
" ;\n"
|
|
" if (b)\n"
|
|
" free(s);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void if7()
|
|
{
|
|
check("void f( bool b )\n"
|
|
"{\n"
|
|
" int *a=0;\n"
|
|
" if( b )\n"
|
|
" {\n"
|
|
" a = new int[10];\n"
|
|
" }\n"
|
|
"\n"
|
|
" if( b )\n"
|
|
" delete [] a;\n"
|
|
" else {}\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void if8()
|
|
{
|
|
check("static void f(int i)\n"
|
|
"{\n"
|
|
" char *c = malloc(50);\n"
|
|
" if (i == 1)\n"
|
|
" {\n"
|
|
" free(c);\n"
|
|
" return;\n"
|
|
" }\n"
|
|
" if (i == 2)\n"
|
|
" {\n"
|
|
" return;\n"
|
|
" }\n"
|
|
" free(c);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:11]: (error) Memory leak: c\n", errout.str());
|
|
}
|
|
|
|
void if9()
|
|
{
|
|
check("static void f()\n"
|
|
"{\n"
|
|
" char *buf = NULL, *tmp;\n"
|
|
" if (!(tmp = realloc(buf, 50)))\n"
|
|
" {\n"
|
|
" free(buf);\n"
|
|
" return NULL;\n"
|
|
" }\n"
|
|
" buf = tmp;\n"
|
|
" return buf;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void if10()
|
|
{
|
|
check("static void f()\n"
|
|
"{\n"
|
|
" char *buf = malloc(10);\n"
|
|
" if (aa)\n"
|
|
" ;\n"
|
|
" else if (buf = realloc(buf, 100))\n"
|
|
" ;\n"
|
|
" free(buf);\n"
|
|
"}\n");
|
|
TODO_ASSERT_EQUALS("[test.cpp:6]: (error) Memory leak: buf\n", errout.str());
|
|
}
|
|
|
|
void if11()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" int *x = new int[10];\n"
|
|
" if (x == 0 || aa)\n"
|
|
" {\n"
|
|
" return 1;\n"
|
|
" }\n"
|
|
" delete [] x;\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Memory leak: x\n", errout.str());
|
|
}
|
|
|
|
|
|
|
|
|
|
void forwhile5()
|
|
{
|
|
check("void f(const char **a)\n"
|
|
"{\n"
|
|
" char *str = 0;\n"
|
|
" for (int i = 0; i < 10 && !str; ++i)\n"
|
|
" {\n"
|
|
" str = strdup(a[i]);\n"
|
|
" }\n"
|
|
" return str;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void forwhile6()
|
|
{
|
|
check("void f(const char **a)\n"
|
|
"{\n"
|
|
" char *str = 0;\n"
|
|
" for (int i = 0; i < 10 && !str; ++i)\n"
|
|
" {\n"
|
|
" str = strdup(a[i]);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (error) Memory leak: str\n", errout.str());
|
|
}
|
|
|
|
|
|
void forwhile8()
|
|
{
|
|
check("char *f()\n"
|
|
"{\n"
|
|
" char *a = 0;\n"
|
|
" int i = 0;\n"
|
|
" for( ;; )\n"
|
|
" {\n"
|
|
" ++i;\n"
|
|
" a = realloc( a, i );\n"
|
|
" if( !a )\n"
|
|
" return 0;\n"
|
|
"\n"
|
|
" if( i > 10 )\n"
|
|
" break;\n"
|
|
" }\n"
|
|
"\n"
|
|
" return a;\n"
|
|
"}\n");
|
|
TODO_ASSERT_EQUALS("[test.cpp:10]: (error) Memory leak: a\n", errout.str());
|
|
}
|
|
|
|
|
|
void forwhile9()
|
|
{
|
|
check("char *f()\n"
|
|
"{\n"
|
|
" char *a = 0;\n"
|
|
" int i = 0;\n"
|
|
" for(i = 0 ;i < 50 ; i++)\n"
|
|
" {\n"
|
|
" if(func1(i))\n"
|
|
" continue;\n"
|
|
" a = realloc( a, i );\n"
|
|
" if(func2(i))\n"
|
|
" continue;\n"
|
|
" }\n"
|
|
"\n"
|
|
" return a;\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void forwhile10()
|
|
{
|
|
check("char *f()\n"
|
|
"{\n"
|
|
" char *a = 0;\n"
|
|
" int i = 0;\n"
|
|
" for(i = 0; i < 50; i++)\n"
|
|
" {\n"
|
|
" if(func1(i))\n"
|
|
" continue;\n"
|
|
" a = realloc( a, i );\n"
|
|
" if(func2(i))\n"
|
|
" return;\n"
|
|
" }\n"
|
|
"\n"
|
|
" return a;\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("[test.cpp:11]: (error) Memory leak: a\n", errout.str());
|
|
}
|
|
|
|
|
|
void forwhile11()
|
|
{
|
|
check("int main()\n"
|
|
"{\n"
|
|
" FILE *stream=NULL;\n"
|
|
" while((stream = fopen(name,\"r\")) == NULL)\n"
|
|
" { }\n"
|
|
" if(stream!=NULL) fclose(stream);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
|
|
|
|
void switch2()
|
|
{
|
|
const std::string code("void f()\n"
|
|
"{\n"
|
|
" char *str = new char[10];\n"
|
|
" switch (abc)\n"
|
|
" {\n"
|
|
" case 1:\n"
|
|
" delete [] str;\n"
|
|
" break;\n"
|
|
" default:\n"
|
|
" break;\n"
|
|
" };\n"
|
|
"}\n");
|
|
check(code.c_str(), false);
|
|
ASSERT_EQUALS("", errout.str());
|
|
check(code.c_str(), true);
|
|
ASSERT_EQUALS("[test.cpp:12]: (possible error) Memory leak: str\n", errout.str());
|
|
}
|
|
|
|
void switch3()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *str = new char[10];\n"
|
|
" while (abc)\n"
|
|
" {\n"
|
|
" switch (def)\n"
|
|
" {\n"
|
|
" default:\n"
|
|
" return;\n"
|
|
" }\n"
|
|
" }\n"
|
|
" delete [] str;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:9]: (error) Memory leak: str\n", errout.str());
|
|
}
|
|
|
|
|
|
void ret5()
|
|
{
|
|
check("static char * f()\n"
|
|
"{\n"
|
|
" char *c = new char[50];\n"
|
|
" return (c ? c : NULL);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void ret6()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *c = new char[50];\n"
|
|
" return strcpy(c, \"foo\");\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void ret7()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *c = new char[50];\n"
|
|
" return memcpy(c, \"foo\",4);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void ret8()
|
|
{
|
|
check("char *foo()\n"
|
|
"{\n"
|
|
" char *c = new char[50];\n"
|
|
" return ((char *)(c+1));\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void mismatch1()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" int *a = new int[10];\n"
|
|
" free(a);\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Mismatching allocation and deallocation: a\n", errout.str());
|
|
}
|
|
|
|
void mismatch2()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" FILE *fp;\n"
|
|
"\n"
|
|
" fp = fopen();\n"
|
|
" fclose(fp);\n"
|
|
"\n"
|
|
" fp = popen();\n"
|
|
" pclose(fp);\n"
|
|
"}\n", false);
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void mismatch3()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" FILE *fp;\n"
|
|
"\n"
|
|
" if (abc) fp = fopen();\n"
|
|
" else fp = popen();\n"
|
|
"\n"
|
|
" if (abc) fclose(fp);\n"
|
|
" else pclose(fp);\n"
|
|
"}\n", false);
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void mismatch4()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *p = 0;\n"
|
|
" for (i = 0; i < 10; ++i)\n"
|
|
" {\n"
|
|
" delete p;\n"
|
|
" p = new char[100];\n"
|
|
" }\n"
|
|
" delete [] p;\n"
|
|
"}\n", false);
|
|
ASSERT_EQUALS("[test.cpp:7]: (error) Mismatching allocation and deallocation: p\n", errout.str());
|
|
}
|
|
|
|
|
|
|
|
|
|
////////////////////////////////////////////////
|
|
// function calls
|
|
////////////////////////////////////////////////
|
|
|
|
|
|
|
|
void func3()
|
|
{
|
|
check("static void foo(const char *str)\n"
|
|
"{ }\n"
|
|
"\n"
|
|
"static void f()\n"
|
|
"{\n"
|
|
" char *p = new char[100];\n"
|
|
" foo(p);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (error) Memory leak: p\n", errout.str());
|
|
}
|
|
|
|
|
|
void func4()
|
|
{
|
|
check("static void foo(char *str)\n"
|
|
"{\n"
|
|
" delete [] str;\n"
|
|
"}\n"
|
|
"\n"
|
|
"static void f()\n"
|
|
"{\n"
|
|
" char *p = new char[100];\n"
|
|
" foo(p);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void func5()
|
|
{
|
|
check("static void foo(char *str)\n"
|
|
"{\n"
|
|
" delete str;\n"
|
|
"}\n"
|
|
"\n"
|
|
"static void f()\n"
|
|
"{\n"
|
|
" char *p = new char[100];\n"
|
|
" foo(p);\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("[test.cpp:9] -> [test.cpp:3]: (error) Mismatching allocation and deallocation: str\n",
|
|
errout.str());
|
|
}
|
|
|
|
|
|
void func6()
|
|
{
|
|
check("static void foo(char *str)\n"
|
|
"{\n"
|
|
" goto abc;\n"
|
|
"}\n"
|
|
"\n"
|
|
"static void f()\n"
|
|
"{\n"
|
|
" char *p = new char[100];\n"
|
|
" foo(p);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:10]: (error) Memory leak: p\n", errout.str());
|
|
}
|
|
|
|
|
|
void func7()
|
|
{
|
|
check("static void foo(char *str)\n"
|
|
"{\n"
|
|
" if (abc)\n"
|
|
" return;"
|
|
" delete [] str;\n"
|
|
"}\n"
|
|
"\n"
|
|
"static void f()\n"
|
|
"{\n"
|
|
" char *p = new char[100];\n"
|
|
" foo(p);\n"
|
|
"}\n");
|
|
TODO_ASSERT_EQUALS("[test.cpp:11]: (error) Memory leak: p\n", errout.str());
|
|
}
|
|
|
|
|
|
void func9()
|
|
{
|
|
check("int b()\n"
|
|
"{\n"
|
|
" return 0;\n"
|
|
"}\n"
|
|
"\n"
|
|
"void a()\n"
|
|
"{\n"
|
|
" char *a = new char[10];\n"
|
|
" if (b())\n"
|
|
" return;\n"
|
|
" delete [] a;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void func10()
|
|
{
|
|
check("static void f(void (*fnc)(char*))\n"
|
|
"{\n"
|
|
" char *c = malloc(50);\n"
|
|
" (fnc)(c);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void func11()
|
|
{
|
|
check("static void f(struct1 *s1)\n"
|
|
"{\n"
|
|
" char *c = malloc(50);\n"
|
|
" (s1->fnc)(c);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void func12()
|
|
{
|
|
check("void add_list(struct mmtimer *n)\n"
|
|
"{\n"
|
|
" rb_link_node(&n->list, parent, link);\n"
|
|
"}\n"
|
|
"\n"
|
|
"int foo()\n"
|
|
"{\n"
|
|
" struct mmtimer *base;\n"
|
|
"\n"
|
|
" base = kmalloc(sizeof(struct mmtimer), GFP_KERNEL);\n"
|
|
" if (base == NULL)\n"
|
|
" return -ENOMEM;\n"
|
|
"\n"
|
|
" add_list(base);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void func13()
|
|
{
|
|
check("static void f()\n"
|
|
"{\n"
|
|
" char *p = malloc(100);\n"
|
|
" foo(&p);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void func14()
|
|
{
|
|
// It is not known what the "foo" that only takes one parameter does..
|
|
check("static void foo(char *a, char *b)\n"
|
|
"{\n"
|
|
" free(a);\n"
|
|
" free(b);\n"
|
|
"}\n"
|
|
"static void f()\n"
|
|
"{\n"
|
|
" char *p = malloc(100);\n"
|
|
" foo(p);\n"
|
|
" free(p);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void func15()
|
|
{
|
|
check("static void a()\n"
|
|
"{ return true; }\n"
|
|
"\n"
|
|
"static void b()\n"
|
|
"{\n"
|
|
" char *p = malloc(100);\n"
|
|
" if (a()) return;\n" // <- memory leak
|
|
" free(p);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:7]: (error) Memory leak: p\n", errout.str());
|
|
}
|
|
|
|
void func16()
|
|
{
|
|
check("static void a( bo_t *p_bo)\n"
|
|
"{\n"
|
|
" p_bo->buffer = realloc( p_bo->buffer, 100 );\n"
|
|
"}\n"
|
|
"\n"
|
|
"static bo_t * b()\n"
|
|
"{\n"
|
|
" bo_t *box;\n"
|
|
" if( ( box = malloc( sizeof( bo_t ) ) ) )\n"
|
|
" {\n"
|
|
" a(box);\n"
|
|
" a(box);\n"
|
|
" }\n"
|
|
" return box;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
|
|
void allocfunc1()
|
|
{
|
|
check("static char *a()\n"
|
|
"{\n"
|
|
" return new char[100];\n"
|
|
"}\n"
|
|
"static void b()\n"
|
|
"{\n"
|
|
" char *p = a();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS(std::string("[test.cpp:8]: (error) Memory leak: p\n"), errout.str());
|
|
|
|
check("FILE *a()\n"
|
|
"{\n"
|
|
" return fopen(\"test.txt\",\"w\");\n"
|
|
"}\n"
|
|
"static void b()\n"
|
|
"{\n"
|
|
" FILE *p = a();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS(std::string("[test.cpp:8]: (error) Memory leak: p\n"), errout.str());
|
|
|
|
check("char *a()\n"
|
|
"{\n"
|
|
" return malloc(10);\n"
|
|
"}\n"
|
|
"static void b()\n"
|
|
"{\n"
|
|
" char *p = a();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS(std::string("[test.cpp:8]: (error) Memory leak: p\n"), errout.str());
|
|
}
|
|
|
|
void allocfunc2()
|
|
{
|
|
check("static char *a(int size)\n"
|
|
"{\n"
|
|
" return new char[size];\n"
|
|
"}\n"
|
|
"static void b()\n"
|
|
"{\n"
|
|
" int len = 100;\n"
|
|
" char *p = a(len);\n"
|
|
" delete [] p;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
|
|
check("char *a(char *a)\n"
|
|
"{\n"
|
|
" return realloc(a, 10);\n"
|
|
"}\n"
|
|
"static void b()\n"
|
|
"{\n"
|
|
" char *p = a(0);\n"
|
|
" char *p = a(p);\n"
|
|
" free(p);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
|
|
check("char *a()\n"
|
|
"{\n"
|
|
" return malloc(10);\n"
|
|
"}\n"
|
|
"static void b()\n"
|
|
"{\n"
|
|
" char *p = a();\n"
|
|
" free(p);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
void throw1()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *str = new char[10];\n"
|
|
" if ( ! abc )\n"
|
|
" throw 123;\n"
|
|
" delete [] str;\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: str\n", errout.str());
|
|
}
|
|
|
|
void throw2()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *str = 0;\n"
|
|
" try\n"
|
|
" {\n"
|
|
" str = new char[100];\n"
|
|
" if ( somecondition )\n"
|
|
" throw exception;\n"
|
|
" delete [] str;\n"
|
|
" }\n"
|
|
" catch ( ... )\n"
|
|
" {\n"
|
|
" delete [] str;\n"
|
|
" }\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
|
|
|
|
void linux_list_1()
|
|
{
|
|
check("struct AB\n"
|
|
"{\n"
|
|
" int a;\n"
|
|
" int b;\n"
|
|
"};\n"
|
|
"void foo()\n"
|
|
"{\n"
|
|
" struct AB *ab = new AB;\n"
|
|
" func(&ab->a);\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
|
|
void sizeof1()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" struct s_t s1;\n"
|
|
" struct s_t cont *p = &s1;\n"
|
|
" struct s_t *s2;\n"
|
|
"\n"
|
|
" memset(p, 0, sizeof(*p));\n"
|
|
"\n"
|
|
" s2 = (struct s_t *) malloc(sizeof(*s2));\n"
|
|
"\n"
|
|
" if (s2->value != 0)\n"
|
|
" return;\n"
|
|
"\n"
|
|
" free(s2);\n"
|
|
"\n"
|
|
" return;\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("[test.cpp:12]: (error) Memory leak: s2\n", errout.str());
|
|
}
|
|
|
|
|
|
void realloc1()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *a = (char *)malloc(10);\n"
|
|
" a = realloc(a, 100);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: a\n", errout.str());
|
|
}
|
|
|
|
void realloc2()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *a = (char *)malloc(10);\n"
|
|
" a = (char *)realloc(a, 100);\n"
|
|
" free(a);\n"
|
|
"}\n");
|
|
|
|
TODO_ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: a\n", errout.str());
|
|
}
|
|
|
|
void realloc3()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *a = 0;\n"
|
|
" if ((a = realloc(a, 100)) == NULL)\n"
|
|
" return;\n"
|
|
" free(a);\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void realloc4()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" static char *a = 0;\n"
|
|
" if ((a = realloc(a, 100)) == NULL)\n"
|
|
" return;\n"
|
|
" free(a);\n"
|
|
"}\n");
|
|
|
|
TODO_ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: a\n", errout.str());
|
|
}
|
|
|
|
void realloc5()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *buf;\n"
|
|
" char *new_buf;\n"
|
|
" buf = calloc( 10 );\n"
|
|
" new_buf = realloc ( buf, 20);\n"
|
|
" if ( !new_buf )\n"
|
|
" free(buf);\n"
|
|
" else\n"
|
|
" free(new_buf);\n"
|
|
"}\n", true);
|
|
|
|
// There isn't a memory leak in the code
|
|
TODO_ASSERT_EQUALS("", errout.str());
|
|
|
|
// This assertion checks that the message stays the same. Upon changes in the error message
|
|
// we will be notified
|
|
ASSERT_EQUALS("[test.cpp:11]: (possible error) Memory leak: buf\n", errout.str());
|
|
}
|
|
|
|
void realloc6()
|
|
{
|
|
ASSERT_EQUALS(";;realloc;;", getcode("char *buf; buf=realloc(buf,100);", "buf"));
|
|
ASSERT_EQUALS(";;alloc;", getcode("char *buf; buf=realloc(0,100);", "buf"));
|
|
}
|
|
|
|
void assign()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *a = (char *)malloc(10);\n"
|
|
" a = 0;\n"
|
|
" free(a);\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Memory leak: a\n", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *a = (char *)malloc(10);\n"
|
|
" char *p = a;\n"
|
|
" free(p);\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *a = (char *)malloc(10);\n"
|
|
" char *p = a + 1;\n"
|
|
" free(p);\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *a = (char *)malloc(10);\n"
|
|
" a += 10;\n"
|
|
" free(a - 10);\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *a = (char *)malloc(10);\n"
|
|
" a = (void *)a + 10;\n"
|
|
" free(a - 10);\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *a = new char[100];\n"
|
|
" list += a;\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void varid()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *p = malloc(100);\n"
|
|
" {\n"
|
|
" char *p = 0;\n"
|
|
" delete p;\n"
|
|
" }\n"
|
|
" free(p);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void cast1()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *a = reinterpret_cast<char *>(malloc(10));\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Memory leak: a\n", errout.str());
|
|
}
|
|
|
|
|
|
|
|
void dealloc_use()
|
|
{
|
|
// It is ok to take the address..
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *s = new char[100];\n"
|
|
" delete [] s;\n"
|
|
" p = s;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *s = new char[100];\n"
|
|
" delete [] s;\n"
|
|
" foo(s);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// The pointer to the pointer is valid..
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *str;\n"
|
|
" free(str);\n"
|
|
" foo(&str);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *str = 0;\n"
|
|
" free(str);\n"
|
|
" f1(&str);\n"
|
|
" f2(str);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// Dereferencing the freed pointer is not ok..
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *str = malloc(10);\n"
|
|
" free(str);\n"
|
|
" char c = *str;\n"
|
|
"}\n");
|
|
TODO_ASSERT_EQUALS("[test.cpp:5]: (error) Dereferencing 'str' after it is deallocated / released\n", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *str = malloc(10);\n"
|
|
" free(str);\n"
|
|
" char c = str[10];\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Dereferencing 'str' after it is deallocated / released\n", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *str = malloc(10);\n"
|
|
" free(str);\n"
|
|
" str[10] = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Dereferencing 'str' after it is deallocated / released\n", errout.str());
|
|
}
|
|
|
|
|
|
void freefree1()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *str = malloc(100);\n"
|
|
" free(str);\n"
|
|
" free(str);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Deallocating a deallocated pointer: str\n", errout.str());
|
|
}
|
|
|
|
void freefree2()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" FILE *fd = fopen(\"test.txt\", \"wb\");\n"
|
|
" fprintf(fd, \"test\");\n"
|
|
" fclose(fd);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void strcpy_result_assignment()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *p1 = malloc(10);\n"
|
|
" char *p2 = strcpy(p1, \"a\");\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void strcat_result_assignment()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" char *p = malloc(10);\n"
|
|
" p[0] = 0;\n"
|
|
" p = strcat( p, \"a\" );\n"
|
|
" free( p );\n"
|
|
" return 0;\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
|
|
void all1()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" Fred *f = new Fred;\n"
|
|
"}\n", false);
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" Fred *f = new Fred;\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("[test.cpp:4]: (possible error) Memory leak: f\n", errout.str());
|
|
}
|
|
|
|
|
|
|
|
void malloc_constant_1()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" int *p = malloc(3);\n"
|
|
" free(p);\n"
|
|
"}\n", false);
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) The given size 3 is mismatching\n", errout.str());
|
|
}
|
|
|
|
|
|
|
|
void unknownFunction1()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" int *p = new int[100];\n"
|
|
" if (abc)\n"
|
|
" {\n"
|
|
" delete [] p;\n"
|
|
" ThrowException();\n"
|
|
" }\n"
|
|
" delete [] p;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void unknownFunction2()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" int *p = new int[100];\n"
|
|
" if (abc)\n"
|
|
" {\n"
|
|
" delete [] p;\n"
|
|
" ThrowException();\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:9]: (error) Memory leak: p\n", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" int *p = new int[100];\n"
|
|
" p = g();\n"
|
|
" delete [] p;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Memory leak: p\n", errout.str());
|
|
}
|
|
|
|
void unknownFunction3()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" int *p = new int[100];\n"
|
|
" ThrowException();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: p\n", errout.str());
|
|
}
|
|
|
|
void unknownFunction4()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" int *p = new int[100];\n"
|
|
" a();\n"
|
|
" if (b) return;\n"
|
|
" delete [] p;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: p\n", errout.str());
|
|
}
|
|
|
|
void unknownFunction5()
|
|
{
|
|
check("static void foo()\n"
|
|
"{\n"
|
|
" char *p = NULL;\n"
|
|
"\n"
|
|
" if( a )\n"
|
|
" p = malloc(100);\n"
|
|
"\n"
|
|
" if( a )\n"
|
|
" {\n"
|
|
" FREENULL(p);\n"
|
|
" FREENULL();\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void checkvcl(const char code[], const char _autoDealloc[])
|
|
{
|
|
// Tokenize..
|
|
Tokenizer tokenizer;
|
|
{
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
}
|
|
tokenizer.setVarId();
|
|
tokenizer.simplifyTokenList();
|
|
|
|
// Clear the error buffer..
|
|
errout.str("");
|
|
|
|
// Check for memory leaks..
|
|
Settings settings;
|
|
settings._debug = true;
|
|
settings._showAll = true;
|
|
|
|
{
|
|
std::istringstream istr(_autoDealloc);
|
|
settings.autoDealloc(istr);
|
|
}
|
|
|
|
CheckMemoryLeakInFunction checkMemoryLeak(&tokenizer, &settings, this);
|
|
checkMemoryLeak.check();
|
|
}
|
|
|
|
|
|
|
|
void vcl1()
|
|
{
|
|
checkvcl("void Form1::foo()\n"
|
|
"{\n"
|
|
" TEdit *Edit1 = new TEdit(this);\n"
|
|
"}\n", "TEdit\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void vcl2()
|
|
{
|
|
checkvcl("class Fred\n"
|
|
"{\n"
|
|
"private:\n"
|
|
" TButton *button;\n"
|
|
"public:\n"
|
|
" Fred();\n"
|
|
"};\n"
|
|
"\n"
|
|
"Fred::Fred()\n"
|
|
"{\n"
|
|
" button = new TButton(this);\n"
|
|
"}\n", "TButton\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void autoptr1()
|
|
{
|
|
check("std::auto_ptr<int> foo()\n"
|
|
"{\n"
|
|
" int *i = new int;\n"
|
|
" return std::auto_ptr<int>(i);\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void if_with_and()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *a = new char[10];\n"
|
|
" if (!a && b() )\n"
|
|
" return;\n"
|
|
"\n"
|
|
" delete [] a;\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *a = new char[10];\n"
|
|
" if (b() && !a )\n"
|
|
" return;\n"
|
|
"\n"
|
|
" delete [] a;\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void assign_pclose()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" FILE *f = popen (\"test\", \"w\");\n"
|
|
" int a = pclose(f);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void exit2()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *out = new char[100];\n"
|
|
" exit(0);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *out = new char[100];\n"
|
|
" if( out ) {}\n"
|
|
" exit(0);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void exit4()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *p = malloc(100);\n"
|
|
" if (x)\n"
|
|
" {\n"
|
|
" exit(0);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (error) Memory leak: p\n", errout.str());
|
|
}
|
|
|
|
void exit5()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *p = malloc(100);\n"
|
|
" if (p)\n"
|
|
" {\n"
|
|
" xyz();\n"
|
|
" exit(0);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
|
|
void stdstring()
|
|
{
|
|
check("void f(std::string foo)\n"
|
|
"{\n"
|
|
" char *out = new char[11];\n"
|
|
" memset(&(out[0]), 0, 1);\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: out\n", errout.str());
|
|
}
|
|
|
|
void strndup_function()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" char *out = strndup(\"text\", 3);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Memory leak: out\n", errout.str());
|
|
}
|
|
|
|
void tmpfile_function()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" FILE *f = tmpfile();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Resource leak: f\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" FILE *f = tmpfile();\n"
|
|
" if (!f)\n"
|
|
" return;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Resource leak: f\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" FILE *f = tmpfile();\n"
|
|
" fclose(f);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" FILE *f = tmpfile();\n"
|
|
" if (!f)\n"
|
|
" return;\n"
|
|
" fclose(f);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("FILE *f()\n"
|
|
"{\n"
|
|
" return tmpfile();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void fcloseall_function()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" FILE *f = fopen(fname, str);\n"
|
|
" fcloseall();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" FILE *f = tmpfile();\n"
|
|
" fcloseall();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void open_function()
|
|
{
|
|
check("void f(const char *path)\n"
|
|
"{\n"
|
|
" int fd = open(path, O_RDONLY);\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Resource leak: fd\n", errout.str());
|
|
|
|
check("void f(const char *path)\n"
|
|
"{\n"
|
|
" int fd = open(path, O_RDONLY);\n"
|
|
" if (fd == -1)\n"
|
|
" return;\n"
|
|
" close(fd);\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f(const char *path)\n"
|
|
"{\n"
|
|
" int fd = open(path, O_RDONLY);\n"
|
|
" if (fd < 0)\n"
|
|
" return;\n"
|
|
" close(fd);\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void creat_function()
|
|
{
|
|
check("void f(const char *path)\n"
|
|
"{\n"
|
|
" int fd = creat(path, S_IRWXU);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Resource leak: fd\n", errout.str());
|
|
}
|
|
|
|
void close_function()
|
|
{
|
|
check("void f(const char *path)\n"
|
|
"{\n"
|
|
" int fd = open(path, O_RDONLY);\n"
|
|
" close(fd);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f(const char *path)\n"
|
|
"{\n"
|
|
" int fd = creat(path, S_IRWXU);\n"
|
|
" close(fd);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f(const char *path)\n"
|
|
"{\n"
|
|
" int fd = creat(path, S_IRWXU);\n"
|
|
" if (close(fd) < 0) {\n"
|
|
" perror(\"close\");\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void fd_functions()
|
|
{
|
|
check("void f(const char *path)\n"
|
|
"{\n"
|
|
" int fd = open(path, O_RDONLY);\n"
|
|
" read(fd, buf, count);\n"
|
|
" readv(fd, iov, iovcnt);\n"
|
|
" readahead(fd, offset, count);\n"
|
|
" pread(fd, buf, count, offset);\n"
|
|
" write(fd, buf, count);\n"
|
|
" writev(fd, iov, iovcnt);\n"
|
|
" pwrite(fd, buf, count, offset);\n"
|
|
" ioctl(fd, request);\n"
|
|
" posix_fallocate(fd, offset, len);\n"
|
|
" posix_fadvise(fd, offset, len, advise);\n"
|
|
" fsync(fd);\n"
|
|
" fdatasync(fd);\n"
|
|
" sync_file_range(fd, offset, nbytes, flags);\n"
|
|
" lseek(fd, offset, whence);\n"
|
|
" fcntl(fd, cmd);\n"
|
|
" flock(fd, op);\n"
|
|
" lockf(fd, cmd, len);\n"
|
|
" ftruncate(fd, len);\n"
|
|
" fstat(fd, buf);\n"
|
|
" fchmod(fd, mode);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:24]: (error) Resource leak: fd\n", errout.str());
|
|
}
|
|
|
|
void opendir_function()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" DIR *f = opendir(\".\");\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Resource leak: f\n", errout.str());
|
|
}
|
|
|
|
void fdopendir_function()
|
|
{
|
|
check("void f(int fd)\n"
|
|
"{\n"
|
|
" DIR *f = fdopendir(fd);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Resource leak: f\n", errout.str());
|
|
}
|
|
|
|
void closedir_function()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" DIR *f = opendir(\".\");\n"
|
|
" closedir(f);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f(int fd)\n"
|
|
"{\n"
|
|
" DIR *f = fdopendir(fd);\n"
|
|
" closedir(f);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" DIR * f = opendir(dirname);\n"
|
|
" if (closedir(f));\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void dir_functions()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" DIR *f = opendir(dir);\n"
|
|
" readdir(f);\n;"
|
|
" readdir_r(f, entry, res);\n;"
|
|
" rewinddir(f);\n;"
|
|
" telldir(f);\n;"
|
|
" seekdir(f, 2)\n;"
|
|
" scandir(f, namelist, filter, comp);\n;"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:10]: (error) Resource leak: f\n", errout.str());
|
|
}
|
|
|
|
void file_functions()
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
"FILE *f = fopen(fname, str);\n"
|
|
"feof(f);\n"
|
|
"clearerr(in);\n"
|
|
"ferror(in);\n"
|
|
"fread(ptr, 10, 1, in);\n"
|
|
"fwrite(ptr, 10, 1, in);\n"
|
|
"fflush(in);\n"
|
|
"setbuf(in, buf);\n"
|
|
"setbuffer(in, buf, 100);\n"
|
|
"setlinebuf(in);\n"
|
|
"setvbuf(in, buf, _IOLBF, 0);\n"
|
|
"fseek(in, 10, SEEK_SET);\n"
|
|
"fseeko(in, 10, SEEK_SET);\n"
|
|
"ftell(in);\n"
|
|
"ftello(in);\n"
|
|
"rewind(in);\n"
|
|
"fsetpos(in, 0);\n"
|
|
"fgetpos(in, 10);\n"
|
|
"fprintf(in, \"text\\n\");\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:22]: (error) Resource leak: f\n", errout.str());
|
|
}
|
|
|
|
void getc_function()
|
|
{
|
|
{
|
|
check("void f()\n"
|
|
"{"
|
|
" int c;\n"
|
|
" FILE *fin1a = fopen (\"FILE.txt\", \"r\");\n"
|
|
" while ( (c = getc (fin1a)) != EOF)\n"
|
|
" { }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Resource leak: fin1a\n", errout.str());
|
|
}
|
|
|
|
{
|
|
check("void f()\n"
|
|
"{\n"
|
|
" int c;\n"
|
|
" FILE *fin1b = fopen(\"FILE.txt\", \"r\");\n"
|
|
" c = getc(fin1b);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Resource leak: fin1b\n", errout.str());
|
|
}
|
|
}
|
|
|
|
void pointer_to_pointer()
|
|
{
|
|
check("void f(char **data)\n"
|
|
"{\n"
|
|
" char *c = new char[12];\n"
|
|
" *c = 0;\n"
|
|
" *data = c;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void dealloc_and_alloc_in_func()
|
|
{
|
|
check("char *f( const char *x )\n"
|
|
"{\n"
|
|
" delete [] x;\n"
|
|
" return new char[10];\n"
|
|
"}\n"
|
|
"\n"
|
|
"int main()\n"
|
|
"{\n"
|
|
" char *a=0;\n"
|
|
" a = f( a );\n"
|
|
" a[0] = 1;\n"
|
|
" delete [] a;\n"
|
|
" return 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void unknownSyntax1()
|
|
{
|
|
// I don't know what this syntax means so cppcheck should bail out
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" void *sym = ( {\n"
|
|
" void *__ptr = malloc(100);\n"
|
|
" if(!__ptr && 100 != 0)\n"
|
|
" {\n"
|
|
" exit(1);\n"
|
|
" }\n"
|
|
" __ptr;\n"
|
|
" } );\n"
|
|
" free(sym);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void knownFunctions()
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" int *p = new int[100];\n"
|
|
" typeid(p);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: p\n", errout.str());
|
|
}
|
|
};
|
|
|
|
static TestMemleakInFunction testMemleakInFunction;
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
class TestMemleakInClass : public TestFixture
|
|
{
|
|
public:
|
|
TestMemleakInClass() : TestFixture("TestMemleakInClass")
|
|
{ }
|
|
|
|
private:
|
|
void check(const char code[], bool showAll = false)
|
|
{
|
|
// Tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.setVarId();
|
|
tokenizer.simplifyTokenList();
|
|
|
|
// Clear the error buffer..
|
|
errout.str("");
|
|
|
|
// Check for memory leaks..
|
|
Settings settings;
|
|
settings._debug = true;
|
|
settings._showAll = showAll;
|
|
tokenizer.fillFunctionList();
|
|
CheckMemoryLeakInClass checkMemoryLeak(&tokenizer, &settings, this);
|
|
checkMemoryLeak.check();
|
|
}
|
|
|
|
void run()
|
|
{
|
|
TEST_CASE(class1);
|
|
TEST_CASE(class2);
|
|
TEST_CASE(class3);
|
|
TEST_CASE(class4);
|
|
TEST_CASE(class6);
|
|
TEST_CASE(class7);
|
|
TEST_CASE(class8);
|
|
TEST_CASE(class9);
|
|
TEST_CASE(class10);
|
|
TEST_CASE(class11);
|
|
|
|
TEST_CASE(staticvar);
|
|
|
|
TEST_CASE(use);
|
|
|
|
TEST_CASE(free_member_in_sub_func);
|
|
}
|
|
|
|
|
|
void class1()
|
|
{
|
|
check("class Fred\n"
|
|
"{\n"
|
|
"private:\n"
|
|
" char *str1;\n"
|
|
" char *str2;\n"
|
|
"public:\n"
|
|
" Fred();\n"
|
|
" ~Fred();\n"
|
|
"};\n"
|
|
"\n"
|
|
"Fred::Fred()\n"
|
|
"{\n"
|
|
" str1 = new char[10];\n"
|
|
" str2 = new char[10];\n"
|
|
"}\n"
|
|
"\n"
|
|
"Fred::~Fred()\n"
|
|
"{\n"
|
|
" delete [] str2;\n"
|
|
"}\n", true);
|
|
|
|
ASSERT_EQUALS("[test.cpp:4]: (possible error) Memory leak: Fred::str1\n", errout.str());
|
|
}
|
|
|
|
|
|
void class2()
|
|
{
|
|
check("class Fred\n"
|
|
"{\n"
|
|
"private:\n"
|
|
" char *str1;\n"
|
|
"public:\n"
|
|
" Fred();\n"
|
|
" ~Fred();\n"
|
|
"};\n"
|
|
"\n"
|
|
"Fred::Fred()\n"
|
|
"{\n"
|
|
" str1 = new char[10];\n"
|
|
"}\n"
|
|
"\n"
|
|
"Fred::~Fred()\n"
|
|
"{\n"
|
|
" free(str1);\n"
|
|
"}\n", true);
|
|
|
|
ASSERT_EQUALS("[test.cpp:17]: (error) Mismatching allocation and deallocation: Fred::str1\n", errout.str());
|
|
}
|
|
|
|
void class3()
|
|
{
|
|
check("class Token;\n"
|
|
"\n"
|
|
"class Tokenizer\n"
|
|
"{\n"
|
|
"private:\n"
|
|
" Token *_tokens;\n"
|
|
"\n"
|
|
"public:\n"
|
|
" Tokenizer();\n"
|
|
" ~Tokenizer();\n"
|
|
" void deleteTokens(Token *tok);\n"
|
|
"};\n"
|
|
"\n"
|
|
"Tokenizer::Tokenizer()\n"
|
|
"{\n"
|
|
" _tokens = new Token;\n"
|
|
"}\n"
|
|
"\n"
|
|
"Tokenizer::~Tokenizer()\n"
|
|
"{\n"
|
|
" deleteTokens(_tokens);\n"
|
|
"}\n"
|
|
"\n"
|
|
"void Tokenizer::deleteTokens(Token *tok)\n"
|
|
"{\n"
|
|
" while (tok)\n"
|
|
" {\n"
|
|
" Token *next = tok->next();\n"
|
|
" delete tok;\n"
|
|
" tok = next;\n"
|
|
" }\n"
|
|
"}\n", true);
|
|
|
|
TODO_ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void class4()
|
|
{
|
|
check("struct ABC;\n"
|
|
"class Fred\n"
|
|
"{\n"
|
|
"private:\n"
|
|
" void addAbc(ABC *abc);\n"
|
|
"public:\n"
|
|
" void click();\n"
|
|
"};\n"
|
|
"\n"
|
|
"void Fred::addAbc(ABC* abc)\n"
|
|
"{\n"
|
|
" AbcPosts->Add(abc);\n"
|
|
"}\n"
|
|
"\n"
|
|
"void Fred::click()\n"
|
|
"{\n"
|
|
" ABC *p = new ABC;\n"
|
|
" addAbc( p );\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void class6()
|
|
{
|
|
check("class Fred\n"
|
|
"{\n"
|
|
"public:\n"
|
|
" void foo();\n"
|
|
"};\n"
|
|
"\n"
|
|
"void Fred::foo()\n"
|
|
"{\n"
|
|
" char *str = new char[100];\n"
|
|
" delete [] str;\n"
|
|
" hello();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void class7()
|
|
{
|
|
check("class Fred\n"
|
|
"{\n"
|
|
"public:\n"
|
|
" int *i;\n"
|
|
" Fred();\n"
|
|
" ~Fred();\n"
|
|
"};\n"
|
|
"\n"
|
|
"Fred::Fred()\n"
|
|
"{\n"
|
|
" this->i = new int;\n"
|
|
"}\n"
|
|
"Fred::~Fred()\n"
|
|
"{\n"
|
|
" delete this->i;\n"
|
|
"}\n", true);
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void class8()
|
|
{
|
|
check("class A\n"
|
|
"{\n"
|
|
"public:\n"
|
|
" void a();\n"
|
|
" void doNothing() { }\n"
|
|
"};\n"
|
|
"\n"
|
|
"void A::a()\n"
|
|
"{\n"
|
|
" int* c = new int(1);\n"
|
|
" delete c;\n"
|
|
" doNothing(c);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void class9()
|
|
{
|
|
check("class A\n"
|
|
"{\n"
|
|
"public:\n"
|
|
" int * p;\n"
|
|
" A();\n"
|
|
" ~A();\n"
|
|
"};\n"
|
|
"\n"
|
|
"A::A()\n"
|
|
"{ p = new int; }\n"
|
|
"\n"
|
|
"A::~A()\n"
|
|
"{ delete (p); }\n", true);
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void class10()
|
|
{
|
|
check("class A\n"
|
|
"{\n"
|
|
"public:\n"
|
|
" int * p;\n"
|
|
" A() { p = new int; }\n"
|
|
"};\n", true);
|
|
ASSERT_EQUALS("[test.cpp:4]: (possible error) Memory leak: A::p\n", errout.str());
|
|
}
|
|
|
|
void class11()
|
|
{
|
|
check("class A\n"
|
|
"{\n"
|
|
"public:\n"
|
|
" int * p;\n"
|
|
" A();\n"
|
|
"};\n"
|
|
"A::A() : p(new int[10])\n"
|
|
"{ }", true);
|
|
ASSERT_EQUALS("[test.cpp:4]: (possible error) Memory leak: A::p\n", errout.str());
|
|
}
|
|
|
|
|
|
void staticvar()
|
|
{
|
|
check("class A\n"
|
|
"{\n"
|
|
"private:\n"
|
|
" static int * p;\n"
|
|
"public:"
|
|
" A()\n"
|
|
" {\n"
|
|
" if (!p)\n"
|
|
" p = new int[100];\n"
|
|
" }\n"
|
|
"};\n", true);
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void use()
|
|
{
|
|
check("class A\n"
|
|
"{\n"
|
|
"public:\n"
|
|
" Fred * fred;\n"
|
|
" A();\n"
|
|
"};\n"
|
|
"A::A()\n"
|
|
"{\n"
|
|
" fred = new Fred;\n"
|
|
" list->push_back(fred);\n"
|
|
"}", true);
|
|
TODO_ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void free_member_in_sub_func()
|
|
{
|
|
// Member function
|
|
check("class Tokenizer\n"
|
|
"{\n"
|
|
"public:\n"
|
|
" Tokenizer();\n"
|
|
" ~Tokenizer();\n"
|
|
"\n"
|
|
"private:\n"
|
|
" int *_tokens;\n"
|
|
" static void deleteTokens(int *tok);\n"
|
|
"};\n"
|
|
"\n"
|
|
"Tokenizer::Tokenizer()\n"
|
|
"{\n"
|
|
" _tokens = new int;\n"
|
|
"}\n"
|
|
"\n"
|
|
"Tokenizer::~Tokenizer()\n"
|
|
"{\n"
|
|
" deleteTokens(_tokens);\n"
|
|
" _tokens = 0;\n"
|
|
"}\n"
|
|
"\n"
|
|
"void Tokenizer::deleteTokens(int *tok)\n"
|
|
"{\n"
|
|
" delete tok;\n"
|
|
"}\n", true);
|
|
TODO_ASSERT_EQUALS("", errout.str());
|
|
|
|
// Global function
|
|
check("void deleteTokens(int *tok)\n"
|
|
"{\n"
|
|
" delete tok;\n"
|
|
"}\n"
|
|
"class Tokenizer\n"
|
|
"{\n"
|
|
"public:\n"
|
|
" Tokenizer();\n"
|
|
" ~Tokenizer();\n"
|
|
"\n"
|
|
"private:\n"
|
|
" int *_tokens;\n"
|
|
"};\n"
|
|
"\n"
|
|
"Tokenizer::Tokenizer()\n"
|
|
"{\n"
|
|
" _tokens = new int;\n"
|
|
"}\n"
|
|
"\n"
|
|
"Tokenizer::~Tokenizer()\n"
|
|
"{\n"
|
|
" deleteTokens(_tokens);\n"
|
|
" _tokens = 0;\n"
|
|
"}\n", true);
|
|
TODO_ASSERT_EQUALS("", errout.str());
|
|
}
|
|
};
|
|
|
|
static TestMemleakInClass testMemleakInClass;
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
class TestMemleakStructMember : public TestFixture
|
|
{
|
|
public:
|
|
TestMemleakStructMember() : TestFixture("TestMemleakStructMember")
|
|
{ }
|
|
|
|
private:
|
|
void check(const char code[])
|
|
{
|
|
// Tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.simplifyTokenList();
|
|
|
|
// Clear the error buffer..
|
|
errout.str("");
|
|
|
|
// Check for memory leaks..
|
|
Settings settings;
|
|
CheckMemoryLeakStructMember checkMemoryLeakStructMember(&tokenizer, &settings, this);
|
|
checkMemoryLeakStructMember.check();
|
|
}
|
|
|
|
void run()
|
|
{
|
|
// testing that errors are detected
|
|
TEST_CASE(err);
|
|
|
|
// handle / bail out when "goto" is found
|
|
TEST_CASE(goto_);
|
|
|
|
// Don't report errors if the struct is returned
|
|
TEST_CASE(ret);
|
|
|
|
// assignments
|
|
TEST_CASE(assign);
|
|
|
|
// Failed allocation
|
|
TEST_CASE(failedAllocation);
|
|
|
|
// Deallocating in a function
|
|
TEST_CASE(function);
|
|
|
|
// Handle if-else
|
|
TEST_CASE(ifelse);
|
|
|
|
// struct variable is a global variable
|
|
TEST_CASE(globalvar);
|
|
}
|
|
|
|
void err()
|
|
{
|
|
check("static void foo()\n"
|
|
"{\n"
|
|
" struct ABC *abc = malloc(sizeof(struct ABC));\n"
|
|
" abc->a = malloc(10);\n"
|
|
" free(abc);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: abc.a\n", errout.str());
|
|
|
|
check("static void foo()\n"
|
|
"{\n"
|
|
" struct ABC *abc = malloc(sizeof(struct ABC));\n"
|
|
" abc->a = malloc(10);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Memory leak: abc.a\n", errout.str());
|
|
|
|
check("static ABC * foo()\n"
|
|
"{\n"
|
|
" ABC *abc = malloc(sizeof(ABC));\n"
|
|
" abc->a = malloc(10);\n"
|
|
" abc->b = malloc(10);\n"
|
|
" if (abc->b == 0)\n"
|
|
" {\n"
|
|
" return 0;\n"
|
|
" }\n"
|
|
" return abc;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (error) Memory leak: abc.a\n", errout.str());
|
|
|
|
check("static void foo(int a)\n"
|
|
"{\n"
|
|
" ABC *abc = malloc(sizeof(ABC));\n"
|
|
" abc->a = malloc(10);\n"
|
|
" if (a == 1)\n"
|
|
" {\n"
|
|
" free(abc->a);\n"
|
|
" return;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:10]: (error) Memory leak: abc.a\n", errout.str());
|
|
}
|
|
|
|
void goto_()
|
|
{
|
|
check("static void foo()\n"
|
|
"{\n"
|
|
" struct ABC *abc = malloc(sizeof(struct ABC));\n"
|
|
" abc->a = malloc(10);\n"
|
|
" if (abc->a)\n"
|
|
" { goto out; }\n"
|
|
" free(abc);\n"
|
|
" return;\n"
|
|
"out:\n"
|
|
" free(abc->a);\n"
|
|
" free(abc);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void ret()
|
|
{
|
|
check("static ABC * foo()\n"
|
|
"{\n"
|
|
" struct ABC *abc = malloc(sizeof(struct ABC));\n"
|
|
" abc->a = malloc(10);\n"
|
|
" return abc;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("static void foo(struct ABC *abc)\n"
|
|
"{\n"
|
|
" abc->a = malloc(10);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void assign()
|
|
{
|
|
check("static void foo()\n"
|
|
"{\n"
|
|
" struct ABC *abc = abc1;\n"
|
|
" abc->a = malloc(10);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("static void foo()\n"
|
|
"{\n"
|
|
" struct ABC *abc;\n"
|
|
" abc1 = abc = malloc(sizeof(ABC));\n"
|
|
" abc->a = malloc(10);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
|
|
check("static void foo()\n"
|
|
"{\n"
|
|
" struct msn_entry *ptr;\n"
|
|
" ptr = malloc(sizeof(struct msn_entry));\n"
|
|
" ptr->msn = malloc(100);\n"
|
|
" back = ptr;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
}
|
|
|
|
void failedAllocation()
|
|
{
|
|
check("static struct ABC * foo()\n"
|
|
"{\n"
|
|
" struct ABC *abc = malloc(sizeof(struct ABC));\n"
|
|
" abc->a = malloc(10);\n"
|
|
" if (!abc->a)\n"
|
|
" {\n"
|
|
" free(abc);\n"
|
|
" return 0;\n"
|
|
" }\n"
|
|
" return abc;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void function()
|
|
{
|
|
// Not found function => assume that the function may deallocate
|
|
check("static void foo()\n"
|
|
"{\n"
|
|
" struct ABC *abc = malloc(sizeof(struct ABC));\n"
|
|
" abc->a = malloc(10);\n"
|
|
" func(abc);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("static void foo()\n"
|
|
"{\n"
|
|
" struct ABC *abc = malloc(sizeof(struct ABC));\n"
|
|
" abclist.push_back(abc);\n"
|
|
" abc->a = malloc(10);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void ifelse()
|
|
{
|
|
check("static void foo()\n"
|
|
"{\n"
|
|
" struct ABC *abc = malloc(sizeof(struct ABC));\n"
|
|
" if (x)"
|
|
" {\n"
|
|
" abc->a = malloc(10);\n"
|
|
" }\n"
|
|
" else\n"
|
|
" {\n"
|
|
" free(abc);\n"
|
|
" return;\n"
|
|
" }\n"
|
|
" free(abc->a);\n"
|
|
" free(abc);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void globalvar()
|
|
{
|
|
check("struct ABC *abc;\n"
|
|
"\n"
|
|
"static void foo()\n"
|
|
"{\n"
|
|
" abc = malloc(sizeof(struct ABC));\n"
|
|
" abc->a = malloc(10);\n"
|
|
" return;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
};
|
|
|
|
|
|
static TestMemleakStructMember testMemleakStructMember;
|
|
|