bdd57e6913
This reverts commit 598809a8342fcd27ea043bd890b428f0999098e2. The problem does not exist in practice and the theoretical issue will be fixed as soon as the check is rewritten to make use of Libraries.
77 lines
3.6 KiB
C++
77 lines
3.6 KiB
C++
/*
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|
* Copyright (C) 2007-2015 Daniel Marjamäki and Cppcheck team.
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
//---------------------------------------------------------------------------
|
|
// Obsolete functions
|
|
//---------------------------------------------------------------------------
|
|
|
|
#include "checkobsolescentfunctions.h"
|
|
#include "symboldatabase.h"
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
std::map<std::string, std::string> CheckObsoleteFunctions::_obsoleteStandardFunctions;
|
|
std::map<std::string, std::string> CheckObsoleteFunctions::_obsoletePosixFunctions;
|
|
std::map<std::string, std::string> CheckObsoleteFunctions::_obsoleteC99Functions;
|
|
|
|
|
|
// Register this check class (by creating a static instance of it)
|
|
namespace {
|
|
CheckObsoleteFunctions instance;
|
|
}
|
|
|
|
void CheckObsoleteFunctions::obsoleteFunctions()
|
|
{
|
|
if (!_settings->isEnabled("style"))
|
|
return;
|
|
|
|
const SymbolDatabase *symbolDatabase = _tokenizer->getSymbolDatabase();
|
|
const bool cStandard = _settings->standards.c >= Standards::C99 ;
|
|
|
|
for (unsigned int i = 0; i < symbolDatabase->functionScopes.size(); i++) {
|
|
const Scope* scope = symbolDatabase->functionScopes[i];
|
|
for (const Token* tok = scope->classStart; tok != scope->classEnd; tok = tok->next()) {
|
|
if (tok->isName() && tok->varId()==0 && (!tok->function() || !tok->function()->hasBody()) && tok->strAt(1) == "(" &&
|
|
tok->strAt(-1) != "." && (!Token::Match(tok->tokAt(-2), "%name% ::") || Token::simpleMatch(tok->tokAt(-2), "std ::"))) {
|
|
|
|
std::map<std::string,std::string>::const_iterator it = _obsoleteStandardFunctions.find(tok->str());
|
|
if (it != _obsoleteStandardFunctions.end()) {
|
|
// If checking an old code base it might be uninteresting to update obsolete functions.
|
|
reportError(tok, Severity::style, "obsoleteFunctions"+it->first, it->second);
|
|
} else {
|
|
if (_settings->standards.posix) {
|
|
it = _obsoletePosixFunctions.find(tok->str());
|
|
if (it != _obsoletePosixFunctions.end()) {
|
|
// If checking an old code base it might be uninteresting to update obsolete functions.
|
|
reportError(tok, Severity::style, "obsoleteFunctions"+it->first, it->second);
|
|
}
|
|
}
|
|
if (cStandard) {
|
|
// alloca : this function is obsolete in C but not in C++ (#4382)
|
|
it = _obsoleteC99Functions.find(tok->str());
|
|
if (it != _obsoleteC99Functions.end() && !(tok->str() == "alloca" && _tokenizer->isCPP())) {
|
|
reportError(tok, Severity::style, "obsoleteFunctions"+it->first, it->second);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
//---------------------------------------------------------------------------
|