3cfe7ca1a7
"information" severity is documented in lib/errorlogger.h as: Checking information. Information message about the checking (process) itself. These messages inform about header files not found etc issues that are not errors in the code but something user needs to know. It IS NOT for errors in the code. All the current "information"- severity errors fit nicely into description of the "style"- severity. We definitely need to separate processing information and actual errors in the code. It is highly confusing for users to mix these two different things. Hence all current "information" code error messages are moved to "style" category. Ticket: #3165 (Stop misusing the 'information' error severity!)
137 lines
4.2 KiB
C++
137 lines
4.2 KiB
C++
/*
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|
* Copyright (C) 2007-2011 Daniel Marjamäki and Cppcheck team.
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
|
|
#include "tokenize.h"
|
|
#include "checkassignif.h"
|
|
#include "testsuite.h"
|
|
#include <sstream>
|
|
|
|
extern std::ostringstream errout;
|
|
|
|
class TestAssignIf : public TestFixture
|
|
{
|
|
public:
|
|
TestAssignIf() : TestFixture("TestAssignIf")
|
|
{ }
|
|
|
|
private:
|
|
|
|
|
|
void run()
|
|
{
|
|
TEST_CASE(assignAndCompare); // assignment and comparison don't match
|
|
TEST_CASE(compare); // mismatching LHS/RHS in comparison
|
|
TEST_CASE(multicompare); // mismatching comparisons
|
|
}
|
|
|
|
void check(const char code[])
|
|
{
|
|
// Clear the error buffer..
|
|
errout.str("");
|
|
|
|
Settings settings;
|
|
settings.addEnabled("style");
|
|
|
|
// Tokenize..
|
|
Tokenizer tokenizer(&settings, this);
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.setVarId();
|
|
tokenizer.simplifyTokenList();
|
|
|
|
// Check char variable usage..
|
|
CheckAssignIf checkAssignIf(&tokenizer, &settings, this);
|
|
checkAssignIf.assignIf();
|
|
checkAssignIf.comparison();
|
|
checkAssignIf.multiCondition();
|
|
}
|
|
|
|
void assignAndCompare()
|
|
{
|
|
// &
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" int y = x & 4;\n"
|
|
" if (y == 3);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (style) Mismatching assignment and comparison, comparison is always false\n", errout.str());
|
|
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" int y = x & 4;\n"
|
|
" if (y != 3);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (style) Mismatching assignment and comparison, comparison is always true\n", errout.str());
|
|
|
|
// |
|
|
check("void foo(int x) {\n"
|
|
" int y = x | 0x14;\n"
|
|
" if (y == 0x710);\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:3]: (style) Mismatching assignment and comparison, comparison is always false\n", errout.str());
|
|
|
|
check("void foo(int x) {\n"
|
|
" int y = x | 0x14;\n"
|
|
" if (y == 0x71f);\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void compare()
|
|
{
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" if (x & 4 == 3);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (style) Mismatching comparison, the result is always false\n", errout.str());
|
|
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" if ((x & 4) == 3);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (style) Mismatching comparison, the result is always false\n", errout.str());
|
|
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" if (x & 4 != 3);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (style) Mismatching comparison, the result is always true\n", errout.str());
|
|
}
|
|
|
|
void multicompare()
|
|
{
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" if (x & 7);\n"
|
|
" else if (x == 1);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (style) 'else if' condition matches previous condition at line 3\n", errout.str());
|
|
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" if (x & 7);\n"
|
|
" else if (x & 1);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (style) 'else if' condition matches previous condition at line 3\n", errout.str());
|
|
}
|
|
};
|
|
|
|
REGISTER_TEST(TestAssignIf)
|
|
|