635 lines
19 KiB
C++
635 lines
19 KiB
C++
/*
|
|
* cppcheck - c/c++ syntax checking
|
|
* Copyright (C) 2007-2009 Daniel Marjamäki, Reijo Tomperi, Nicolas Le Cam
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/
|
|
*/
|
|
|
|
|
|
// The preprocessor that c++check uses is a bit special. Instead of generating
|
|
// the code for a known configuration, it generates the code for each configuration.
|
|
|
|
|
|
#include <cstring>
|
|
#include "testsuite.h"
|
|
#define UNIT_TESTING // Get access to "private" data in Tokenizer
|
|
#include "../src/tokenize.h"
|
|
|
|
extern std::ostringstream errout;
|
|
class TestTokenizer : public TestFixture
|
|
{
|
|
public:
|
|
TestTokenizer() : TestFixture("TestTokenizer")
|
|
{ }
|
|
|
|
private:
|
|
|
|
void run()
|
|
{
|
|
TEST_CASE(longtok);
|
|
|
|
TEST_CASE(inlineasm);
|
|
|
|
TEST_CASE(dupfuncname);
|
|
|
|
TEST_CASE(const_and_volatile_functions);
|
|
|
|
TEST_CASE(ifAddBraces1);
|
|
TEST_CASE(ifAddBraces2);
|
|
TEST_CASE(ifAddBraces3);
|
|
TEST_CASE(ifAddBraces4);
|
|
|
|
TEST_CASE(numeric_true_condition);
|
|
|
|
TEST_CASE(simplifyKnownVariables1);
|
|
TEST_CASE(simplifyKnownVariables2);
|
|
TEST_CASE(simplifyKnownVariables3);
|
|
TEST_CASE(simplifyKnownVariables4);
|
|
TEST_CASE(simplifyKnownVariables5);
|
|
|
|
TEST_CASE(multiCompare);
|
|
|
|
TEST_CASE(match1);
|
|
|
|
TEST_CASE(match2);
|
|
|
|
TEST_CASE(varid1);
|
|
TEST_CASE(varid2);
|
|
}
|
|
|
|
|
|
bool cmptok(const char *expected[], const Token *actual)
|
|
{
|
|
unsigned int i = 0;
|
|
for (; expected[i] && actual; ++i, actual = actual->next())
|
|
{
|
|
if (strcmp(expected[i], actual->aaaa()) != 0)
|
|
return false;
|
|
}
|
|
return (expected[i] == NULL && actual == NULL);
|
|
}
|
|
|
|
|
|
std::string tokenizeAndStringify(const char code[])
|
|
{
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
std::ostringstream ostr;
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
{
|
|
ostr << tok->str();
|
|
|
|
// Append newlines
|
|
if (tok->next())
|
|
{
|
|
if (tok->linenr() != tok->next()->linenr())
|
|
{
|
|
for (unsigned int i = tok->linenr();i < tok->next()->linenr();++i)
|
|
ostr << "\n";
|
|
}
|
|
else
|
|
{
|
|
ostr << " ";
|
|
}
|
|
}
|
|
}
|
|
|
|
return ostr.str();
|
|
}
|
|
|
|
|
|
|
|
void longtok()
|
|
{
|
|
std::string filedata(10000, 'a');
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(filedata);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// Expected result..
|
|
ASSERT_EQUALS(std::string(10000, 'a'), std::string(tokenizer.tokens()->aaaa()));
|
|
}
|
|
|
|
|
|
void inlineasm()
|
|
{
|
|
const char filedata[] = "void foo()\n"
|
|
"{\n"
|
|
" __asm\n"
|
|
" {\n"
|
|
" jmp $jump1\n"
|
|
" $jump1:\n"
|
|
" }\n"
|
|
"}\n";
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(filedata);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// Expected result..
|
|
const char *expected[] =
|
|
{
|
|
"void",
|
|
"foo",
|
|
"(",
|
|
")",
|
|
"{",
|
|
"}",
|
|
0
|
|
};
|
|
|
|
// Compare..
|
|
ASSERT_EQUALS(true, cmptok(expected, tokenizer.tokens()));
|
|
}
|
|
|
|
|
|
void dupfuncname()
|
|
{
|
|
const char code[] = "void a()\n"
|
|
"{ }\n"
|
|
"void a(int i)\n"
|
|
"{ }\n"
|
|
"void b()\n"
|
|
"{ }\n";
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
tokenizer.fillFunctionList();
|
|
|
|
ASSERT_EQUALS(1, static_cast<unsigned int>(tokenizer._functionList.size()));
|
|
ASSERT_EQUALS(std::string("b"), tokenizer._functionList[0]->aaaa());
|
|
}
|
|
|
|
void const_and_volatile_functions()
|
|
{
|
|
const char code[] = "class B\n\
|
|
{\n\
|
|
public:\n\
|
|
void a();\n\
|
|
void b() const;\n\
|
|
void c() volatile;\n\
|
|
};\n\
|
|
\n\
|
|
void B::a()\n\
|
|
{}\n\
|
|
\n\
|
|
void B::b() const\n\
|
|
{}\n\
|
|
\n\
|
|
void B::c() volatile\n\
|
|
{}\n";
|
|
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
tokenizer.fillFunctionList();
|
|
|
|
ASSERT_EQUALS(3, static_cast<unsigned int>(tokenizer._functionList.size()));
|
|
if (tokenizer._functionList.size() == 3)
|
|
{
|
|
ASSERT_EQUALS(std::string("a"), tokenizer._functionList[0]->str());
|
|
ASSERT_EQUALS(std::string("b"), tokenizer._functionList[1]->str());
|
|
ASSERT_EQUALS(std::string("c"), tokenizer._functionList[2]->str());
|
|
}
|
|
}
|
|
|
|
|
|
void numeric_true_condition()
|
|
{
|
|
const char code[] = "void f()\n"
|
|
"{\n"
|
|
" if (5==5);\n"
|
|
"}\n";
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
tokenizer.simplifyTokenList();
|
|
|
|
std::ostringstream ostr;
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
ostr << " " << tok->str();
|
|
ASSERT_EQUALS(std::string(" void f ( ) { { ; } }"), ostr.str());
|
|
}
|
|
|
|
void ifAddBraces1()
|
|
{
|
|
const char code[] = "void f()\n"
|
|
"{\n"
|
|
" if (a);\n"
|
|
" else ;\n"
|
|
"}\n";
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
ASSERT_EQUALS(true, tokenizer.simplifyIfAddBraces());
|
|
|
|
std::ostringstream ostr;
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
ostr << " " << tok->str();
|
|
ASSERT_EQUALS(std::string(" void f ( ) { if ( a ) { ; } else { ; } }"), ostr.str());
|
|
}
|
|
|
|
void ifAddBraces2()
|
|
{
|
|
const char code[] = "void f()\n"
|
|
"{\n"
|
|
" if (a) if (b) { }\n"
|
|
"}\n";
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
ASSERT_EQUALS(true, tokenizer.simplifyIfAddBraces());
|
|
|
|
std::ostringstream ostr;
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
ostr << " " << tok->str();
|
|
ASSERT_EQUALS(std::string(" void f ( ) { if ( a ) { if ( b ) { } } }"), ostr.str());
|
|
}
|
|
|
|
void ifAddBraces3()
|
|
{
|
|
const char code[] = "void f()\n"
|
|
"{\n"
|
|
" if (a) for (;;) { }\n"
|
|
"}\n";
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
ASSERT_EQUALS(true, tokenizer.simplifyIfAddBraces());
|
|
|
|
std::ostringstream ostr;
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
ostr << " " << tok->str();
|
|
ASSERT_EQUALS(std::string(" void f ( ) { if ( a ) { for ( ; ; ) { } } }"), ostr.str());
|
|
}
|
|
|
|
void ifAddBraces4()
|
|
{
|
|
const char code[] = "char * foo ()\n"
|
|
"{\n"
|
|
" char *str = malloc(10);\n"
|
|
" if (somecondition)\n"
|
|
" for ( ; ; )\n"
|
|
" { }\n"
|
|
" return str;\n"
|
|
"}\n";
|
|
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
ASSERT_EQUALS(true, tokenizer.simplifyIfAddBraces());
|
|
|
|
std::ostringstream ostr;
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
ostr << " " << tok->str();
|
|
ASSERT_EQUALS(std::string(" char * foo ( ) { char * str = malloc ( 10 ) ; if ( somecondition ) { for ( ; ; ) { } } return str ; }"), ostr.str());
|
|
}
|
|
|
|
void simplifyKnownVariables1()
|
|
{
|
|
const char code[] = "void f()\n"
|
|
"{\n"
|
|
" int a = 10;\n"
|
|
" if (a);\n"
|
|
"}\n";
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
tokenizer.setVarId();
|
|
tokenizer.simplifyKnownVariables();
|
|
|
|
std::ostringstream ostr;
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
ostr << " " << tok->str();
|
|
ASSERT_EQUALS(std::string(" void f ( ) { int a = 10 ; if ( 10 ) ; }"), ostr.str());
|
|
}
|
|
|
|
void simplifyKnownVariables2()
|
|
{
|
|
const char code[] = "void f()\n"
|
|
"{\n"
|
|
" int a = 10;\n"
|
|
" a = g();\n"
|
|
" if (a);\n"
|
|
"}\n";
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
tokenizer.setVarId();
|
|
tokenizer.simplifyKnownVariables();
|
|
|
|
std::ostringstream ostr;
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
ostr << " " << tok->str();
|
|
ASSERT_EQUALS(std::string(" void f ( ) { int a = 10 ; a = g ( ) ; if ( a ) ; }"), ostr.str());
|
|
}
|
|
|
|
void simplifyKnownVariables3()
|
|
{
|
|
const char code[] = "void f()\n"
|
|
"{\n"
|
|
" int a = 4;\n"
|
|
" while(true){\n"
|
|
" break;\n"
|
|
" a = 10;\n"
|
|
" }\n"
|
|
" if (a);\n"
|
|
"}\n";
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
tokenizer.setVarId();
|
|
tokenizer.simplifyKnownVariables();
|
|
|
|
std::ostringstream ostr;
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
ostr << " " << tok->str();
|
|
ASSERT_EQUALS(std::string(" void f ( ) { int a = 4 ; while ( true ) { break ; a = 10 ; } if ( a ) ; }"), ostr.str());
|
|
}
|
|
|
|
void simplifyKnownVariables4()
|
|
{
|
|
const char code[] = "void f()\n"
|
|
"{\n"
|
|
" int a = 4;\n"
|
|
" if ( g(a));\n"
|
|
"}\n";
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
tokenizer.setVarId();
|
|
tokenizer.simplifyKnownVariables();
|
|
|
|
std::ostringstream ostr;
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
ostr << " " << tok->str();
|
|
ASSERT_EQUALS(std::string(" void f ( ) { int a = 4 ; if ( g ( a ) ) ; }"), ostr.str());
|
|
}
|
|
|
|
void simplifyKnownVariables5()
|
|
{
|
|
const char code[] = "void f()\n"
|
|
"{\n"
|
|
" int a = 4;\n"
|
|
" if ( a = 5 );\n"
|
|
"}\n";
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
tokenizer.setVarId();
|
|
tokenizer.simplifyKnownVariables();
|
|
|
|
std::ostringstream ostr;
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
ostr << " " << tok->str();
|
|
ASSERT_EQUALS(std::string(" void f ( ) { int a = 4 ; if ( a = 5 ) ; }"), ostr.str());
|
|
}
|
|
|
|
void multiCompare()
|
|
{
|
|
// Test for found
|
|
ASSERT_EQUALS(1, Token::multiCompare("one|two", "one"));
|
|
ASSERT_EQUALS(1, Token::multiCompare("one|two", "two"));
|
|
ASSERT_EQUALS(1, Token::multiCompare("verybig|two|", "two"));
|
|
|
|
// Test for empty string found
|
|
ASSERT_EQUALS(0, Token::multiCompare("|one|two", "notfound"));
|
|
ASSERT_EQUALS(0, Token::multiCompare("one||two", "notfound"));
|
|
ASSERT_EQUALS(0, Token::multiCompare("one|two|", "notfound"));
|
|
|
|
// Test for not found
|
|
ASSERT_EQUALS(-1, Token::multiCompare("one|two", "notfound"));
|
|
ASSERT_EQUALS(-1, Token::multiCompare("verybig|two", "s"));
|
|
ASSERT_EQUALS(-1, Token::multiCompare("one|two", "ne"));
|
|
ASSERT_EQUALS(-1, Token::multiCompare("abc|def", "a"));
|
|
}
|
|
|
|
void match1()
|
|
{
|
|
// Match "%var% | %var%"
|
|
{
|
|
const std::string code("abc|def");
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// Match..
|
|
ASSERT_EQUALS(true, Token::Match(tokenizer.tokens(), "%var% | %var%"));
|
|
}
|
|
|
|
// Match "%var% || %var%"
|
|
{
|
|
const std::string code("abc||def");
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// Match..
|
|
ASSERT_EQUALS(true, Token::Match(tokenizer.tokens(), "%var% || %var%"));
|
|
}
|
|
}
|
|
|
|
void match2()
|
|
{
|
|
{
|
|
const std::string code("");
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// Match..
|
|
ASSERT_EQUALS(true, Token::Match(tokenizer.tokens(), "!!else"));
|
|
}
|
|
|
|
{
|
|
const std::string code("");
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// Match..
|
|
ASSERT_EQUALS(false, Token::Match(tokenizer.tokens(), "!!else something"));
|
|
}
|
|
|
|
{
|
|
const std::string code("if ;");
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// Match..
|
|
ASSERT_EQUALS(true, Token::Match(tokenizer.tokens(), "!!return if"));
|
|
}
|
|
|
|
{
|
|
const std::string code("if ;");
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// Match..
|
|
ASSERT_EQUALS(true, Token::Match(tokenizer.tokens(), "if ; !!else"));
|
|
}
|
|
|
|
{
|
|
const std::string code("if ; something");
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// Match..
|
|
ASSERT_EQUALS(true, Token::Match(tokenizer.tokens(), "if ; !!else"));
|
|
}
|
|
|
|
{
|
|
const std::string code("else");
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// Match..
|
|
ASSERT_EQUALS(false, Token::Match(tokenizer.tokens(), "!!else"));
|
|
}
|
|
|
|
{
|
|
const std::string code("if ; else");
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
// Match..
|
|
ASSERT_EQUALS(false, Token::Match(tokenizer.tokens(), "if ; !!else"));
|
|
}
|
|
}
|
|
|
|
void varid1()
|
|
{
|
|
const std::string code(";static int i = 1;\n"
|
|
"void f()\n"
|
|
"{\n"
|
|
" int i = 2;\n"
|
|
" for (int i = 0; i < 10; ++i)\n"
|
|
" i = 3;\n"
|
|
" i = 4;\n"
|
|
"}\n");
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.setVarId();
|
|
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
{
|
|
if (tok->str() != "i")
|
|
ASSERT_EQUALS(0, tok->varId());
|
|
else if (Token::Match(tok, "i = 1"))
|
|
ASSERT_EQUALS(1, tok->varId());
|
|
else if (Token::Match(tok, "i = 2"))
|
|
ASSERT_EQUALS(2, tok->varId());
|
|
else if (Token::Match(tok, "i = 3"))
|
|
ASSERT_EQUALS(3, tok->varId());
|
|
else if (Token::Match(tok, "i = 4"))
|
|
ASSERT_EQUALS(2, tok->varId());
|
|
}
|
|
}
|
|
|
|
void varid2()
|
|
{
|
|
const std::string code("void f()\n"
|
|
"{\n"
|
|
" struct ABC abc;\n"
|
|
" abc.a = 3;\n"
|
|
" i = abc.a;\n"
|
|
"}\n");
|
|
|
|
// tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.setVarId();
|
|
|
|
for (const Token *tok = tokenizer.tokens(); tok; tok = tok->next())
|
|
{
|
|
if (tok->str() == "abc")
|
|
ASSERT_EQUALS(1, tok->varId());
|
|
else if (tok->str() == "a")
|
|
ASSERT_EQUALS(2, tok->varId());
|
|
else
|
|
ASSERT_EQUALS(0, tok->varId());
|
|
}
|
|
}
|
|
};
|
|
|
|
REGISTER_TEST(TestTokenizer)
|