334 lines
13 KiB
C++
334 lines
13 KiB
C++
/*
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|
* Copyright (C) 2007-2013 Daniel Marjamäki and Cppcheck team.
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "cppcheck.h"
|
|
#include "settings.h"
|
|
#include "testsuite.h"
|
|
#include "cppcheckexecutor.h"
|
|
#include "threadexecutor.h"
|
|
|
|
#include <sstream>
|
|
|
|
extern std::ostringstream errout;
|
|
|
|
class TestSuppressions : public TestFixture {
|
|
public:
|
|
TestSuppressions() : TestFixture("TestSuppressions") {
|
|
}
|
|
|
|
private:
|
|
|
|
void run() {
|
|
TEST_CASE(suppressionsBadId1);
|
|
TEST_CASE(suppressionsDosFormat); // Ticket #1836
|
|
TEST_CASE(suppressionsFileNameWithColon); // Ticket #1919 - filename includes colon
|
|
TEST_CASE(suppressionsGlob);
|
|
TEST_CASE(suppressionsFileNameWithExtraPath);
|
|
TEST_CASE(suppressionsSettings);
|
|
TEST_CASE(suppressionsMultiFile);
|
|
TEST_CASE(suppressionsPathSeparator);
|
|
|
|
TEST_CASE(inlinesuppress_unusedFunction); // #4210 - unusedFunction
|
|
}
|
|
|
|
void suppressionsBadId1() const {
|
|
Suppressions suppressions;
|
|
std::istringstream s1("123");
|
|
ASSERT_EQUALS("Failed to add suppression. Invalid id \"123\"", suppressions.parseFile(s1));
|
|
|
|
std::istringstream s2("obsoleteFunctionsrand_r");
|
|
ASSERT_EQUALS("", suppressions.parseFile(s2));
|
|
}
|
|
|
|
void suppressionsDosFormat() const {
|
|
Suppressions suppressions;
|
|
std::istringstream s("abc\r\ndef\r\n");
|
|
ASSERT_EQUALS("", suppressions.parseFile(s));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("abc", "test.cpp", 1));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("def", "test.cpp", 1));
|
|
}
|
|
|
|
void suppressionsFileNameWithColon() const {
|
|
Suppressions suppressions;
|
|
std::istringstream s("errorid:c:\\foo.cpp\nerrorid:c:\\bar.cpp:12");
|
|
ASSERT_EQUALS("", suppressions.parseFile(s));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("errorid", "c:/foo.cpp", 1111));
|
|
ASSERT_EQUALS(false, suppressions.isSuppressed("errorid", "c:/bar.cpp", 10));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("errorid", "c:/bar.cpp", 12));
|
|
}
|
|
|
|
void suppressionsGlob() const {
|
|
// Check for syntax errors in glob
|
|
{
|
|
Suppressions suppressions;
|
|
std::istringstream s("errorid:**.cpp\n");
|
|
ASSERT_EQUALS("Failed to add suppression. Syntax error in glob.", suppressions.parseFile(s));
|
|
}
|
|
|
|
// Check that globbing works
|
|
{
|
|
Suppressions suppressions;
|
|
std::istringstream s("errorid:x*.cpp\nerrorid:y?.cpp\nerrorid:test.c*");
|
|
ASSERT_EQUALS("", suppressions.parseFile(s));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("errorid", "xyz.cpp", 1));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("errorid", "xyz.cpp.cpp", 1));
|
|
ASSERT_EQUALS(false, suppressions.isSuppressed("errorid", "abc.cpp", 1));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("errorid", "ya.cpp", 1));
|
|
ASSERT_EQUALS(false, suppressions.isSuppressed("errorid", "y.cpp", 1));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("errorid", "test.c", 1));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("errorid", "test.cpp", 1));
|
|
}
|
|
|
|
// Check that both a filename match and a glob match apply
|
|
{
|
|
Suppressions suppressions;
|
|
std::istringstream s("errorid:x*.cpp\nerrorid:xyz.cpp:1\nerrorid:a*.cpp:1\nerrorid:abc.cpp:2");
|
|
ASSERT_EQUALS("", suppressions.parseFile(s));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("errorid", "xyz.cpp", 1));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("errorid", "xyz.cpp", 2));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("errorid", "abc.cpp", 1));
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("errorid", "abc.cpp", 2));
|
|
}
|
|
}
|
|
|
|
void suppressionsFileNameWithExtraPath() const {
|
|
// Ticket #2797
|
|
Suppressions suppressions;
|
|
suppressions.addSuppression("errorid", "./a.c", 123);
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("errorid", "a.c", 123));
|
|
}
|
|
|
|
// Check the suppression
|
|
void checkSuppression(const char code[], const std::string &suppression = "") {
|
|
// Clear the error log
|
|
errout.str("");
|
|
|
|
CppCheck cppCheck(*this, true);
|
|
Settings& settings = cppCheck.settings();
|
|
settings._inlineSuppressions = true;
|
|
settings.addEnabled("information");
|
|
if (!suppression.empty()) {
|
|
std::string r = settings.nomsg.addSuppressionLine(suppression);
|
|
ASSERT_EQUALS("", r);
|
|
}
|
|
|
|
cppCheck.check("test.cpp", code);
|
|
|
|
reportUnmatchedSuppressions(settings.nomsg.getUnmatchedGlobalSuppressions());
|
|
}
|
|
|
|
void checkSuppressionThreads(const char code[], const std::string &suppression = "") {
|
|
errout.str("");
|
|
output.str("");
|
|
|
|
std::map<std::string, std::size_t> files;
|
|
files["test.cpp"] = 1;
|
|
|
|
Settings settings;
|
|
settings._jobs = 1;
|
|
settings._inlineSuppressions = true;
|
|
settings.addEnabled("information");
|
|
if (!suppression.empty()) {
|
|
ASSERT_EQUALS("", settings.nomsg.addSuppressionLine(suppression));
|
|
}
|
|
ThreadExecutor executor(files, settings, *this);
|
|
for (std::map<std::string, std::size_t>::const_iterator i = files.begin(); i != files.end(); ++i)
|
|
executor.addFileContent(i->first, code);
|
|
|
|
executor.check();
|
|
|
|
reportUnmatchedSuppressions(settings.nomsg.getUnmatchedGlobalSuppressions());
|
|
}
|
|
|
|
// Check the suppression for multiple files
|
|
void checkSuppression(const char *names[], const char *codes[], const std::string &suppression = "") {
|
|
// Clear the error log
|
|
errout.str("");
|
|
|
|
CppCheck cppCheck(*this, true);
|
|
Settings& settings = cppCheck.settings();
|
|
settings._inlineSuppressions = true;
|
|
settings.addEnabled("information");
|
|
if (!suppression.empty())
|
|
settings.nomsg.addSuppressionLine(suppression);
|
|
|
|
for (int i = 0; names[i] != NULL; ++i)
|
|
cppCheck.check(names[i], codes[i]);
|
|
|
|
reportUnmatchedSuppressions(settings.nomsg.getUnmatchedGlobalSuppressions());
|
|
}
|
|
|
|
void runChecks(void (TestSuppressions::*check)(const char[], const std::string &)) {
|
|
// check to make sure the appropriate error is present
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" a++;\n"
|
|
"}\n",
|
|
"");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: a\n", errout.str());
|
|
|
|
// suppress uninitvar globally
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" a++;\n"
|
|
"}\n",
|
|
"uninitvar");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// suppress uninitvar globally, without error present
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" b++;\n"
|
|
"}\n",
|
|
"uninitvar");
|
|
ASSERT_EQUALS("[*]: (information) Unmatched suppression: uninitvar\n", errout.str());
|
|
|
|
// suppress uninitvar for this file only
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" a++;\n"
|
|
"}\n",
|
|
"uninitvar:test.cpp");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// suppress uninitvar for this file only, without error present
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" b++;\n"
|
|
"}\n",
|
|
"uninitvar:test.cpp");
|
|
ASSERT_EQUALS("[test.cpp]: (information) Unmatched suppression: uninitvar\n", errout.str());
|
|
|
|
// suppress all for this file only
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" a++;\n"
|
|
"}\n",
|
|
"*:test.cpp");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// suppress all for this file only, without error present
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" b++;\n"
|
|
"}\n",
|
|
"*:test.cpp");
|
|
ASSERT_EQUALS("[test.cpp]: (information) Unmatched suppression: *\n", errout.str());
|
|
|
|
// suppress uninitvar for this file and line
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" a++;\n"
|
|
"}\n",
|
|
"uninitvar:test.cpp:3");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// suppress uninitvar for this file and line, without error present
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" b++;\n"
|
|
"}\n",
|
|
"uninitvar:test.cpp:3");
|
|
ASSERT_EQUALS("[test.cpp:3]: (information) Unmatched suppression: uninitvar\n", errout.str());
|
|
|
|
// suppress uninitvar inline
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" // cppcheck-suppress uninitvar\n"
|
|
" a++;\n"
|
|
"}\n",
|
|
"");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// suppress uninitvar inline
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" // cppcheck-suppress uninitvar\n"
|
|
"\n"
|
|
" a++;\n"
|
|
"}\n",
|
|
"");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// suppress uninitvar inline
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" /* cppcheck-suppress uninitvar */\n"
|
|
" a++;\n"
|
|
"}\n",
|
|
"");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// suppress uninitvar inline
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" /* cppcheck-suppress uninitvar */\n"
|
|
"\n"
|
|
" a++;\n"
|
|
"}\n",
|
|
"");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// suppress uninitvar inline, without error present
|
|
(this->*check)("void f() {\n"
|
|
" int a;\n"
|
|
" // cppcheck-suppress uninitvar\n"
|
|
" b++;\n"
|
|
"}\n",
|
|
"");
|
|
ASSERT_EQUALS("[test.cpp:4]: (information) Unmatched suppression: uninitvar\n", errout.str());
|
|
}
|
|
|
|
void suppressionsSettings() {
|
|
runChecks(&TestSuppressions::checkSuppression);
|
|
if (ThreadExecutor::isEnabled())
|
|
runChecks(&TestSuppressions::checkSuppressionThreads);
|
|
}
|
|
|
|
void suppressionsMultiFile() {
|
|
const char *names[] = {"abc.cpp", "xyz.cpp", NULL};
|
|
const char *codes[] = {
|
|
"void f() {\n"
|
|
"}\n",
|
|
"void f() {\n"
|
|
" int a;\n"
|
|
" a++;\n"
|
|
"}\n",
|
|
};
|
|
|
|
// suppress uninitvar for this file and line
|
|
checkSuppression(names, codes, "uninitvar:xyz.cpp:3");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void suppressionsPathSeparator() const {
|
|
Suppressions suppressions;
|
|
suppressions.addSuppressionLine("*:test\\*");
|
|
ASSERT_EQUALS(true, suppressions.isSuppressed("someid", "test/foo/bar.cpp", 142));
|
|
}
|
|
|
|
void inlinesuppress_unusedFunction() const { // #4210 - wrong report of "unmatchedSuppression" for "unusedFunction"
|
|
Suppressions suppressions;
|
|
suppressions.addSuppression("unusedFunction", "test.c", 3U);
|
|
ASSERT_EQUALS(true, suppressions.getUnmatchedLocalSuppressions("test.c").empty());
|
|
ASSERT_EQUALS(false, suppressions.getUnmatchedGlobalSuppressions().empty());
|
|
}
|
|
};
|
|
|
|
REGISTER_TEST(TestSuppressions)
|