Change the astStringVerbose() recursion to extend a string instead of returning one. This has the benefit that for tokens where the recursion runs deep (typically large arrays), the time savings can be substantial (see comments on benchmarks further down). The reason is that previously, for each token, the astString of its operands was constructed, and then appended to this tokens astString. This led to a lot of unnecessary string copying (and with that allocations). Instead, by passing the string by reference, the number of temporary strings is greatly reduced. Another way of seeing it is that previously, the string was constructed from end to beginning, but now it is constructed from the beginning to end. There was no notable speedup by preallocating the entire string using string::reserve() (at least not on Linux). To benchmark, the changes and master were tested on Linux using the commands: make time cppcheck --debug --verbose $file >/dev/null i.e., the cppcheck binary was compiled with the settings in the Makefile. Printing the output to screen or file will of course take longer time. In Trac ticket #8355 which triggered this change, an example file from the Wine repository was attached. Running the above cppcheck on master took 24 minutes and with the changes in this commmit, took 22 seconds. Another test made was on lib/tokenlist.cpp in the cppcheck repo, which is more "normal" file. On that file there was no measurable time difference. A synthetic benchmark was generated to illustrate the effects on dumping the ast for arrays of different sizes. The generate code looked as follows: const int array[] = {...}; with different number of elements. The results are as follows (times are in seconds): N master optimized 10 0.1 0.1 100 0.1 0.1 1000 2.8 0.7 2000 19 1.8 3000 53 3.8 5000 350 10 10000 3215 38 As we can see, for small arrays, there is no time difference, but for large arrays the time savings are substantial. |
||
---|---|---|
Cppcheck.xcodeproj | ||
addons | ||
cfg | ||
cli | ||
cmake | ||
cve-test-suite | ||
democlient | ||
externals | ||
gui | ||
htmlreport | ||
lib | ||
man | ||
oss-fuzz | ||
platforms | ||
rules | ||
samples | ||
snap | ||
test | ||
tools | ||
win_installer | ||
.astylerc | ||
.codacy.yml | ||
.gitignore | ||
.mailmap | ||
.travis.yml | ||
.travis_llvmcheck_suppressions | ||
.travis_suppressions | ||
AUTHORS | ||
CMakeLists.txt | ||
COPYING | ||
Makefile | ||
appveyor.yml | ||
benchmarks.txt | ||
build-pcre.txt | ||
build.bat | ||
console_common.pri | ||
cppcheck-errors.rng | ||
cppcheck.cbp | ||
cppcheck.cppcheck | ||
cppcheck.sln | ||
createrelease | ||
doxyfile | ||
generate_coverage_report | ||
philosophy.md | ||
readme.md | ||
readme.txt | ||
readmeja.md | ||
requirements.txt | ||
runastyle | ||
runastyle.bat | ||
webreport.sh |
readme.md
Cppcheck
Linux Build Status | Windows Build Status | Coverity Scan Build Status |
---|---|---|
Donations
If you find Cppcheck useful for you, feel free to make a donation.
About the name
The original name of this program was "C++check", but it was later changed to "Cppcheck".
Despite the name, Cppcheck is designed for both C and C++.
Manual
A manual is available online.
Compiling
Any C++11 compiler should work. For compilers with partial C++11 support it may work. If your compiler has the C++11 features that are available in Visual Studio 2013 / GCC 4.6 then it will work.
To build the GUI, you need Qt.
When building the command line tool, PCRE is optional. It is used if you build with rules.
There are multiple compilation choices:
- qmake - cross platform build tool
- cmake - cross platform build tool
- Windows: Visual Studio (VS 2013 and above)
- Windows: Qt Creator + mingw
- gnu make
- g++ 4.6 (or later)
- clang++
qmake
You can use the gui/gui.pro file to build the GUI.
cd gui
qmake
make
Visual Studio
Use the cppcheck.sln file. The file is configured for Visual Studio 2015, but the platform toolset can be changed easily to older or newer versions. The solution contains platform targets for both x86 and x64.
To compile with rules, select "Release-PCRE" or "Debug-PCRE" configuration. pcre.lib (pcre64.lib for x64 builds) and pcre.h are expected to be in /externals then.
Qt Creator + MinGW
The PCRE dll is needed to build the CLI. It can be downloaded here: http://software-download.name/pcre-library-windows/
GNU make
Simple, unoptimized build (no dependencies):
make
The recommended release build is:
make SRCDIR=build CFGDIR=cfg HAVE_RULES=yes CXXFLAGS="-O2 -DNDEBUG -Wall -Wno-sign-compare -Wno-unused-function"
Flags:
-
SRCDIR=build
Python is used to optimise cppcheck -
CFGDIR=cfg
Specify folder where .cfg files are found -
HAVE_RULES=yes
Enable rules (PCRE is required if this is used) -
CXXFLAGS="-O2 -DNDEBUG -Wall -Wno-sign-compare -Wno-unused-function"
Enables most compiler optimizations, disables cppcheck-internal debugging code and enables basic compiler warnings.
g++ (for experts)
If you just want to build Cppcheck without dependencies then you can use this command:
g++ -o cppcheck -std=c++11 -Iexternals/simplecpp -Iexternals/tinyxml -Ilib cli/*.cpp lib/*.cpp externals/simplecpp/simplecpp.cpp externals/tinyxml/*.cpp
If you want to use --rule
and --rule-file
then dependencies are needed:
g++ -o cppcheck -std=c++11 -lpcre -DHAVE_RULES -Ilib -Iexternals/simplecpp -Iexternals/tinyxml cli/*.cpp lib/*.cpp externals/simplecpp/simplecpp.cpp externals/tinyxml/*.cpp
MinGW
mingw32-make LDFLAGS=-lshlwapi
Other Compiler/IDE
- Create a empty project file / makefile.
- Add all cpp files in the cppcheck cli and lib folders to the project file / makefile.
- Add all cpp files in the externals folders to the project file / makefile.
- Compile.
Cross compiling Win32 (CLI) version of Cppcheck in Linux
sudo apt-get install mingw32
make CXX=i586-mingw32msvc-g++ LDFLAGS="-lshlwapi" RDYNAMIC=""
mv cppcheck cppcheck.exe