130 lines
4.6 KiB
C++
130 lines
4.6 KiB
C++
/*
|
|
* cppcheck - c/c++ syntax checking
|
|
* Copyright (C) 2007-2009 Daniel Marjamäki, Reijo Tomperi, Nicolas Le Cam
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/
|
|
*/
|
|
|
|
|
|
|
|
#define UNIT_TESTING
|
|
#include "tokenize.h"
|
|
#include "checkclass.h"
|
|
#include "testsuite.h"
|
|
#include <sstream>
|
|
|
|
extern std::ostringstream errout;
|
|
|
|
class TestClass : public TestFixture
|
|
{
|
|
public:
|
|
TestClass() : TestFixture("TestClass")
|
|
{ }
|
|
|
|
private:
|
|
|
|
void run()
|
|
{
|
|
TEST_CASE(virtualDestructor1); // Base class not found => no error
|
|
TEST_CASE(virtualDestructor2); // Base class doesn't have a destructor
|
|
TEST_CASE(virtualDestructor3); // Base class has a destructor, but it's not virtual
|
|
TEST_CASE(virtualDestructor4); // Derived class doesn't have a destructor => no error
|
|
TEST_CASE(virtualDestructor5); // Derived class has empty destructor => no error
|
|
}
|
|
|
|
// Check that base classes have virtual destructors
|
|
void checkVirtualDestructor(const char code[])
|
|
{
|
|
// Tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.simplifyTokenList();
|
|
|
|
// Clear the error log
|
|
errout.str("");
|
|
|
|
// Check..
|
|
Settings settings;
|
|
CheckClass checkClass(&tokenizer, settings, this);
|
|
checkClass.virtualDestructor();
|
|
}
|
|
|
|
|
|
void virtualDestructor1()
|
|
{
|
|
// Base class not found
|
|
|
|
checkVirtualDestructor("class Derived : public Base { };");
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
|
|
checkVirtualDestructor("class Derived : Base { };");
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
}
|
|
|
|
void virtualDestructor2()
|
|
{
|
|
// Base class doesn't have a destructor
|
|
|
|
checkVirtualDestructor("class Base { };\n"
|
|
"class Derived : public Base { public: ~Derived() { (void)11; } };");
|
|
ASSERT_EQUALS(std::string("[test.cpp:1]: Class Base which is inherited by class Derived does not have a virtual destructor\n"), errout.str());
|
|
|
|
checkVirtualDestructor("class Base { };\n"
|
|
"class Derived : Base { public: ~Derived() { (void)11; } };");
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
}
|
|
|
|
void virtualDestructor3()
|
|
{
|
|
// Base class has a destructor, but it's not virtual
|
|
|
|
checkVirtualDestructor("class Base { public: ~Base(); };\n"
|
|
"class Derived : public Base { public: ~Derived() { (void)11; } };");
|
|
ASSERT_EQUALS(std::string("[test.cpp:1]: Class Base which is inherited by class Derived does not have a virtual destructor\n"), errout.str());
|
|
|
|
checkVirtualDestructor("class Base { public: ~Base(); };\n"
|
|
"class Derived : private Fred, public Base { public: ~Derived() { (void)11; } };");
|
|
ASSERT_EQUALS(std::string("[test.cpp:1]: Class Base which is inherited by class Derived does not have a virtual destructor\n"), errout.str());
|
|
}
|
|
|
|
void virtualDestructor4()
|
|
{
|
|
// Derived class doesn't have a destructor => no error
|
|
|
|
checkVirtualDestructor("class Base { public: ~Base(); };\n"
|
|
"class Derived : public Base { };");
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
|
|
checkVirtualDestructor("class Base { public: ~Base(); };\n"
|
|
"class Derived : private Fred, public Base { };");
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
}
|
|
|
|
void virtualDestructor5()
|
|
{
|
|
// Derived class has empty destructor => no error
|
|
|
|
checkVirtualDestructor("class Base { public: ~Base(); };\n"
|
|
"class Derived : public Base { public: ~Derived() {} };");
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
|
|
checkVirtualDestructor("class Base { public: ~Base(); };\n"
|
|
"class Derived : public Base { public: ~Derived(); }; Derived::~Derived() {}");
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
}
|
|
};
|
|
|
|
REGISTER_TEST(TestClass)
|