1594 lines
56 KiB
C++
1594 lines
56 KiB
C++
/*
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|
* Copyright (C) 2007-2011 Daniel Marjamäki and Cppcheck team.
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
|
|
|
|
#include "tokenize.h"
|
|
#include "checkstl.h"
|
|
#include "testsuite.h"
|
|
#include <sstream>
|
|
|
|
extern std::ostringstream errout;
|
|
|
|
class TestStl : public TestFixture {
|
|
public:
|
|
TestStl() : TestFixture("TestStl")
|
|
{ }
|
|
|
|
private:
|
|
void run() {
|
|
TEST_CASE(iterator1);
|
|
TEST_CASE(iterator2);
|
|
TEST_CASE(iterator3);
|
|
TEST_CASE(iterator4);
|
|
TEST_CASE(iterator5);
|
|
TEST_CASE(iterator6);
|
|
TEST_CASE(iterator7);
|
|
TEST_CASE(iterator8);
|
|
TEST_CASE(iterator9);
|
|
TEST_CASE(iterator10);
|
|
TEST_CASE(iterator11);
|
|
|
|
TEST_CASE(dereference);
|
|
TEST_CASE(dereference_member);
|
|
|
|
TEST_CASE(STLSize);
|
|
TEST_CASE(STLSizeNoErr);
|
|
TEST_CASE(erase1);
|
|
TEST_CASE(erase2);
|
|
TEST_CASE(erase3);
|
|
TEST_CASE(erase4);
|
|
TEST_CASE(erase5);
|
|
TEST_CASE(erase6);
|
|
TEST_CASE(eraseBreak);
|
|
TEST_CASE(eraseContinue);
|
|
TEST_CASE(eraseReturn1);
|
|
TEST_CASE(eraseReturn2);
|
|
TEST_CASE(eraseReturn3);
|
|
TEST_CASE(eraseGoto);
|
|
TEST_CASE(eraseAssign1);
|
|
TEST_CASE(eraseAssign2);
|
|
TEST_CASE(eraseErase);
|
|
TEST_CASE(eraseByValue);
|
|
|
|
TEST_CASE(pushback1);
|
|
TEST_CASE(pushback2);
|
|
TEST_CASE(pushback3);
|
|
TEST_CASE(pushback4);
|
|
TEST_CASE(pushback5);
|
|
TEST_CASE(pushback6);
|
|
TEST_CASE(pushback7);
|
|
TEST_CASE(pushback8);
|
|
TEST_CASE(pushback9);
|
|
TEST_CASE(pushback10);
|
|
TEST_CASE(pushback11);
|
|
|
|
TEST_CASE(insert1);
|
|
TEST_CASE(insert2);
|
|
|
|
TEST_CASE(invalidcode);
|
|
|
|
TEST_CASE(stlBoundries1);
|
|
TEST_CASE(stlBoundries2);
|
|
TEST_CASE(stlBoundries3);
|
|
|
|
// if (str.find("ab"))
|
|
TEST_CASE(if_find);
|
|
TEST_CASE(if_str_find);
|
|
|
|
TEST_CASE(size1);
|
|
TEST_CASE(size2);
|
|
|
|
// Redundant conditions..
|
|
// if (ints.find(123) != ints.end()) ints.remove(123);
|
|
TEST_CASE(redundantCondition1);
|
|
TEST_CASE(redundantCondition2);
|
|
|
|
// missing inner comparison when incrementing iterator inside loop
|
|
TEST_CASE(missingInnerComparison1);
|
|
TEST_CASE(missingInnerComparison2); // no FP when there is comparison
|
|
TEST_CASE(missingInnerComparison3); // no FP when there is iterator shadowing
|
|
TEST_CASE(missingInnerComparison4); // no FP when "break;" is used
|
|
TEST_CASE(missingInnerComparison5); // Ticket #2154 - FP
|
|
TEST_CASE(missingInnerComparison6); // #2643 - 'it=foo.insert(++it,0);'
|
|
|
|
// catch common problems when using the string::c_str() function
|
|
TEST_CASE(cstr);
|
|
|
|
TEST_CASE(autoPointer);
|
|
|
|
TEST_CASE(uselessCalls);
|
|
|
|
}
|
|
|
|
void check(const std::string &code, const bool inconclusive=false) {
|
|
// Clear the error buffer..
|
|
errout.str("");
|
|
|
|
Settings settings;
|
|
settings.addEnabled("style");
|
|
settings.addEnabled("performance");
|
|
settings.inconclusive = inconclusive;
|
|
|
|
// Tokenize..
|
|
Tokenizer tokenizer(&settings, this);
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.simplifyTokenList();
|
|
|
|
// Check..
|
|
CheckStl checkStl;
|
|
checkStl.runSimplifiedChecks(&tokenizer, &settings, this);
|
|
}
|
|
|
|
|
|
void iterator1() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" list<int> l1;\n"
|
|
" list<int> l2;\n"
|
|
" for (list<int>::iterator it = l1.begin(); it != l2.end(); ++it)\n"
|
|
" { }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Same iterator is used with both l1 and l2\n", errout.str());
|
|
|
|
// Same check with reverse iterator
|
|
check("void f()\n"
|
|
"{\n"
|
|
" list<int> l1;\n"
|
|
" list<int> l2;\n"
|
|
" for (list<int>::const_reverse_iterator it = l1.rbegin(); it != l2.rend(); ++it)\n"
|
|
" { }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Same iterator is used with both l1 and l2\n", errout.str());
|
|
}
|
|
|
|
void iterator2() {
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" list<int> l1;\n"
|
|
" list<int> l2;\n"
|
|
" list<int>::iterator it = l1.begin();\n"
|
|
" while (it != l2.end())\n"
|
|
" {\n"
|
|
" ++it;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Same iterator is used with both l1 and l2\n", errout.str());
|
|
}
|
|
|
|
void iterator3() {
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" list<int> l1;\n"
|
|
" list<int> l2;\n"
|
|
" list<int>::iterator it = l1.begin();\n"
|
|
" l2.insert(it, 0);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Same iterator is used with both l1 and l2\n", errout.str());
|
|
}
|
|
|
|
void iterator4() {
|
|
check("void foo(std::vector<std::string> &test)\n"
|
|
"{\n"
|
|
" std::set<int> result;\n"
|
|
" for (std::vector<std::string>::const_iterator cit = test.begin();\n"
|
|
" cit != test.end();\n"
|
|
" ++cit)\n"
|
|
" {\n"
|
|
" result.insert(cit->size());\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void iterator5() {
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector<int> ints1;\n"
|
|
" std::vector<int> ints2;\n"
|
|
" std::vector<int>::iterator it = std::find(ints1.begin(), ints2.end(), 22);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) mismatching containers\n", errout.str());
|
|
}
|
|
|
|
void iterator6() {
|
|
// Ticket #1357
|
|
check("void foo(const std::set<int> &ints1)\n"
|
|
"{\n"
|
|
" std::set<int> ints2;\n"
|
|
" std::set<int>::iterator it1 = ints1.begin();\n"
|
|
" std::set<int>::iterator it2 = ints1.end();\n"
|
|
" ints2.insert(it1, it2);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void foo(const std::set<int> &ints1)\n"
|
|
"{\n"
|
|
" std::set<int> ints2;\n"
|
|
" std::set<int>::iterator it1 = ints1.begin();\n"
|
|
" std::set<int>::iterator it2 = ints2.end();\n"
|
|
" ints2.insert(it1, it2);\n"
|
|
"}\n");
|
|
TODO_ASSERT_EQUALS("error", "", errout.str());
|
|
}
|
|
|
|
void iterator7() {
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector<int> ints1;\n"
|
|
" std::vector<int> ints2;\n"
|
|
" std::vector<int>::iterator it = std::inplace_merge(ints1.begin(), std:.advance(ints1.rbegin(), 5), ints2.end());\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) mismatching containers\n", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector<int> ints1;\n"
|
|
" std::vector<int> ints2;\n"
|
|
" std::vector<int>::iterator it = std::inplace_merge(ints1.begin(), std::advance(ints2.rbegin(), 5), ints1.end());\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void iterator8() {
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector<int> ints1;\n"
|
|
" std::vector<int> ints2;\n"
|
|
" std::vector<int>::iterator it = std::find_first_of(ints1.begin(), ints2.end(), ints1.begin(), ints1.end());\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) mismatching containers\n", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector<int> ints1;\n"
|
|
" std::vector<int> ints2;\n"
|
|
" std::vector<int>::iterator it = std::find_first_of(ints1.begin(), ints1.end(), ints2.begin(), ints1.end());\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) mismatching containers\n", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector<int> ints1;\n"
|
|
" std::vector<int> ints2;\n"
|
|
" std::vector<int>::iterator it = std::find_first_of(ints1.begin(), ints1.end(), ints2.begin(), ints2.end());\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void iterator9() {
|
|
// Ticket #1600
|
|
check("void foo(std::vector<int> &r)\n"
|
|
"{\n"
|
|
" std::vector<int>::iterator aI = r.begin();\n"
|
|
" while(aI != r.end())\n"
|
|
" {\n"
|
|
" if (*aI == 0)\n"
|
|
" {\n"
|
|
" r.insert(aI, 42);\n"
|
|
" return;\n"
|
|
" }\n"
|
|
" ++aI;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// Ticket #2481
|
|
check("void foo(std::vector<int> &r)\n"
|
|
"{\n"
|
|
" std::vector<int>::iterator aI = r.begin();\n"
|
|
" while(aI != r.end())\n"
|
|
" {\n"
|
|
" if (*aI == 0)\n"
|
|
" {\n"
|
|
" r.insert(aI, 42);\n"
|
|
" break;\n"
|
|
" }\n"
|
|
" ++aI;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// Execution path checking..
|
|
check("void foo(std::vector<int> &r, int c)\n"
|
|
"{\n"
|
|
" std::vector<int>::iterator aI = r.begin();\n"
|
|
" while(aI != r.end())\n"
|
|
" {\n"
|
|
" if (*aI == 0)\n"
|
|
" {\n"
|
|
" r.insert(aI, 42);\n"
|
|
" if (c)\n"
|
|
" {\n"
|
|
" return;\n"
|
|
" }\n"
|
|
" }\n"
|
|
" ++aI;\n"
|
|
" }\n"
|
|
"}\n");
|
|
TODO_ASSERT_EQUALS("[test.cpp:14] (error) After insert, the iterator 'aI' may be invalid", "", errout.str());
|
|
}
|
|
|
|
void iterator10() {
|
|
// Ticket #1679
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::set<int> s1;\n"
|
|
" std::set<int> s2;\n"
|
|
" for (std::set<int>::iterator it = s1.begin(); it != s1.end(); ++it)\n"
|
|
" {\n"
|
|
" if (true) { }\n"
|
|
" if (it != s2.end()) continue;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (error) Same iterator is used with both s1 and s2\n", errout.str());
|
|
}
|
|
|
|
void iterator11() {
|
|
// Ticket #3433
|
|
check("int main() {\n"
|
|
" map<int, int> myMap;\n"
|
|
" vector<string> myVector;\n"
|
|
" for(vector<int>::iterator x = myVector.begin(); x != myVector.end(); x++)\n"
|
|
" myMap.erase(*x);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
// Dereferencing invalid pointer
|
|
void dereference() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> ints;\n"
|
|
" std::vector<int>::iterator iter;\n"
|
|
" iter = ints.begin() + 2;\n"
|
|
" ints.erase(iter);\n"
|
|
" std::cout << (*iter) << std::endl;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:7]: (error) Dereferenced iterator 'iter' has been erased\n", errout.str());
|
|
}
|
|
|
|
void dereference_member() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::map<int, int> ints;\n"
|
|
" std::map<int, int>::iterator iter;\n"
|
|
" iter = ints.begin();\n"
|
|
" ints.erase(iter);\n"
|
|
" std::cout << iter->first << std::endl;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:7]: (error) Dereferenced iterator 'iter' has been erased\n", errout.str());
|
|
|
|
// Reverse iterator
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::map<int, int> ints;\n"
|
|
" std::map<int, int>::reverse_iterator iter;\n"
|
|
" iter = ints.rbegin();\n"
|
|
" ints.erase(iter);\n"
|
|
" std::cout << iter->first << std::endl;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:7]: (error) Dereferenced iterator 'iter' has been erased\n", errout.str());
|
|
}
|
|
|
|
|
|
void STLSize() {
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector<int> foo;\n"
|
|
" for (unsigned int ii = 0; ii <= foo.size(); ++ii)\n"
|
|
" {\n"
|
|
" foo[ii] = 0;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) When ii==foo.size(), foo[ii] is out of bounds\n", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector<int> foo;\n"
|
|
" foo.push_back(1);\n"
|
|
" for (unsigned int ii = 0; ii <= foo.size(); ++ii)\n"
|
|
" {\n"
|
|
" }\n"
|
|
" int ii = 0;\n"
|
|
" foo[ii] = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void STLSizeNoErr() {
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector<int> foo;\n"
|
|
" for (unsigned int ii = 0; ii < foo.size(); ++ii)\n"
|
|
" {\n"
|
|
" foo[ii] = 0;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector<int> foo;\n"
|
|
" for (unsigned int ii = 0; ii <= foo.size(); ++ii)\n"
|
|
" {\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
{
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector<int> foo;\n"
|
|
" for (unsigned int ii = 0; ii <= foo.size(); ++ii)\n"
|
|
" {\n"
|
|
" if (ii == foo.size())\n"
|
|
" {\n"
|
|
" }\n"
|
|
" else\n"
|
|
" {\n"
|
|
" foo[ii] = 0;\n"
|
|
" }\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
void erase1() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" for (it = foo.begin(); it != foo.end(); ++it) {\n"
|
|
" foo.erase(it);\n"
|
|
" }\n"
|
|
" for (it = foo.begin(); it != foo.end(); ++it) {\n"
|
|
" foo.erase(it);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Dangerous iterator usage after erase()-method.\n"
|
|
"[test.cpp:7]: (error) Dangerous iterator usage after erase()-method.\n", errout.str());
|
|
|
|
check("void f(std::list<int> &ints)\n"
|
|
"{\n"
|
|
" std::list<int>::iterator i = ints.begin();\n"
|
|
" i = ints.erase(i);\n"
|
|
" *i = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// #2101
|
|
check("void f(vector< list<int> > &ints, unsigned int i)\n"
|
|
"{\n"
|
|
" list<int>::iterator it;\n"
|
|
" for(it = ints[i].begin(); it != ints[i].end(); it++) {\n"
|
|
" if (*it % 2)\n"
|
|
" it = ints[i].erase(it);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void erase2() {
|
|
check("static void f()\n"
|
|
"{\n"
|
|
" for (iterator it = foo.begin(); it != foo.end(); it = next)\n"
|
|
" {\n"
|
|
" next = it;\n"
|
|
" next++;\n"
|
|
" foo.erase(it);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void erase3() {
|
|
check("static void f(std::list<abc> &foo)\n"
|
|
"{\n"
|
|
" std::list<abc>::iterator it = foo.begin();\n"
|
|
" foo.erase(it->a);\n"
|
|
" if (it->b);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void erase4() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int>::iterator it, it2;\n"
|
|
" for (it = foo.begin(); it != i2; ++it)\n"
|
|
" {\n"
|
|
" foo.erase(it);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Dangerous iterator usage after erase()-method.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int>::iterator it = foo.begin();\n"
|
|
" for (; it != i2; ++it)\n"
|
|
" {\n"
|
|
" foo.erase(it);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Dangerous iterator usage after erase()-method.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int>::iterator it = foo.begin();\n"
|
|
" while (it != i2)\n"
|
|
" {\n"
|
|
" foo.erase(it);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Dangerous iterator usage after erase()-method.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int>::iterator it = foo.begin();\n"
|
|
" while (it != i2)\n"
|
|
" {\n"
|
|
" foo.erase(++it);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Dangerous iterator usage after erase()-method.\n", errout.str());
|
|
}
|
|
|
|
void erase5() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int> foo;\n"
|
|
" std::list<int>::iterator it;\n"
|
|
" for (it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" if (*it == 123)\n"
|
|
" foo.erase(it);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (error) Dangerous iterator usage after erase()-method.\n", errout.str());
|
|
}
|
|
|
|
void erase6() {
|
|
check("void f() {\n"
|
|
" std::vector<int> vec(3);\n"
|
|
" std::vector<int>::iterator it;\n"
|
|
" std::vector<int>::iterator itEnd = vec.end();\n"
|
|
" for (it = vec.begin(); it != itEnd; it = vec.begin(), itEnd = vec.end())\n"
|
|
" {\n"
|
|
" vec.erase(it);\n"
|
|
" }\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void eraseBreak() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" for (iterator it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" foo.erase(it);\n"
|
|
" if (x)"
|
|
" break;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Dangerous iterator usage after erase()-method.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" for (iterator it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" if (x) {\n"
|
|
" foo.erase(it);\n"
|
|
" break;\n"
|
|
" }\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f(int x)\n"
|
|
"{\n"
|
|
" for (iterator it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" foo.erase(it);\n"
|
|
" if (x)"
|
|
" return;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Dangerous iterator usage after erase()-method.\n", errout.str());
|
|
|
|
}
|
|
|
|
void eraseContinue() {
|
|
check("void f(std::vector<int> &ints)\n"
|
|
"{\n"
|
|
" std::vector<int>::iterator it;\n"
|
|
" std::vector<int>::iterator jt = ints.begin();\n"
|
|
" for (it = ints.begin(); it != ints.end(); it = jt) {\n"
|
|
" ++jt;\n"
|
|
" if (*it == 1) {\n"
|
|
" jt = ints.erase(it);\n"
|
|
" continue;\n"
|
|
" }\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void eraseReturn1() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> foo;\n"
|
|
" std::vector<int>::iterator it;\n"
|
|
" for (it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" foo.erase(it);\n"
|
|
" return;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void eraseReturn2() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> foo;\n"
|
|
" std::vector<int>::iterator it;\n"
|
|
" for (it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" if (*it == 1) {\n"
|
|
" foo.erase(it);\n"
|
|
" return;\n"
|
|
" }\n"
|
|
" else {\n"
|
|
" foo.erase(it);\n"
|
|
" return;\n"
|
|
" }\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void eraseReturn3() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> foo;\n"
|
|
" std::vector<int>::iterator it;\n"
|
|
" for (it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" if (somecondition) {\n"
|
|
" if (*it == 1)\n"
|
|
" foo.erase(it);\n"
|
|
" else\n"
|
|
" *it = 0;\n"
|
|
" return;\n"
|
|
" }\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> foo;\n"
|
|
" std::vector<int>::iterator it;\n"
|
|
" for (it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" if (a) {\n"
|
|
" if (b)\n"
|
|
" foo.erase(it);\n"
|
|
" else\n"
|
|
" *it = 0;\n"
|
|
" }\n"
|
|
" }\n"
|
|
"}\n");
|
|
TODO_ASSERT_EQUALS("[test.cpp:9]: (error) Dangerous iterator usage after erase()-method.\n", "", errout.str());
|
|
}
|
|
|
|
void eraseGoto() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" for (iterator it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" foo.erase(it);\n"
|
|
" goto abc;\n"
|
|
" }\n"
|
|
"bar:\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void eraseAssign1() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" for (iterator it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" foo.erase(it);\n"
|
|
" it = foo.begin();\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void eraseAssign2() {
|
|
check("void f(list<int> &ints)\n"
|
|
"{\n"
|
|
" for (list<int>::iterator it = ints.begin(); it != ints.end();) {\n"
|
|
" if (*it == 123) {\n"
|
|
" list<int>::iterator copy = it;\n"
|
|
" ++copy;\n"
|
|
" ints.erase(it);\n"
|
|
" it = copy;\n"
|
|
" } else {\n"
|
|
" it->second = 123;\n"
|
|
" ++it;\n"
|
|
" }\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void eraseErase() {
|
|
check("void f(std::vector<ints> &ints)\n"
|
|
"{\n"
|
|
" std::vector<int>::iterator iter;\n"
|
|
" iter = ints.begin() + 2;\n"
|
|
" ints.erase(iter);\n"
|
|
" ints.erase(iter);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Invalid iterator: iter\n", errout.str());
|
|
}
|
|
|
|
void eraseByValue() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::set<int> foo;\n"
|
|
" for (std::set<int>::iterator it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" foo.erase(*it);\n"
|
|
" }\n"
|
|
"}\n");
|
|
TODO_ASSERT_EQUALS("[test.cpp:6]: (error) Iterator 'it' becomes invalid when deleted by value from 'foo'\n", "", errout.str());
|
|
|
|
check("int f(std::set<int> foo) {\n"
|
|
" std::set<int>::iterator it = foo.begin();\n"
|
|
" foo.erase(*it);\n"
|
|
" return *it;\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Dereferenced iterator 'it' has been erased\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::set<int> foo;\n"
|
|
" std::set<int>::iterator it = foo.begin();\n"
|
|
" foo.erase(*it);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
void pushback1() {
|
|
check("void f(const std::vector<int> &foo)\n"
|
|
"{\n"
|
|
" std::vector<int>::const_iterator it = foo.begin();\n"
|
|
" foo.push_back(123);\n"
|
|
" *it;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) After push_back, the iterator 'it' may be invalid\n", errout.str());
|
|
}
|
|
|
|
void pushback2() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int>::const_iterator it = foo.begin();\n"
|
|
" foo.push_back(123);\n"
|
|
" {\n"
|
|
" int *it = &foo[0];\n"
|
|
" *it = 456;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void pushback3() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> foo;\n"
|
|
" foo.push_back(10);\n"
|
|
" std::vector<int>::iterator it;\n"
|
|
" for (it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" foo.push_back(123);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (error) After push_back, the iterator 'it' may be invalid\n", errout.str());
|
|
}
|
|
|
|
void pushback4() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> ints;\n"
|
|
" ints.push_back(1);\n"
|
|
" int *first = &ints[0];\n"
|
|
" ints.push_back(2);\n"
|
|
" *first;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:7]: (error) Invalid pointer 'first' after push_back / push_front\n", errout.str());
|
|
}
|
|
|
|
void pushback5() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int>::const_iterator i;\n"
|
|
"\n"
|
|
" for (i=v.begin(); i!=v.end(); ++i)\n"
|
|
" {\n"
|
|
" }\n"
|
|
"\n"
|
|
" for (i=rhs.v.begin(); i!=rhs.v.end(); ++i)\n"
|
|
" {\n"
|
|
" v.push_back(*i);\n"
|
|
" }\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void pushback6() {
|
|
// ticket #735
|
|
check("void f()\n"
|
|
"{\n"
|
|
" vector<int> v;\n"
|
|
" vector.push_back(1);\n"
|
|
" vector.push_back(2);\n"
|
|
" for (vector<int>::iterator it = v.begin(); it != v.end(); ++it)\n"
|
|
" {\n"
|
|
" if (*it == 1)\n"
|
|
" v.push_back(10);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:9]: (error) After push_back, the iterator 'it' may be invalid\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> v;\n"
|
|
" vector.push_back(1);\n"
|
|
" vector.push_back(2);\n"
|
|
" for (std::vector<int>::iterator it = v.begin(); it != v.end(); ++it)\n"
|
|
" {\n"
|
|
" if (*it == 1)\n"
|
|
" v.push_back(10);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:9]: (error) After push_back, the iterator 'it' may be invalid\n", errout.str());
|
|
}
|
|
|
|
void pushback7() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> foo;\n"
|
|
" foo.push_back(10);\n"
|
|
" std::vector<int>::iterator it;\n"
|
|
" for (it = foo.begin(); it != foo.end(); it++)\n"
|
|
" {\n"
|
|
" foo.push_back(123);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (error) After push_back, the iterator 'it' may be invalid\n", errout.str());
|
|
}
|
|
|
|
void pushback8() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> ints;\n"
|
|
" std::vector<int>::const_iterator end = ints.end();\n"
|
|
" ints.push_back(10);\n"
|
|
" std::vector<int>::iterator it;\n"
|
|
" unsigned int sum = 0;\n"
|
|
" for (it = ints.begin(); it != end; ++it)\n"
|
|
" {\n"
|
|
" sum += *it;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (error) After push_back, the iterator 'end' may be invalid\n", errout.str());
|
|
}
|
|
|
|
void pushback9() {
|
|
check("struct A {\n"
|
|
" std::vector<int> ints;\n"
|
|
"};\n"
|
|
"\n"
|
|
"void f()\n"
|
|
"{\n"
|
|
" std::vector<int> ints;\n"
|
|
" A a;\n"
|
|
" std::vector<int>::const_iterator i = ints.begin();\n"
|
|
" std::vector<int>::const_iterator e = ints.end();\n"
|
|
" while (i != e)\n"
|
|
" {\n"
|
|
" a.ints.push_back(*i);\n"
|
|
" ++i;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void pushback10() {
|
|
check("void f(std::vector<int> &foo)\n"
|
|
"{\n"
|
|
" std::vector<int>::const_iterator it = foo.begin();\n"
|
|
" foo.reserve(100);\n"
|
|
" *it = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) After reserve, the iterator 'it' may be invalid\n", errout.str());
|
|
|
|
// in loop
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> foo;\n"
|
|
" foo.push_back(10);\n"
|
|
" std::vector<int>::iterator it;\n"
|
|
" for (it = foo.begin(); it != foo.end(); ++it)\n"
|
|
" {\n"
|
|
" foo.reserve(123);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:8]: (error) After reserve, the iterator 'it' may be invalid\n", errout.str());
|
|
}
|
|
|
|
void pushback11() {
|
|
// #2798
|
|
check("void f() {\n"
|
|
" std::vector<int> ints;\n"
|
|
" std::vector<int>::iterator it = ints.begin();\n"
|
|
" if (it == ints.begin()) {\n"
|
|
" ints.push_back(0);\n"
|
|
" } else {\n"
|
|
" ints.insert(it,0);\n"
|
|
" }\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void insert1() {
|
|
check("void f(std::vector<int> &ints)\n"
|
|
"{\n"
|
|
" std::vector<int>::iterator iter = ints.begin() + 5;\n"
|
|
" ints.insert(ints.begin(), 1);\n"
|
|
" ++iter;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) After insert, the iterator 'iter' may be invalid\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> ints;\n"
|
|
" std::vector<int>::iterator iter = ints.begin();\n"
|
|
" ints.insert(iter, 1);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int> ints;\n"
|
|
" std::vector<int>::iterator iter = ints.begin();\n"
|
|
" ints.insert(iter, 1);\n"
|
|
" ints.insert(iter, 2);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) After insert, the iterator 'iter' may be invalid\n", errout.str());
|
|
}
|
|
|
|
void insert2() {
|
|
// Ticket: #2169
|
|
check("void f(std::vector<int> &vec) {\n"
|
|
" for(std::vector<int>::iterator iter = vec.begin(); iter != vec.end(); ++iter)\n"
|
|
" {\n"
|
|
" vec.insert(iter, 0);\n"
|
|
" break;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f(std::vector<int> &vec) {\n"
|
|
" for(std::vector<int>::iterator iter = vec.begin(); iter != vec.end(); ++iter)\n"
|
|
" {\n"
|
|
" if (*it == 0) {\n"
|
|
" vec.insert(iter, 0);\n"
|
|
" return;\n"
|
|
" }\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void invalidcode() {
|
|
errout.str("");
|
|
const std::string src = "void f()\n"
|
|
"{\n"
|
|
" for ( \n"
|
|
"}\n";
|
|
|
|
Settings settings;
|
|
Tokenizer tokenizer(&settings, this);
|
|
std::istringstream istr(src);
|
|
ASSERT_EQUALS(false, tokenizer.tokenize(istr, "test.cpp"));
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Invalid number of character (() when these macros are defined: ''.\n", errout.str());
|
|
}
|
|
|
|
|
|
|
|
void stlBoundries1() {
|
|
const int STL_CONTAINER_LIST = 9;
|
|
const std::string stlCont[STL_CONTAINER_LIST] = {
|
|
"deque", "list", "set", "multiset", "map",
|
|
"multimap", "hash_map", "hash_multimap", "hash_set"
|
|
};
|
|
|
|
for (int i = 0; i < STL_CONTAINER_LIST; ++i) {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::" + stlCont[i] + "<int>::iterator it;\n"
|
|
" for (it = ab.begin(); it < ab.end(); ++it)\n"
|
|
" ;\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Dangerous container iterator compare using < operator for " + stlCont[i] + "\n", errout.str());
|
|
}
|
|
}
|
|
|
|
void stlBoundries2() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<std::string> files;\n"
|
|
" std::vector<std::string>::const_iterator it;\n"
|
|
" for (it = files.begin(); it < files.end(); it++) { }\n"
|
|
" for (it = files.begin(); it < files.end(); it++) { };\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void stlBoundries3() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" set<int> files;\n"
|
|
" set<int>::const_iterator current;\n"
|
|
" for (current = files.begin(); current != files.end(); ++current)\n"
|
|
" {\n"
|
|
" assert(*current < 100)\n"
|
|
" }\n"
|
|
"}\n");
|
|
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
|
|
void if_find() {
|
|
// ---------------------------
|
|
// set::find
|
|
// ---------------------------
|
|
|
|
// error
|
|
check("void f(std::set<int> s)\n"
|
|
"{\n"
|
|
" if (s.find(12)) { }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (warning) Suspicious condition. The result of find is an iterator, but it is not properly checked.\n", errout.str());
|
|
|
|
// ok
|
|
check("void f(std::set<int> s)\n"
|
|
"{\n"
|
|
" if (s.find(123) != s.end()) { }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
|
|
// ---------------------------
|
|
// std::find
|
|
// ---------------------------
|
|
|
|
// error
|
|
check("void f()\n"
|
|
"{\n"
|
|
" if (std::find(a,b,c)) { }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (warning) Suspicious condition. The result of find is an iterator, but it is not properly checked.\n", errout.str());
|
|
|
|
// ok
|
|
check("void f()\n"
|
|
"{\n"
|
|
" if (std::find(a,b,c) != c) { }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void if_str_find() {
|
|
// error
|
|
check("void f(const std::string &s)\n"
|
|
"{\n"
|
|
" if (s.find(\"abc\")) { }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (warning) Suspicious checking of string::find() return value.\n", errout.str());
|
|
}
|
|
|
|
|
|
void size1() {
|
|
check("struct Fred {\n"
|
|
" void foo();\n"
|
|
" std::list<int> x;\n"
|
|
"};\n"
|
|
"void Fred::foo()\n"
|
|
"{\n"
|
|
" if (x.size() == 0) {}\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:7]: (performance) Possible inefficient checking for 'x' emptiness.\n", errout.str());
|
|
|
|
check("std::list<int> x;\n"
|
|
"void f()\n"
|
|
"{\n"
|
|
" if (x.size() == 0) {}\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (performance) Possible inefficient checking for 'x' emptiness.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int> x;\n"
|
|
" if (x.size() == 0) {}\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (performance) Possible inefficient checking for 'x' emptiness.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int> x;\n"
|
|
" if (0 == x.size()) {}\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (performance) Possible inefficient checking for 'x' emptiness.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int> x;\n"
|
|
" if (x.size() != 0) {}\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (performance) Possible inefficient checking for 'x' emptiness.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int> x;\n"
|
|
" if (0 != x.size()) {}\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (performance) Possible inefficient checking for 'x' emptiness.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int> x;\n"
|
|
" if (x.size() > 0) {}\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (performance) Possible inefficient checking for 'x' emptiness.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int> x;\n"
|
|
" if (0 < x.size()) {}\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (performance) Possible inefficient checking for 'x' emptiness.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int> x;\n"
|
|
" if (x.size()) {}\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (performance) Possible inefficient checking for 'x' emptiness.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int> x;\n"
|
|
" if (!x.size()) {}\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (performance) Possible inefficient checking for 'x' emptiness.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int> x;\n"
|
|
" fun(x.size());\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::list<int> x;\n"
|
|
" fun(!x.size());\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void redundantCondition1() {
|
|
check("void f(string haystack)\n"
|
|
"{\n"
|
|
" if (haystack.find(needle) != haystack.end())\n"
|
|
" haystack.remove(needle);"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (style) Redundant checking of STL container element.\n", errout.str());
|
|
}
|
|
|
|
void size2() {
|
|
check("struct Fred {\n"
|
|
" std::list<int> x;\n"
|
|
"};\n"
|
|
"struct Wilma {\n"
|
|
" Fred f;\n"
|
|
" void foo();\n"
|
|
"};\n"
|
|
"void Wilma::foo()\n"
|
|
"{\n"
|
|
" if (f.x.size() == 0) {}\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:10]: (performance) Possible inefficient checking for 'x' emptiness.\n", errout.str());
|
|
}
|
|
|
|
void redundantCondition2() {
|
|
check("void f(string haystack)\n"
|
|
"{\n"
|
|
" if (haystack.find(needle) != haystack.end())\n"
|
|
" {\n"
|
|
" haystack.remove(needle);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (style) Redundant checking of STL container element.\n", errout.str());
|
|
}
|
|
|
|
void missingInnerComparison1() {
|
|
check("void f(std::set<int> &ints) {\n"
|
|
" for (std::set<int>::iterator it = ints.begin(); it != ints.end(); ++it) {\n"
|
|
" if (a) {\n"
|
|
" it++;\n"
|
|
" }\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (warning) Missing bounds check for extra iterator increment in loop.\n", errout.str());
|
|
|
|
check("void f(std::map<int,int> &ints) {\n"
|
|
" for (std::map<int,int>::iterator it = ints.begin(); it != ints.end(); ++it) {\n"
|
|
" ++it->second;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void missingInnerComparison2() {
|
|
check("void f(std::set<int> &ints) {\n"
|
|
" for (std::set<int>::iterator it = ints.begin(); it != ints.end(); ++it) {\n"
|
|
" if (a) {\n"
|
|
" it++;\n"
|
|
" if (it == ints.end())\n"
|
|
" return;\n"
|
|
" }\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void missingInnerComparison3() {
|
|
check("void f(std::set<int> &ints) {\n"
|
|
" for (std::set<int>::iterator it = ints.begin(); it != ints.end(); ++it) {\n"
|
|
" for (std::set<int>::iterator it = ints2.begin(); it != ints2.end(); ++it)\n"
|
|
" { }\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void missingInnerComparison4() {
|
|
check("function f1(std::list<int> &l1) {\n"
|
|
" for(std::list<int>::iterator i = l1.begin(); i != l1.end(); i++) {\n"
|
|
" if (*i == 44) {\n"
|
|
" l1.insert(++i, 55);\n"
|
|
" break;\n"
|
|
" }\n"
|
|
" }\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("function f1(std::list<int> &l1) {\n"
|
|
" for(std::list<int>::iterator i = l1.begin(); i != l1.end(); i++) {\n"
|
|
" if (*i == 44) {\n"
|
|
" l1.insert(++i, 55);\n"
|
|
" return;\n"
|
|
" }\n"
|
|
" }\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void missingInnerComparison5() {
|
|
check("void f() {\n"
|
|
" for(it = map1.begin(); it != map1.end(); it++) {\n"
|
|
" str[i++] = (*it).first;\n"
|
|
" }\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void missingInnerComparison6() {
|
|
check("void f(std::string &s) {\n"
|
|
" for(string::iterator it = s.begin(); it != s.end(); it++) {\n"
|
|
" it = s.insert(++it, 0);\n"
|
|
" }\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void cstr() {
|
|
check("void f() {\n"
|
|
" std::string errmsg;\n"
|
|
" throw errmsg.c_str();\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Dangerous usage of c_str(). The returned value by c_str() is invalid after throw call.\n", errout.str());
|
|
|
|
check("const char *get_msg() {\n"
|
|
" std::string errmsg;\n"
|
|
" return errmsg.c_str();\n"
|
|
"}");
|
|
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Dangerous usage of c_str(). The returned value by c_str() is invalid after this call.\n", errout.str());
|
|
|
|
check("const char *get_msg() {\n"
|
|
" std::ostringstream errmsg;\n"
|
|
" return errmsg.str().c_str();\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Dangerous usage of c_str(). The returned value by c_str() is invalid after this call.\n", errout.str());
|
|
|
|
check("const char *get_msg() {\n"
|
|
" std::string errmsg;\n"
|
|
" return std::string(\"ERROR: \" + errmsg).c_str();\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Dangerous usage of c_str(). The returned value by c_str() is invalid after this call.\n", errout.str());
|
|
|
|
check("const char *get_msg() {\n"
|
|
" std::string errmsg;\n"
|
|
" return (\"ERROR: \" + errmsg).c_str();\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Dangerous usage of c_str(). The returned value by c_str() is invalid after this call.\n", errout.str());
|
|
|
|
check("const char *get_msg() {\n"
|
|
" std::string errmsg;\n"
|
|
" return (\"ERROR: \" + std::string(\"crash me\")).c_str();\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Dangerous usage of c_str(). The returned value by c_str() is invalid after this call.\n", errout.str());
|
|
|
|
// Implicit conversion back to std::string
|
|
check("std::string get_msg() {\n"
|
|
" std::string errmsg;\n"
|
|
" return errmsg.c_str();\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f() {\n"
|
|
" std::ostringstream errmsg;\n"
|
|
" const char *c = errmsg.str().c_str();\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Dangerous usage of c_str(). The returned value by c_str() is invalid after this call.\n", errout.str());
|
|
|
|
check("std::string f();\n"
|
|
"\n"
|
|
"void foo() {\n"
|
|
" const char *c = f().c_str();\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Dangerous usage of c_str(). The returned value by c_str() is invalid after this call.\n", errout.str());
|
|
}
|
|
|
|
void autoPointer() {
|
|
|
|
// ticket 2846
|
|
check("void f()\n"
|
|
"{\n"
|
|
" std::vector<int*> vec;\n"
|
|
" vec.push_back(new int(3));\n"
|
|
" std::auto_ptr<int> ret(vec[0]);\n"
|
|
"};\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// ticket 2839
|
|
check("template <class MUTEX_TYPE>\n"
|
|
"class Guarded\n"
|
|
"{\n"
|
|
" typedef std::auto_ptr<MUTEX_TYPE > WriteGuardType;\n"
|
|
" virtual WriteGuardType getWriteGuard(bool enabledGuard = true);\n"
|
|
"};\n"
|
|
"class SafeSharedMemory : public Guarded<int>\n"
|
|
"{\n"
|
|
"};\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" auto_ptr< ns1:::MyClass > y;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void f() \n"
|
|
"{\n"
|
|
" auto_ptr<T> p2;\n"
|
|
" p2 = new T;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector< std::auto_ptr< ns1::MyClass> > v;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) You can randomly lose access to pointers if you store 'auto_ptr' pointers in a container because the copy-semantics of 'auto_ptr' are not compatible with containers.\n", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" std::vector< auto_ptr< MyClass> > v;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) You can randomly lose access to pointers if you store 'auto_ptr' pointers in a container because the copy-semantics of 'auto_ptr' are not compatible with containers.\n", errout.str());
|
|
|
|
check("void foo()\n"
|
|
"{\n"
|
|
" int *i = new int;\n"
|
|
" auto_ptr<int> x(i);\n"
|
|
" auto_ptr<int> y;\n"
|
|
" y = x;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (style) Copy 'auto_ptr' pointer to another do not create two equal objects since one has lost its ownership of the pointer.\n", errout.str());
|
|
|
|
check("std::auto_ptr<A> function();\n"
|
|
"int quit;"
|
|
"void f() { quit = true; }\n"
|
|
);
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// ticket #748
|
|
check("void f() \n"
|
|
"{\n"
|
|
" T* var = new T[10];\n"
|
|
" auto_ptr<T> p2( var );\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
|
|
|
|
check("void f() \n"
|
|
"{\n"
|
|
" foo::bar::baz* var = new foo::bar::baz[10];\n"
|
|
" auto_ptr<foo::bar::baz> p2( var );\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
|
|
|
|
check("void f() \n"
|
|
"{\n"
|
|
" auto_ptr<T> p2( new T[] );\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
|
|
|
|
check("void f() \n"
|
|
"{\n"
|
|
" auto_ptr<T> p2( new T[5] );\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
|
|
|
|
check("void f() \n"
|
|
"{\n"
|
|
" auto_ptr<foo::bar> p(new foo::bar[10]);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
|
|
|
|
check("void f() \n"
|
|
"{\n"
|
|
" auto_ptr<T> p2;\n"
|
|
" p2.reset( new T[] );\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
|
|
|
|
|
|
check("void f() \n"
|
|
"{\n"
|
|
" auto_ptr<T> p2( new T[][] );\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
|
|
|
|
check("void f() \n"
|
|
"{\n"
|
|
" auto_ptr<T> p2;\n"
|
|
" p2 = new T[10];\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
|
|
|
|
check("void f() \n"
|
|
"{\n"
|
|
" auto_ptr<T::B> p2;\n"
|
|
" p2 = new T::B[10];\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
|
|
|
|
check("void f() \n"
|
|
"{\n"
|
|
" auto_ptr<T> p2;\n"
|
|
" p2.reset( new T[10] );\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
|
|
|
|
check("void f() \n"
|
|
"{\n"
|
|
" auto_ptr<T::B> p2;\n"
|
|
" p2.reset( new T::B[10] );\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
|
|
|
|
// ticket #2887 (infinite loop)
|
|
check("A::A(std::auto_ptr<X> e){}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// ticket #2967 (segmentation fault)
|
|
check("auto_ptr<x>\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void uselessCalls() {
|
|
check("void f()\n"
|
|
"{\n"
|
|
" string s1, s2;\n"
|
|
" s1.swap(s2);\n"
|
|
" s2.swap(s2);\n"
|
|
" \n"
|
|
"};\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (performance) It is inefficient to swap a object with itself by calling 's2.swap(s2)'\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" string s1, s2;\n"
|
|
" s1.compare(s2);\n"
|
|
" s2.compare(s2);\n"
|
|
" s1.compare(s2.c_str());\n"
|
|
" s1.compare(0, s1.size(), s1);\n"
|
|
" \n"
|
|
"};\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (warning) It is inefficient to call 's2.compare(s2)' as it always returns 0.\n", errout.str());
|
|
|
|
check("void f()\n"
|
|
"{\n"
|
|
" int x=1;\n"
|
|
" string s1, s2;\n"
|
|
" s1 = s1.substr();\n"
|
|
" s2 = s1.substr(x);\n"
|
|
" s1 = s2.substr(0, x);\n"
|
|
" s1 = s2.substr(0,std::string::npos);\n"
|
|
" \n"
|
|
"};\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (performance) Function \'substr\' useless call. Function create copy "
|
|
"of the \'s1\' object.\n"
|
|
"[test.cpp:8]: (performance) Function \'substr\' useless call. Function create copy "
|
|
"of the \'s2\' object.\n",errout.str());
|
|
|
|
check("#include <string>\n"
|
|
"int main()\n"
|
|
"{\n"
|
|
" std::string str = \"a1b1\";\n"
|
|
" return str.find(str[1], 2);\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
}
|
|
};
|
|
|
|
REGISTER_TEST(TestStl)
|