1242 lines
44 KiB
C++
1242 lines
44 KiB
C++
/*
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|
* Copyright (C) 2007-2010 Daniel Marjamäki and Cppcheck team.
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "tokenize.h"
|
|
#include "checkuninitvar.h"
|
|
#include "testsuite.h"
|
|
#include <sstream>
|
|
|
|
extern std::ostringstream errout;
|
|
|
|
class TestUninitVar : public TestFixture
|
|
{
|
|
public:
|
|
TestUninitVar() : TestFixture("TestUninitVar")
|
|
{ }
|
|
|
|
private:
|
|
|
|
|
|
void run()
|
|
{
|
|
TEST_CASE(uninitvar1);
|
|
TEST_CASE(uninitvar_alloc); // data is allocated but not initialized
|
|
TEST_CASE(uninitvar_arrays); // arrays
|
|
TEST_CASE(uninitvar_class); // class/struct
|
|
TEST_CASE(uninitvar_enum); // enum variables
|
|
TEST_CASE(uninitvar_if); // handling if
|
|
TEST_CASE(uninitvar_loops); // handling for/while
|
|
TEST_CASE(uninitvar_switch); // handling switch
|
|
TEST_CASE(uninitvar_references); // references
|
|
TEST_CASE(uninitvar_strncpy); // strncpy doesn't always 0-terminate
|
|
TEST_CASE(uninitvar_func); // analyse functions
|
|
}
|
|
|
|
void checkUninitVar(const char code[])
|
|
{
|
|
// Tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.simplifyTokenList();
|
|
|
|
// Clear the error buffer..
|
|
errout.str("");
|
|
|
|
// Check for redundant code..
|
|
Settings settings;
|
|
CheckUninitVar check(&tokenizer, &settings, this);
|
|
check.executionPaths();
|
|
}
|
|
|
|
void uninitvar1()
|
|
{
|
|
// dereferencing uninitialized pointer..
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" Foo *p;\n"
|
|
" p->abcd();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" Foo<int> *p;\n"
|
|
" p->abcd();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
|
|
|
|
checkUninitVar("void f(Foo *p)\n"
|
|
"{\n"
|
|
" int a;\n"
|
|
" p->a = malloc(4 * a);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" int *p;\n"
|
|
" delete p;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" int *p;\n"
|
|
" delete [] p;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" int *p;\n"
|
|
" *p = 135;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" int *x;\n"
|
|
" int y = *x;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: x\n", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" int *x;\n"
|
|
" int &y(*x);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: x\n", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" int x;\n"
|
|
" int *y = &x;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" int x = xyz::x;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("static int foo()\n"
|
|
"{\n"
|
|
" int ret;\n"
|
|
" return ret;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: ret\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" int a;\n"
|
|
" a = 5 + a;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" int a;\n"
|
|
" a++;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" int a;\n"
|
|
" bar(4 * a);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" if (i);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: i\n", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" for (int x = 0; i < 10; x++);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: i\n", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" for (int x = 0; x < 10; i++);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: i\n", errout.str());
|
|
|
|
checkUninitVar("static int foo(int x)\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" if (x)\n"
|
|
" i = 0;\n"
|
|
" return i;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: i\n", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" int ar[10];\n"
|
|
" int i;\n"
|
|
" ar[i] = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: i\n", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" int x, y;\n"
|
|
" x = (y = 10);\n"
|
|
" int z = y * 2;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" Foo p;\n"
|
|
" p.abcd();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" Foo p;\n"
|
|
" int x = p.abcd();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("A a()\n"
|
|
"{\n"
|
|
" A ret;\n"
|
|
" return ret;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int a()\n"
|
|
"{\n"
|
|
" int x;\n"
|
|
" return x;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: x\n", errout.str());
|
|
|
|
checkUninitVar("void a()\n"
|
|
"{\n"
|
|
" int x[10];\n"
|
|
" int *y = x;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void a()\n"
|
|
"{\n"
|
|
" int x;\n"
|
|
" int *y = &x;\n"
|
|
" *y = 0;\n"
|
|
" x++;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void a()\n"
|
|
"{\n"
|
|
" char x[10], y[10];\n"
|
|
" char *z = x;\n"
|
|
" memset(z, 0, sizeof(x));\n"
|
|
" memcpy(y, x, sizeof(x));\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int a()\n"
|
|
"{\n"
|
|
" int ret;\n"
|
|
" std::cin >> ret;\n"
|
|
" return ret;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int a()\n"
|
|
"{\n"
|
|
" int ret;\n"
|
|
" asm();\n"
|
|
" return ret;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void a()\n"
|
|
"{\n"
|
|
" int x[10];\n"
|
|
" struct xyz xyz1 = { .x = x };\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void a()\n"
|
|
"{\n"
|
|
" struct S *s;\n"
|
|
" s->x = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: s\n", errout.str());
|
|
|
|
checkUninitVar("void a()\n"
|
|
"{\n"
|
|
" struct S *s;\n"
|
|
" FOREACH() { }\n"
|
|
" s->x = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: s\n", errout.str());
|
|
|
|
checkUninitVar("void a()\n"
|
|
"{\n"
|
|
" struct S *s1;\n"
|
|
" struct S *s2;\n"
|
|
" FOREACH(s1) { }\n"
|
|
" s2->x = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: s2\n", errout.str());
|
|
|
|
// #1533
|
|
checkUninitVar("char a()\n"
|
|
"{\n"
|
|
" char key;\n"
|
|
" struct A msg = { .buf = {&key} };\n"
|
|
" init(&msg);\n"
|
|
" return key;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" char *buf = malloc(100);\n"
|
|
" struct ABC *abc = buf;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("class Fred {\n"
|
|
"public:\n"
|
|
" FILE *f;\n"
|
|
" ~Fred();\n"
|
|
"}\n"
|
|
"Fred::~Fred()\n"
|
|
"{\n"
|
|
" fclose(f);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" int c;\n"
|
|
" ab(sizeof(xyz), &c);\n"
|
|
" if (c);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" int c;\n"
|
|
" a = (f2(&c));\n"
|
|
" c++;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f(int a)\n"
|
|
"{\n"
|
|
" if (a) {\n"
|
|
" char *p;\n"
|
|
" *p = 0;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: p\n", errout.str());
|
|
|
|
// +=
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" int c;\n"
|
|
" c += 2;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: c\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char *s = malloc(100);\n"
|
|
" *s += 10;\n"
|
|
"}\n");
|
|
TODO_ASSERT_EQUALS("[test.cpp:4]: (error) Data is allocated but not initialized: s\n", errout.str());
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" int a[10];\n"
|
|
" a[0] += 10;\n"
|
|
"}\n");
|
|
TODO_ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// goto/setjmp/longjmp..
|
|
checkUninitVar("void foo(int x)\n"
|
|
"{\n"
|
|
" long b;\n"
|
|
" if (g()) {\n"
|
|
" b =2;\n"
|
|
" goto found;\n"
|
|
" }\n"
|
|
"\n"
|
|
" return;\n"
|
|
"\n"
|
|
"found:\n"
|
|
" int a = b;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int foo()\n"
|
|
"{\n"
|
|
" jmp_buf env;\n"
|
|
" int a;\n"
|
|
" int val = setjmp(env);\n"
|
|
" if(val)\n"
|
|
" return a;\n"
|
|
" a = 1;\n"
|
|
" longjmp(env, 1);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// macro_for..
|
|
checkUninitVar("int foo()\n"
|
|
"{\n"
|
|
" int retval;\n"
|
|
" if (condition) {\n"
|
|
" for12(1,2) { }\n"
|
|
" retval = 1;\n"
|
|
" }\n"
|
|
" else\n"
|
|
" retval = 2;\n"
|
|
" return retval;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int foo()\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" goto exit;\n"
|
|
" i++;\n"
|
|
"exit:\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
// if..
|
|
void uninitvar_if()
|
|
{
|
|
checkUninitVar("static void foo()\n"
|
|
"{\n"
|
|
" Foo *p;\n"
|
|
" if (x)\n"
|
|
" p = new Foo;\n"
|
|
" p->abcd();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: p\n", errout.str());
|
|
|
|
checkUninitVar("static void foo(int x)\n"
|
|
"{\n"
|
|
" int a;\n"
|
|
" if (x==1);\n"
|
|
" if (x==2);\n"
|
|
" x = a;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: a\n", errout.str());
|
|
|
|
checkUninitVar("int foo()\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" if (x)\n"
|
|
" i = 22;\n"
|
|
" else\n"
|
|
" i = 33;\n"
|
|
" return i;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int foo()\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" if (x)\n"
|
|
" i = 22;\n"
|
|
" else\n"
|
|
" {\n"
|
|
" char *y = {0};\n"
|
|
" i = 33;\n"
|
|
" }\n"
|
|
" return i;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int foo()\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" if (x)\n"
|
|
" {\n"
|
|
" struct abc abc1 = (struct abc) { .a=0, .b=0, .c=0 };\n"
|
|
" i = 22;\n"
|
|
" }\n"
|
|
" else\n"
|
|
" {\n"
|
|
" i = 33;\n"
|
|
" }\n"
|
|
" return i;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("static void foo(int x)\n"
|
|
"{\n"
|
|
" Foo *p;\n"
|
|
" if (x)\n"
|
|
" p = new Foo;\n"
|
|
" if (x)\n"
|
|
" p->abcd();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo(int a)\n"
|
|
"{\n"
|
|
" int n;\n"
|
|
" int condition;\n"
|
|
" if(a == 1) {\n"
|
|
" n=0;\n"
|
|
" condition=0;\n"
|
|
" }\n"
|
|
" else {\n"
|
|
" n=1;\n"
|
|
" }\n"
|
|
"\n"
|
|
" if( n == 0) {\n"
|
|
" a=condition;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" C *c;\n"
|
|
" if (fun(&c));\n"
|
|
" c->Release();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int foo(int x)\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" if (one())\n"
|
|
" i = 1;\n"
|
|
" else\n"
|
|
" return 3;\n"
|
|
" return i;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int foo()\n"
|
|
"{\n"
|
|
" int ret;\n"
|
|
" if (one())\n"
|
|
" ret = 1;\n"
|
|
" else\n"
|
|
" throw 3;\n"
|
|
" return ret;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int f(int a)\n"
|
|
"{\n"
|
|
" int ret;\n"
|
|
" if (a == 1)\n"
|
|
" ret = 1;\n"
|
|
" else\n"
|
|
" XYZ ret = 2;\n" // XYZ may be an unexpanded macro so bailout the checking of "ret".
|
|
" return ret;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int f(int a, int b)\n"
|
|
"{\n"
|
|
" int x;\n"
|
|
" if (a)\n"
|
|
" x = a;\n"
|
|
" else {\n"
|
|
" do { } while (f2());\n"
|
|
" x = b;\n"
|
|
" }\n"
|
|
" return x;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo(long verbose,bool bFlag)\n"
|
|
"{\n"
|
|
" double t;\n"
|
|
" if (bFlag)\n"
|
|
" {\n"
|
|
" if (verbose)\n"
|
|
" t = 1;\n"
|
|
" if (verbose)\n"
|
|
" std::cout << (12-t);\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// ? :
|
|
checkUninitVar("static void foo(int v)\n"
|
|
"{\n"
|
|
" int x;\n"
|
|
" if (v > 0)\n"
|
|
" v = func(&x);\n"
|
|
" x = v <= 0 ? -1 : x;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" const char *msgid1, *msgid2;\n"
|
|
" int ret = bar(&msgid1);\n"
|
|
" if (ret > 0) {\n"
|
|
" ret = bar(&msgid2);\n"
|
|
" }\n"
|
|
" ret = ret <= 0 ? -1 :\n"
|
|
" strcmp(msgid1, msgid2) == 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo(int a, int b)\n"
|
|
"{\n"
|
|
" int x; x = (a<b) ? 1 : 0;\n"
|
|
" int y = y;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: y\n", errout.str());
|
|
|
|
// ; { .. }
|
|
checkUninitVar("int foo()\n"
|
|
"{\n"
|
|
" int retval;\n"
|
|
" if (condition) {\n"
|
|
" { }\n"
|
|
" retval = 1; }\n"
|
|
" else\n"
|
|
" retval = 2;\n"
|
|
" return retval;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" {\n"
|
|
" for (int i = 0; i < 10; ++i)\n"
|
|
" { }\n"
|
|
" }\n"
|
|
"\n"
|
|
" { }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
// handling for/while loops..
|
|
void uninitvar_loops()
|
|
{
|
|
// for..
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" for (int i = 0; i < 4; ++i) {\n"
|
|
" int a;\n"
|
|
" b(4*a);\n"
|
|
" }"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: a\n", errout.str());
|
|
|
|
checkUninitVar("void f() {\n"
|
|
" int k;\n"
|
|
" for (int i = 0; i < 4; ++i) {\n"
|
|
" k = k + 2;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: k\n", errout.str());
|
|
|
|
checkUninitVar("enum ABCD { A, B, C, D };\n"
|
|
"\n"
|
|
"static void f(char *str ) {\n"
|
|
" enum ABCD i;\n"
|
|
" for (i = 0; i < D; i++) {\n"
|
|
" str[i] = 0;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void x() {\n"
|
|
" do {\n"
|
|
" Token * tok;\n"
|
|
" for (tok = a; tok; tok = tok->next())\n"
|
|
" {\n"
|
|
" }\n"
|
|
" } while (tok2);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// while..
|
|
checkUninitVar("int f()\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" while (fgets())\n"
|
|
" i = 1;\n"
|
|
" return i;"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: i\n", errout.str());
|
|
|
|
checkUninitVar("void f(int i)\n"
|
|
"{\n"
|
|
" int a;\n"
|
|
" while (i < 10)\n"
|
|
" i++;\n"
|
|
" a++;"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: a\n", errout.str());
|
|
}
|
|
|
|
// switch..
|
|
void uninitvar_switch()
|
|
{
|
|
checkUninitVar("void f(int x)\n"
|
|
"{\n"
|
|
" short c;\n"
|
|
" switch(x) {\n"
|
|
" case 1:\n"
|
|
" c++;\n"
|
|
" break;\n"
|
|
" };\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Uninitialized variable: c\n", errout.str());
|
|
|
|
checkUninitVar("char * f()\n"
|
|
"{\n"
|
|
" static char ret[200];\n"
|
|
" memset(ret, 0, sizeof(ret));\n"
|
|
" switch (x)\n"
|
|
" {\n"
|
|
" case 1: return ret;\n"
|
|
" case 2: return ret;\n"
|
|
" }\n"
|
|
" return 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int foo(const int iVar, unsigned int slot, unsigned int pin)\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
"\n"
|
|
" if (iVar == 0)\n"
|
|
" {\n"
|
|
" switch (slot)\n"
|
|
" {\n"
|
|
" case 4: return 5;\n"
|
|
" default: return -1;\n"
|
|
" }\n"
|
|
" }\n"
|
|
" else\n"
|
|
" {\n"
|
|
" switch (pin)\n"
|
|
" {\n"
|
|
" case 0: i = 2; break;\n"
|
|
" default: i = -1; break;\n"
|
|
" }\n"
|
|
" }\n"
|
|
" return i;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// No segmentation fault
|
|
checkUninitVar("void a() try\n"
|
|
"{\n"
|
|
" {\n"
|
|
" while (1) {\n"
|
|
" switch (1) {\n"
|
|
" case 1: {\n"
|
|
" int i;\n"
|
|
" }\n"
|
|
" }\n"
|
|
" }\n"
|
|
" } catch (...) {\n"
|
|
" }\n"
|
|
"}\n");
|
|
|
|
// #1855 - switch(foo(&x))
|
|
checkUninitVar("int a()\n"
|
|
"{\n"
|
|
" int x;\n"
|
|
" switch (foo(&x))\n"
|
|
" {\n"
|
|
" case 1:\n"
|
|
" return x;\n"
|
|
" }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
// arrays..
|
|
void uninitvar_arrays()
|
|
{
|
|
checkUninitVar("int f()\n"
|
|
"{\n"
|
|
" char a[10];\n"
|
|
" a[a[0]] = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
|
|
|
|
checkUninitVar("int f()\n"
|
|
"{\n"
|
|
" char a[10];\n"
|
|
" char c = *a;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
|
|
|
|
checkUninitVar("int f()\n"
|
|
"{\n"
|
|
" char a[10];\n"
|
|
" *a = '\\0';\n"
|
|
" int i = strlen(a);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char a, b[10];\n"
|
|
" a = b[0] = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char a[10], b[10];\n"
|
|
" a[0] = b[0] = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char a[10], *p;\n"
|
|
" *(p = a) = 0;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char c[50] = \"\";\n"
|
|
" strcat(c, \"test\");\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char s[20];\n"
|
|
" strcpy(s2, s);\n"
|
|
"};\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: s\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char s[20];\n"
|
|
" strcat(s, \"abc\");\n"
|
|
"};\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: s\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char s[20];\n"
|
|
" strchr(s, ' ');\n"
|
|
"};\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: s\n", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" int y[2];\n"
|
|
" int s;\n"
|
|
" GetField( y + 0, \n"
|
|
" y + 1 );\n"
|
|
" s = y[0]*y[1];\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
// alloc..
|
|
void uninitvar_alloc()
|
|
{
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char *s = malloc(100);\n"
|
|
" strcat(s, \"abc\");\n"
|
|
"};\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Data is allocated but not initialized: s\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char *s1 = new char[10];\n"
|
|
" char *s2 = new char[strlen(s1)];\n"
|
|
"};\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Data is allocated but not initialized: s1\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char *p = malloc(64);\n"
|
|
" int x = p[0];\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Data is allocated but not initialized: p\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char *p = malloc(64);\n"
|
|
" if (p[0]) { }\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Data is allocated but not initialized: p\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char *p = malloc(64);\n"
|
|
" return p[0];\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Data is allocated but not initialized: p\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" Fred *fred = new Fred;\n"
|
|
" fred->foo();\n"
|
|
"};\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo(char *s)\n"
|
|
"{\n"
|
|
" char *a = malloc(100);\n"
|
|
" *a = *s;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" char *a;\n"
|
|
" if (a);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: a\n", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" char *a = malloc(100);\n"
|
|
" if (a);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" ABC *abc = malloc(100);\n"
|
|
" abc->a = 123;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" ABC *abc = malloc(100);\n"
|
|
" abc->a.word = 123;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" ABC *abc = malloc(100);\n"
|
|
" abc->a = 123;\n"
|
|
" abc->a += 123;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" ABC *abc = malloc(100);\n"
|
|
" free(abc);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char *s = malloc(100);\n"
|
|
" if (!s)\n"
|
|
" return;\n"
|
|
" char c = *s;\n"
|
|
"};\n");
|
|
ASSERT_EQUALS("[test.cpp:6]: (error) Data is allocated but not initialized: s\n", errout.str());
|
|
}
|
|
|
|
// class / struct..
|
|
void uninitvar_class()
|
|
{
|
|
checkUninitVar("class Fred\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" int a() { return i; }\n"
|
|
"};\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" struct Relative {\n"
|
|
" Surface *surface;\n"
|
|
" void MoveTo(int x, int y) {\n"
|
|
" surface->MoveTo();\n"
|
|
" }\n"
|
|
" };\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" static const struct ab {\n"
|
|
" int a,b;\n"
|
|
" int get_a() { return a; }"
|
|
" } = { 0, 0 };\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" {\n"
|
|
" union ab {\n"
|
|
" int a,b;\n"
|
|
" }\n"
|
|
" i = 0;\n"
|
|
" }\n"
|
|
" return i;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
// enum..
|
|
void uninitvar_enum()
|
|
{
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" enum AB { a, b };\n"
|
|
" AB ab;\n"
|
|
" if (ab);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: ab\n", errout.str());
|
|
}
|
|
|
|
// references..
|
|
void uninitvar_references()
|
|
{
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" int a;\n"
|
|
" int &b = a;\n"
|
|
" b = 0;\n"
|
|
" int x = a;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f(struct blame_entry *ent)\n"
|
|
"{\n"
|
|
" struct origin *suspect = ent->suspect;\n"
|
|
" char hex[41];\n"
|
|
" strcpy(hex, sha1_to_hex(suspect->commit->object.sha1));\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" const std::string s(x());\n"
|
|
" strchr(s.c_str(), ',');\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
// strncpy doesn't always 0-terminate..
|
|
void uninitvar_strncpy()
|
|
{
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char a[100];\n"
|
|
" strncpy(a, s, 20);\n"
|
|
" strncat(a, s, 20);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Dangerous usage of 'a' (strncpy doesn't always 0-terminate it)\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char a[100];\n"
|
|
" strncpy(a, \"hello\", 3);\n"
|
|
" strncat(a, \"world\", 20);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Dangerous usage of 'a' (strncpy doesn't always 0-terminate it)\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" char a[100];\n"
|
|
" strncpy(a, \"hello\", sizeof(a));\n"
|
|
" strncat(a, \"world\", 20);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
|
|
std::string analyseFunctions(const char code[])
|
|
{
|
|
// Tokenize..
|
|
Tokenizer tokenizer;
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
std::set<std::string> f;
|
|
const CheckUninitVar check((const Tokenizer *)0, (const Settings *)0, (ErrorLogger *)0);
|
|
check.analyse(tokenizer.tokens(), f);
|
|
|
|
std::string ret;
|
|
for (std::set<std::string>::const_iterator it = f.begin(); it != f.end(); ++it)
|
|
ret += (ret.empty() ? "" : " ") + *it;
|
|
return ret;
|
|
}
|
|
|
|
void uninitvar_func()
|
|
{
|
|
// function analysis..
|
|
ASSERT_EQUALS("foo", analyseFunctions("void foo(int x) { }"));
|
|
ASSERT_EQUALS("foo", analyseFunctions("void foo(const int &x) { }"));
|
|
ASSERT_EQUALS("foo", analyseFunctions("void foo(int &x) { ++x; }"));
|
|
ASSERT_EQUALS("", analyseFunctions("void foo(int &x) { x = 0; }"));
|
|
ASSERT_EQUALS("", analyseFunctions("void foo(s x) { }"));
|
|
|
|
// function calls..
|
|
checkUninitVar("void assignOne(int &x)\n"
|
|
"{ x = 1; }\n"
|
|
"\n"
|
|
"int f()\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" assignOne(i);\n"
|
|
" return i;\n"
|
|
"};\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int f(int (*assign)(int *p))\n"
|
|
"{\n"
|
|
" int i;\n"
|
|
" (*assign)(&i);\n"
|
|
" return i;\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int f()\n"
|
|
"{\n"
|
|
" char s[10];\n"
|
|
" return bar(s);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" FILE *f;\n"
|
|
" fflush(f);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: f\n", errout.str());
|
|
|
|
checkUninitVar("void f()\n"
|
|
"{\n"
|
|
" Abc *p;\n"
|
|
" int sz = sizeof(*p);\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" Foo *p;\n"
|
|
" x = bar(sizeof(*p));\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" Foo *p;\n"
|
|
" x = bar(p->begin());\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
|
|
|
|
checkUninitVar("int foo(int x) { return x; }\n"
|
|
"void f2()\n"
|
|
"{\n"
|
|
" int x;\n"
|
|
" foo(x);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:5]: (error) Uninitialized variable: x\n", errout.str());
|
|
|
|
checkUninitVar("void foo(const char *s)\n"
|
|
"{\n"
|
|
" char *p;\n"
|
|
" memcpy(p, s, 100);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
|
|
|
|
checkUninitVar("void foo(const char *s)\n"
|
|
"{\n"
|
|
" char *p = malloc(100);\n"
|
|
" memcpy(p, s, 100);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
// using uninitialized function pointer..
|
|
checkUninitVar("void foo()\n"
|
|
"{\n"
|
|
" void (*f)();\n"
|
|
" f();\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: f\n", errout.str());
|
|
|
|
// calling noreturn function..
|
|
checkUninitVar("int foo(int a) {\n"
|
|
" int x;\n"
|
|
" if (a==1)\n"
|
|
" g();\n" // might be a noreturn function
|
|
" else\n"
|
|
" x = 3;\n"
|
|
" return x;\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("int foo(int a) {\n"
|
|
" int x;\n"
|
|
" if (a==1)\n"
|
|
" g(1);\n" // might be a noreturn function
|
|
" else\n"
|
|
" x = 3;\n"
|
|
" return x;\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
|
|
checkUninitVar("void (*init)(char *str);\n"
|
|
"\n"
|
|
"char x() {\n"
|
|
" char cmd[10];\n"
|
|
" init(cmd);\n"
|
|
" return cmd[0];\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
};
|
|
|
|
REGISTER_TEST(TestUninitVar)
|
|
|