130 lines
4.1 KiB
C++
130 lines
4.1 KiB
C++
/*
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
|
* Copyright (C) 2007-2012 Daniel Marjamäki and Cppcheck team.
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
|
|
#include "tokenize.h"
|
|
#include "checkassignif.h"
|
|
#include "testsuite.h"
|
|
#include <sstream>
|
|
|
|
extern std::ostringstream errout;
|
|
|
|
class TestAssignIf : public TestFixture {
|
|
public:
|
|
TestAssignIf() : TestFixture("TestAssignIf")
|
|
{ }
|
|
|
|
private:
|
|
|
|
|
|
void run() {
|
|
TEST_CASE(assignAndCompare); // assignment and comparison don't match
|
|
TEST_CASE(compare); // mismatching LHS/RHS in comparison
|
|
TEST_CASE(multicompare); // mismatching comparisons
|
|
}
|
|
|
|
void check(const char code[]) {
|
|
// Clear the error buffer..
|
|
errout.str("");
|
|
|
|
Settings settings;
|
|
settings.addEnabled("style");
|
|
|
|
// Tokenize..
|
|
Tokenizer tokenizer(&settings, this);
|
|
std::istringstream istr(code);
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
tokenizer.simplifyTokenList();
|
|
|
|
// Check char variable usage..
|
|
CheckAssignIf checkAssignIf(&tokenizer, &settings, this);
|
|
checkAssignIf.assignIf();
|
|
checkAssignIf.comparison();
|
|
checkAssignIf.multiCondition();
|
|
}
|
|
|
|
void assignAndCompare() {
|
|
// &
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" int y = x & 4;\n"
|
|
" if (y == 3);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (style) Mismatching assignment and comparison, comparison is always false\n", errout.str());
|
|
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" int y = x & 4;\n"
|
|
" if (y != 3);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (style) Mismatching assignment and comparison, comparison is always true\n", errout.str());
|
|
|
|
// |
|
|
check("void foo(int x) {\n"
|
|
" int y = x | 0x14;\n"
|
|
" if (y == 0x710);\n"
|
|
"}");
|
|
ASSERT_EQUALS("[test.cpp:3]: (style) Mismatching assignment and comparison, comparison is always false\n", errout.str());
|
|
|
|
check("void foo(int x) {\n"
|
|
" int y = x | 0x14;\n"
|
|
" if (y == 0x71f);\n"
|
|
"}");
|
|
ASSERT_EQUALS("", errout.str());
|
|
}
|
|
|
|
void compare() {
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" if (x & 4 == 3);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (style) Expression '(X & 0x4) == 0x3' is always false\n", errout.str());
|
|
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" if ((x & 4) == 3);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (style) Expression '(X & 0x4) == 0x3' is always false\n", errout.str());
|
|
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" if (x & 4 != 3);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:3]: (style) Expression '(X & 0x4) != 0x3' is always true\n", errout.str());
|
|
}
|
|
|
|
void multicompare() {
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" if (x & 7);\n"
|
|
" else if (x == 1);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (style) 'else if' condition matches previous condition at line 3\n", errout.str());
|
|
|
|
check("void foo(int x)\n"
|
|
"{\n"
|
|
" if (x & 7);\n"
|
|
" else if (x & 1);\n"
|
|
"}\n");
|
|
ASSERT_EQUALS("[test.cpp:4]: (style) 'else if' condition matches previous condition at line 3\n", errout.str());
|
|
}
|
|
};
|
|
|
|
REGISTER_TEST(TestAssignIf)
|
|
|