walkero
/
flawfinder
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Add Microsoft banned list for string concatenation

This commit is contained in:
David A. Wheeler 2014-08-09 13:44:32 -04:00
parent aa2277b862
commit 6031b31f8c
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
flawfinder
View File

@ -762,12 +762,18 @@ c_ruleset = {
"buffer", "", {}), "buffer", "", {}),
"strcat" : "strcat" :
(c_buffer, 4, (c_buffer, 4,
"Does not check for buffer overflows when concatenating to destination (CWE-120)", "Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120)",
"Consider using strcat_s, strncat, or strlcat (warning, strncat is easily misused)", "Consider using strcat_s, strncat, or strlcat (warning, strncat is easily misused)",
"buffer", "", {}), "buffer", "", {}),
"lstrcat|wcscat|_tcscat|_mbscat" : "lstrcat|wcscat|_tcscat|_mbscat" :
(c_buffer, 4, (c_buffer, 4,
"Does not check for buffer overflows when concatenating to destination (CWE-120)", "Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120)",
"",
"buffer", "", {}),
# TODO: Do more analysis. Added because they're in MS banned list.
"StrCat|StrCatA|StrcatW|lstrcatA|lstrcatW|strCatBuff|StrCatBuffA|StrCatBuffW|StrCatChainW|_tccat|_mbccat|_ftcsat|StrCatN|StrCatNA|StrCatNW|StrNCat|StrNCatA|StrNCatW|lstrncat|lstrcatnA|lstrcatnW" :
(normal, 4,
"Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120)",
"", "",
"buffer", "", {}), "buffer", "", {}),
"strncpy" : "strncpy" :
@ -791,14 +797,14 @@ c_ruleset = {
1, # Low risk level, because this is often used correctly when 1, # Low risk level, because this is often used correctly when
# FIXING security problems, and raising it to a # FIXING security problems, and raising it to a
# higher risk level would cause many false positives. # higher risk level would cause many false positives.
"Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) (CWE-120)", "Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120)",
"Consider strcat_s, strlcat, or automatically resizing strings", "Consider strcat_s, strlcat, or automatically resizing strings",
"buffer", "", {}), "buffer", "", {}),
"lstrcatn|wcsncat|_tcsncat|_mbsnbcat" : "lstrcatn|wcsncat|_tcsncat|_mbsnbcat" :
(c_strncat, (c_strncat,
1, # Low risk level, because this is often used correctly when FIXING security 1, # Low risk level, because this is often used correctly when FIXING security
# problems, and raising it to a higher risk level would cause many false positives. # problems, and raising it to a higher risk level would cause many false positives.
"Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) (CWE-120)", "Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120)",
"Consider strcat_s, strlcat, or automatically resizing strings", "Consider strcat_s, strlcat, or automatically resizing strings",
"buffer", "", {}), "buffer", "", {}),
"strccpy|strcadd": "strccpy|strcadd":