walkero
/
fontconfig
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't convert nameds to UTF-8 unless we are going to use them

This commit is contained in:
Behdad Esfahbod 2017-09-27 16:54:24 -04:00
parent f99278112d
commit 55d04e25d6
1 changed files with 22 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/fcfreetype.c
View File

@ -1386,7 +1386,6 @@ FcFreeTypeQueryFaceInternal (const FT_Face face,
for (snamei = 0; snamei < snamec; snamei++)
{
FcChar8 *utf8, *pp;
const FcChar8 *lang;
const char *elt = 0, *eltlang = 0;
int *np = 0, *nlangp = 0;
@ -1430,11 +1429,6 @@ FcFreeTypeQueryFaceInternal (const FT_Face face,
if (sp != NUM_PLATFORM_ORDER)
continue;
}
utf8 = FcSfntNameTranscode (&sname);
lang = FcSfntNameLanguage (&sname);
if (!utf8)
continue;
switch (sname.name_id) {
#ifdef TT_NAME_ID_WWS_FAMILY
@ -1446,10 +1440,9 @@ FcFreeTypeQueryFaceInternal (const FT_Face face,
case TT_NAME_ID_UNIQUE_ID:
#endif
if (FcDebug () & FC_DBG_SCANV)
printf ("found family (n %2d p %d e %d l 0x%04x) %s\n",
printf ("found family (n %2d p %d e %d l 0x%04x)",
sname.name_id, sname.platform_id,
sname.encoding_id, sname.language_id,
utf8);
sname.encoding_id, sname.language_id);
elt = FC_FAMILY;
eltlang = FC_FAMILYLANG;
@ -1459,10 +1452,9 @@ FcFreeTypeQueryFaceInternal (const FT_Face face,
case TT_NAME_ID_MAC_FULL_NAME:
case TT_NAME_ID_FULL_NAME:
if (FcDebug () & FC_DBG_SCANV)
printf ("found full (n %2d p %d e %d l 0x%04x) %s\n",
printf ("found full (n %2d p %d e %d l 0x%04x)",
sname.name_id, sname.platform_id,
sname.encoding_id, sname.language_id,
utf8);
sname.encoding_id, sname.language_id);
elt = FC_FULLNAME;
eltlang = FC_FULLNAMELANG;
@ -1477,10 +1469,9 @@ FcFreeTypeQueryFaceInternal (const FT_Face face,
if (variable)
break;
if (FcDebug () & FC_DBG_SCANV)
printf ("found style (n %2d p %d e %d l 0x%04x) %s\n",
printf ("found style (n %2d p %d e %d l 0x%04x) ",
sname.name_id, sname.platform_id,
sname.encoding_id, sname.language_id,
utf8);
sname.encoding_id, sname.language_id);
elt = FC_STYLE;
eltlang = FC_STYLELANG;
@ -1491,11 +1482,27 @@ FcFreeTypeQueryFaceInternal (const FT_Face face,
case TT_NAME_ID_MANUFACTURER:
/* If the foundry wasn't found in the OS/2 table, look here */
if(!foundry)
{
FcChar8 *utf8;
utf8 = FcSfntNameTranscode (&sname);
foundry = FcNoticeFoundry((FT_String *) utf8);
free (utf8);
}
break;
}
if (elt)
{
FcChar8 *utf8, *pp;
utf8 = FcSfntNameTranscode (&sname);
lang = FcSfntNameLanguage (&sname);
if (FcDebug () & FC_DBG_SCANV)
printf ("%s\n", utf8);
if (!utf8)
continue;
/* Trim surrounding whitespace. */
pp = utf8;
while (*pp == ' ')
@ -1535,8 +1542,6 @@ FcFreeTypeQueryFaceInternal (const FT_Face face,
}
++*np;
}
else
free (utf8);
}
}
}