Validate cache more carefully

Reject caches when FcPattern isn't a constant.
This is usually unlikely to happen but reported.
I've decided to add more validation since this isn't reproducible
and easy to have a workaround rather than investigating 'why'.

https://bugs.freedesktop.org/show_bug.cgi?id=103237
This commit is contained in:
Akira TAGOH 2017-11-14 20:55:24 +09:00
parent bc0240bf12
commit 665584a19b
1 changed files with 2 additions and 1 deletions

View File

@ -646,7 +646,8 @@ FcCacheOffsetsValid (FcCache *cache)
(char *) font > end - sizeof (FcFontSet) ||
font->elts_offset < 0 ||
font->elts_offset > end - (char *) font ||
font->num > (end - (char *) font - font->elts_offset) / sizeof (FcPatternElt))
font->num > (end - (char *) font - font->elts_offset) / sizeof (FcPatternElt) ||
!FcRefIsConst (&font->ref))
return FcFalse;