walkero
/
fontconfig
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix assertion in FcFini() 

Due to the unproper initialization of `latest_mtime', the duplicate caches
was still in fcCacheChains with no references. which means no one frees
them. thus, the memory leak was happened.

Fixes https://gitlab.freedesktop.org/fontconfig/fontconfig/issues/227
This commit is contained in:
Akira TAGOH 2020-02-26 15:42:21 +09:00
parent 61573ad5f7
commit fbc05949ef
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/fccache.c
View File

@ -365,7 +365,6 @@ FcDirCacheProcess (FcConfig *config, const FcChar8 *dir,
struct stat file_stat, dir_stat; struct stat file_stat, dir_stat;
FcBool ret = FcFalse; FcBool ret = FcFalse;
const FcChar8 *sysroot = FcConfigGetSysRoot (config); const FcChar8 *sysroot = FcConfigGetSysRoot (config);
struct timeval latest_mtime = (struct timeval){ 0 };
if (sysroot) if (sysroot)
d = FcStrBuildFilename (sysroot, dir, NULL); d = FcStrBuildFilename (sysroot, dir, NULL);
@ -390,6 +389,8 @@ FcDirCacheProcess (FcConfig *config, const FcChar8 *dir,
#ifndef _WIN32 #ifndef _WIN32
FcBool retried = FcFalse; FcBool retried = FcFalse;
#endif #endif
struct timeval latest_mtime = (struct timeval){ 0 };
if (sysroot) if (sysroot)
cache_hashed = FcStrBuildFilename (sysroot, cache_dir, cache_base, NULL); cache_hashed = FcStrBuildFilename (sysroot, cache_dir, cache_base, NULL);
else else
@ -1081,12 +1082,12 @@ FcDirCacheLoadFile (const FcChar8 *cache_file, struct stat *file_stat)
if (!file_stat) if (!file_stat)
file_stat = &my_file_stat; file_stat = &my_file_stat;
fd = FcDirCacheOpenFile (cache_file, file_stat);
if (fd < 0)
return NULL;
config = FcConfigReference (NULL); config = FcConfigReference (NULL);
if (!config) if (!config)
return NULL; return NULL;
fd = FcDirCacheOpenFile (cache_file, file_stat);
if (fd < 0)
return NULL;
cache = FcDirCacheMapFd (config, fd, file_stat, NULL); cache = FcDirCacheMapFd (config, fd, file_stat, NULL);
FcConfigDestroy (config); FcConfigDestroy (config);
close (fd); close (fd);

4
src/fcinit.c
View File

@ -199,10 +199,10 @@ void
FcFini (void) FcFini (void)
{ {
FcConfigFini (); FcConfigFini ();
FcCacheFini (); FcConfigPathFini ();
FcDefaultFini (); FcDefaultFini ();
FcObjectFini (); FcObjectFini ();
FcConfigPathFini (); FcCacheFini ();
} }
/* /*