[test] Fix a couple of coverity_scan issues

This commit is contained in:
Behdad Esfahbod 2018-02-18 11:55:26 -08:00
parent 8089711a61
commit 0bd2d76bdd
1 changed files with 11 additions and 6 deletions

View File

@ -40,18 +40,23 @@ hb_subset_test_read_file (const char *path,
{ {
FILE *fp = fopen (path, "rb"); FILE *fp = fopen (path, "rb");
size_t file_length = 0; long file_length = 0;
char *buffer = NULL; char *buffer = NULL;
if (fp && fseek (fp, 0, SEEK_END) == 0) { if (fp && fseek (fp, 0, SEEK_END) == 0)
{
file_length = ftell(fp); file_length = ftell(fp);
rewind (fp); rewind (fp);
} }
if (file_length > 0) { if (file_length > 0)
buffer = (char *) calloc (file_length + 1, sizeof(char)); {
if (fread (buffer, 1, file_length, fp) == file_length) { buffer = (char *) calloc (file_length + 1, sizeof (char));
if (buffer && fread (buffer, 1, file_length, fp) == (size_t) file_length)
{
*length = file_length; *length = file_length;
} else { }
else
{
free (buffer); free (buffer);
buffer = NULL; buffer = NULL;
} }