walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[subset] Fix memory leak in cmap subsetting.

This commit is contained in:
Garret Rieger 2018-02-23 15:37:43 -08:00
parent 4665aaa193
commit 0fb8a5ce19
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/hb-ot-cmap-table.hh
View File

@ -602,7 +602,7 @@ struct cmap
+ 8 // 1 EncodingRecord + 8 // 1 EncodingRecord
+ 16 // Format 12 header + 16 // Format 12 header
+ 12 * groups.len; // SequentialMapGroup records + 12 * groups.len; // SequentialMapGroup records
void *dest = calloc (dest_sz, 1); void *dest = malloc (dest_sz);
if (unlikely (!dest)) { if (unlikely (!dest)) {
DEBUG_MSG(SUBSET, nullptr, "Unable to alloc %lu for cmap subset output", (unsigned long) dest_sz); DEBUG_MSG(SUBSET, nullptr, "Unable to alloc %lu for cmap subset output", (unsigned long) dest_sz);
return false; return false;
@ -618,9 +618,11 @@ struct cmap
hb_blob_t *cmap_prime = hb_blob_create ((const char *)dest, hb_blob_t *cmap_prime = hb_blob_create ((const char *)dest,
dest_sz, dest_sz,
HB_MEMORY_MODE_READONLY, HB_MEMORY_MODE_READONLY,
/* userdata */ nullptr, dest,
free); free);
return hb_subset_plan_add_table (plan, HB_OT_TAG_cmap, cmap_prime); bool result = hb_subset_plan_add_table (plan, HB_OT_TAG_cmap, cmap_prime);
hb_blob_destroy (cmap_prime);
return result;
} }
struct accelerator_t struct accelerator_t