walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[font] Optimize set_func functions

This commit is contained in:
Behdad Esfahbod 2022-11-19 14:47:45 -07:00
parent f9d7b303ed
commit 114167a933
1 changed files with 54 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

81
src/hb-font.cc
View File

@ -822,6 +822,56 @@ hb_font_funcs_is_immutable (hb_font_funcs_t *ffuncs)
} }
static bool
set_func_preamble (hb_font_funcs_t *ffuncs,
bool func_is_null,
void **user_data,
hb_destroy_func_t *destroy)
{
if (hb_object_is_immutable (ffuncs))
{
if (*destroy)
(*destroy) (*user_data);
return false;
}
if (func_is_null)
{
if (*destroy)
(*destroy) (*user_data);
*destroy = nullptr;
*user_data = nullptr;
}
return true;
}
static bool
set_func_middle (hb_font_funcs_t *ffuncs,
void *user_data,
hb_destroy_func_t destroy)
{
if (user_data && !ffuncs->user_data)
{
ffuncs->user_data = (decltype (ffuncs->user_data)) hb_calloc (1, sizeof (*ffuncs->user_data));
if (unlikely (!ffuncs->user_data))
goto fail;
}
if (destroy && !ffuncs->destroy)
{
ffuncs->destroy = (decltype (ffuncs->destroy)) hb_calloc (1, sizeof (*ffuncs->destroy));
if (unlikely (!ffuncs->destroy))
goto fail;
}
return true;
fail:
if (destroy)
(destroy) (user_data);
return false;
}
#define HB_FONT_FUNC_IMPLEMENT(name) \ #define HB_FONT_FUNC_IMPLEMENT(name) \
\ \
void \ void \
@ -830,32 +880,14 @@ hb_font_funcs_set_##name##_func (hb_font_funcs_t *ffuncs, \
void *user_data, \ void *user_data, \
hb_destroy_func_t destroy) \ hb_destroy_func_t destroy) \
{ \ { \
if (hb_object_is_immutable (ffuncs)) \ if (!set_func_preamble (ffuncs, !func, &user_data, &destroy)) \
goto fail; \ return; \
\
if (!func) \
{ \
if (destroy) \
destroy (user_data); \
destroy = nullptr; \
user_data = nullptr; \
} \
\ \
if (ffuncs->destroy && ffuncs->destroy->name) \ if (ffuncs->destroy && ffuncs->destroy->name) \
ffuncs->destroy->name (!ffuncs->user_data ? nullptr : ffuncs->user_data->name); \ ffuncs->destroy->name (!ffuncs->user_data ? nullptr : ffuncs->user_data->name); \
\ \
if (user_data && !ffuncs->user_data) \ if (!set_func_middle (ffuncs, user_data, destroy)) \
{ \ return; \
ffuncs->user_data = (decltype (ffuncs->user_data)) hb_calloc (1, sizeof (*ffuncs->user_data)); \
if (unlikely (!ffuncs->user_data)) \
goto fail; \
} \
if (destroy && !ffuncs->destroy) \
{ \
ffuncs->destroy = (decltype (ffuncs->destroy)) hb_calloc (1, sizeof (*ffuncs->destroy)); \
if (unlikely (!ffuncs->destroy)) \
goto fail; \
} \
\ \
if (func) { \ if (func) { \
ffuncs->get.f.name = func; \ ffuncs->get.f.name = func; \
@ -870,11 +902,6 @@ hb_font_funcs_set_##name##_func (hb_font_funcs_t *ffuncs, \
if (ffuncs->destroy) \ if (ffuncs->destroy) \
ffuncs->destroy->name = nullptr; \ ffuncs->destroy->name = nullptr; \
} \ } \
return; \
\
fail: \
if (destroy) \
destroy (user_data); \
} }
HB_FONT_FUNCS_IMPLEMENT_CALLBACKS HB_FONT_FUNCS_IMPLEMENT_CALLBACKS