From 114f66dda6a07d61b5e64da5c44b05db7aa51cc9 Mon Sep 17 00:00:00 2001
From: Ebrahim Byagowi <ebrahim@gnu.org>
Date: Fri, 19 Oct 2018 12:05:26 +0330
Subject: [PATCH] Fix hb_map_is_empty logic

This needs reviewing
---
 src/hb-map.hh       |  2 +-
 test/api/test-map.c | 13 ++++++++-----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/hb-map.hh b/src/hb-map.hh
index 21898a7a6..b55e3a954 100644
--- a/src/hb-map.hh
+++ b/src/hb-map.hh
@@ -172,7 +172,7 @@ struct hb_map_t
 
   inline bool is_empty (void) const
   {
-    return population != 0;
+    return population == 0;
   }
 
   inline unsigned int get_population () const
diff --git a/test/api/test-map.c b/test/api/test-map.c
index 868271801..a89feaa48 100644
--- a/test/api/test-map.c
+++ b/test/api/test-map.c
@@ -31,20 +31,20 @@ static void
 test_map_basic (void)
 {
   hb_map_t *empty = hb_map_get_empty ();
-  g_assert (!hb_map_is_empty (empty)); /* this feels wrong */
+  g_assert (hb_map_is_empty (empty));
   g_assert (!hb_map_allocation_successful (empty));
   hb_map_destroy (empty);
 
   hb_map_t *m = hb_map_create ();
   g_assert (hb_map_allocation_successful (m));
-  g_assert (!hb_map_is_empty (m)); /* this as well */
+  g_assert (hb_map_is_empty (m));
 
   hb_map_set (m, 213, 223);
   hb_map_set (m, 643, 675);
   g_assert_cmpint (hb_map_get_population (m), ==, 2);
 
   g_assert_cmpint (hb_map_get (m, 213), ==, 223);
-  g_assert (hb_map_get (m, 123) == -1);
+  g_assert (!hb_map_has (m, 123));
   g_assert (hb_map_has (m, 213));
 
   hb_map_del (m, 213);
@@ -94,12 +94,14 @@ test_map_refcount ()
 
   hb_map_t *m2 = hb_map_reference (m);
   hb_map_destroy (m);
+
+  /* We copied its reference so it is still usable after one destroy */
   g_assert (hb_map_has (m, 213));
   g_assert (hb_map_has (m2, 213));
 
   hb_map_destroy (m2);
-  g_assert (hb_map_has (m, 213)); /* shouldn't these return false? */
-  g_assert (hb_map_has (m2, 213));
+
+  /* Now you can't access them anymore */
 }
 
 int
@@ -109,6 +111,7 @@ main (int argc, char **argv)
 
   hb_test_add (test_map_basic);
   hb_test_add (test_map_userdata);
+  hb_test_add (test_map_refcount);
 
   return hb_test_run();
 }