[aat] Consume glyph insertion from buffer's max_ops (#2223)
Glyph insertion is an expensive operation and we like to have it limited based on buffer's input size which is handled by buffer's max_ops. clusterfuzz-testcase-minimized-harfbuzz_fuzzer-5754958982021120: Before the change: 0.67s user 0.00s system 99% cpu 0.674 total After the change: 0.02s user 0.00s system 98% cpu 0.024 total Which takes much longer on valgrind and tsan bots.
This commit is contained in:
parent
6937092a66
commit
11d583a9ea
|
@ -725,6 +725,7 @@ struct InsertionSubtable
|
|||
if (entry.data.markedInsertIndex != 0xFFFF)
|
||||
{
|
||||
unsigned int count = (flags & MarkedInsertCount);
|
||||
if ((buffer->max_ops -= count) <= 0) return;
|
||||
unsigned int start = entry.data.markedInsertIndex;
|
||||
const HBGlyphID *glyphs = &insertionAction[start];
|
||||
if (unlikely (!c->sanitizer.check_array (glyphs, count))) count = 0;
|
||||
|
@ -753,6 +754,7 @@ struct InsertionSubtable
|
|||
if (entry.data.currentInsertIndex != 0xFFFF)
|
||||
{
|
||||
unsigned int count = (flags & CurrentInsertCount) >> 5;
|
||||
if ((buffer->max_ops -= count) <= 0) return;
|
||||
unsigned int start = entry.data.currentInsertIndex;
|
||||
const HBGlyphID *glyphs = &insertionAction[start];
|
||||
if (unlikely (!c->sanitizer.check_array (glyphs, count))) count = 0;
|
||||
|
|
Binary file not shown.
Loading…
Reference in New Issue