From 2397689387419f9a86b928ea5084b2318d136ac6 Mon Sep 17 00:00:00 2001
From: Behdad Esfahbod <behdad@behdad.org>
Date: Mon, 29 Mar 2021 17:34:23 -0600
Subject: [PATCH] Remove hb_success_t

Was not rolled-out yet.  So just expand.
---
 src/hb-open-type.hh | 4 ++--
 src/hb.hh           | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/hb-open-type.hh b/src/hb-open-type.hh
index f795c8799..432a4d674 100644
--- a/src/hb-open-type.hh
+++ b/src/hb-open-type.hh
@@ -632,7 +632,7 @@ struct ArrayOf
   void qsort (unsigned int start = 0, unsigned int end = (unsigned int) -1)
   { as_array ().qsort (start, end); }
 
-  hb_success_t serialize (hb_serialize_context_t *c, unsigned items_len)
+  HB_NODISCARD bool serialize (hb_serialize_context_t *c, unsigned items_len)
   {
     TRACE_SERIALIZE (this);
     if (unlikely (!c->extend_min (*this))) return_trace (false);
@@ -642,7 +642,7 @@ struct ArrayOf
   }
   template <typename Iterator,
 	    hb_requires (hb_is_source_of (Iterator, Type))>
-  hb_success_t serialize (hb_serialize_context_t *c, Iterator items)
+  HB_NODISCARD bool serialize (hb_serialize_context_t *c, Iterator items)
   {
     TRACE_SERIALIZE (this);
     unsigned count = items.len ();
diff --git a/src/hb.hh b/src/hb.hh
index 45df81d69..4d90e4d57 100644
--- a/src/hb.hh
+++ b/src/hb.hh
@@ -338,7 +338,6 @@ extern "C" void  hb_free_impl(void *ptr);
 #else
 #  define HB_NODISCARD
 #endif
-#define hb_success_t HB_NODISCARD bool
 
 /* https://github.com/harfbuzz/harfbuzz/issues/1852 */
 #if defined(__clang__) && !(defined(_AIX) && (defined(__IBMCPP__) || defined(__ibmxl__)))