walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "[morx] Fix MORX-35" 

This reverts commit f62f6e90ad.
This commit is contained in:
Behdad Esfahbod 2018-10-07 20:36:46 -04:00
parent 14ebf8af0c
commit 2a5cb37fdb
3 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/hb-aat-layout-morx-table.hh
View File

@ -661,17 +661,13 @@ struct InsertionSubtable
* current glyph, the next glyph processed would in fact be the first
* one inserted."
*
* So, if DontAdvance *is* set, we move to "end", such that newly
* inserted glyphs are visible.
* This suggests that if DontAdvance is NOT set, we should move to
* end+count. If it *was*, then move to end, such that newly inserted
* glyphs are now visible.
*
* If DontAdvance is *not* set, if inserted before, move past them,
* such that original current glyph will be skipped over by the driver.
* Otherwise, again, just move to "end" such that current glyph will
* be skipped over by driver.
*
* https://github.com/harfbuzz/harfbuzz/issues/1224
* https://github.com/harfbuzz/harfbuzz/issues/1224#issuecomment-427691417
*/
buffer->move_to ((flags & DontAdvance) || !before ? end : end + count);
buffer->move_to ((flags & DontAdvance) ? end : end + count);
}
if (flags & SetMark)

3
test/shaping/data/text-rendering-tests/DISABLED
View File

@ -1,3 +1,6 @@
# https://github.com/harfbuzz/harfbuzz/issues/1224
tests/MORX-35.tests
# Non-Unicode cmap
tests/CMAP-3.tests

2
test/shaping/data/text-rendering-tests/Makefile.sources
View File

@ -55,7 +55,6 @@ TESTS = \
tests/MORX-32.tests \
tests/MORX-33.tests \
tests/MORX-34.tests \
tests/MORX-35.tests \
tests/MORX-36.tests \
tests/MORX-37.tests \
tests/MORX-38.tests \
@ -74,6 +73,7 @@ TESTS = \
DISBALED_TESTS = \
tests/CMAP-3.tests \
tests/MORX-35.tests \
tests/SHARAN-1.tests \
tests/SHBALI-1.tests \
tests/SHBALI-2.tests \