From 2b117720c03869c7714304fd7fbfb2b01199bb3a Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Wed, 26 Oct 2016 18:12:50 +0200 Subject: [PATCH] Use horizontal ascent as fallback vertical origin --- src/hb-font-private.hh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/hb-font-private.hh b/src/hb-font-private.hh index 324cadc1a..cda97a68c 100644 --- a/src/hb-font-private.hh +++ b/src/hb-font-private.hh @@ -337,14 +337,15 @@ struct hb_font_t { } } - /* Internal only */ inline void guess_v_origin_minus_h_origin (hb_codepoint_t glyph, hb_position_t *x, hb_position_t *y) { *x = get_glyph_h_advance (glyph) / 2; - /* TODO use font_extents.ascender */ - *y = y_scale; + /* TODO cache this somehow?! */ + hb_font_extents_t extents; + get_h_extents_with_fallback (&extents); + *y = extents.ascender; } inline void get_glyph_h_origin_with_fallback (hb_codepoint_t glyph,