From 2bc3b9a616cedbc56ff4a915f9e3439ff3a6bf13 Mon Sep 17 00:00:00 2001
From: Behdad Esfahbod <behdad@behdad.org>
Date: Tue, 31 Jul 2012 23:08:25 -0400
Subject: [PATCH] [OT] Zero mark advances if the shaper desires so

Enabled for all shapers except for Indic.
---
 src/hb-ot-shape-complex-arabic.cc  |  1 +
 src/hb-ot-shape-complex-indic.cc   |  1 +
 src/hb-ot-shape-complex-misc.cc    |  2 ++
 src/hb-ot-shape-complex-private.hh |  2 ++
 src/hb-ot-shape.cc                 | 15 +++++++++++++++
 5 files changed, 21 insertions(+)

diff --git a/src/hb-ot-shape-complex-arabic.cc b/src/hb-ot-shape-complex-arabic.cc
index 0f73d6dd7..2cff581eb 100644
--- a/src/hb-ot-shape-complex-arabic.cc
+++ b/src/hb-ot-shape-complex-arabic.cc
@@ -299,4 +299,5 @@ const hb_ot_complex_shaper_t _hb_ot_complex_shaper_arabic =
   NULL, /* override_features */
   NULL, /* normalization_preference */
   setup_masks_arabic,
+  true, /* zero_width_marks */
 };
diff --git a/src/hb-ot-shape-complex-indic.cc b/src/hb-ot-shape-complex-indic.cc
index 55eedabab..ba5182105 100644
--- a/src/hb-ot-shape-complex-indic.cc
+++ b/src/hb-ot-shape-complex-indic.cc
@@ -1245,4 +1245,5 @@ const hb_ot_complex_shaper_t _hb_ot_complex_shaper_indic =
   override_features_indic,
   NULL, /* normalization_preference */
   setup_masks_indic,
+  false, /* zero_width_marks */
 };
diff --git a/src/hb-ot-shape-complex-misc.cc b/src/hb-ot-shape-complex-misc.cc
index 1815366c0..015ee0839 100644
--- a/src/hb-ot-shape-complex-misc.cc
+++ b/src/hb-ot-shape-complex-misc.cc
@@ -93,6 +93,7 @@ const hb_ot_complex_shaper_t _hb_ot_complex_shaper_default =
   NULL, /* override_features */
   normalization_preference_default,
   NULL, /* setup_masks */
+  true, /* zero_width_marks */
 };
 
 
@@ -201,4 +202,5 @@ const hb_ot_complex_shaper_t _hb_ot_complex_shaper_thai =
   NULL, /* override_features */
   NULL, /* normalization_preference */
   setup_masks_thai,
+  true, /* zero_width_marks */
 };
diff --git a/src/hb-ot-shape-complex-private.hh b/src/hb-ot-shape-complex-private.hh
index c0864febe..8ef41e890 100644
--- a/src/hb-ot-shape-complex-private.hh
+++ b/src/hb-ot-shape-complex-private.hh
@@ -93,6 +93,8 @@ struct hb_ot_complex_shaper_t
 		       const hb_ot_map_t            *map,
 		       hb_buffer_t                  *buffer,
 		       hb_font_t                    *font);
+
+  bool zero_width_marks;
 };
 
 #define HB_COMPLEX_SHAPER_IMPLEMENT(name) extern HB_INTERNAL const hb_ot_complex_shaper_t _hb_ot_complex_shaper_##name;
diff --git a/src/hb-ot-shape.cc b/src/hb-ot-shape.cc
index 843a543ce..ac15b2ae0 100644
--- a/src/hb-ot-shape.cc
+++ b/src/hb-ot-shape.cc
@@ -401,6 +401,18 @@ hb_position_default (hb_ot_shape_context_t *c)
   }
 }
 
+static void
+hb_zero_mark_advances (hb_ot_shape_context_t *c)
+{
+  unsigned int count = c->buffer->len;
+  for (unsigned int i = 0; i < count; i++)
+    if (c->buffer->info[i].glyph_props() & HB_OT_LAYOUT_GLYPH_CLASS_MARK)
+    {
+      c->buffer->pos[i].x_advance = 0;
+      c->buffer->pos[i].y_advance = 0;
+    }
+}
+
 static void
 hb_ot_position_complex (hb_ot_shape_context_t *c)
 {
@@ -429,6 +441,9 @@ hb_ot_position_complex (hb_ot_shape_context_t *c)
     c->applied_position_complex = true;
   }
 
+  if (c->plan->shaper->zero_width_marks)
+    hb_zero_mark_advances (c);
+
   hb_ot_layout_position_finish (c->font, c->buffer);
 
   return;