walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Replacing 'cluster' with 'syllable' when comments describe certain Indic shaping behavior (#563) 

* Clarified wording of syllable/cluster behavior in Uniscribe in final_reordering; changed one other probable typo.

* Additional syllable/cluster swap in comments for final reordering and for initial-reordering matra decomposition.
This commit is contained in:
n8willis 2017-10-12 12:48:48 +01:00 committed by Behdad Esfahbod
parent 6bac4ac2be
commit 40b05d7b77
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/hb-ot-shape-complex-indic.cc
View File

@ -856,8 +856,8 @@ initial_reordering_consonant_syllable (const hb_ot_shape_plan_t *plan,
/* 2. Decompose and reorder Matras: /* 2. Decompose and reorder Matras:
* *
* Each matra and any syllable modifier sign in the cluster are moved to the * Each matra and any syllable modifier sign in the syllable are moved to the
* appropriate position relative to the consonant(s) in the cluster. The * appropriate position relative to the consonant(s) in the syllable. The
* shaping engine decomposes two- or three-part matras into their constituent * shaping engine decomposes two- or three-part matras into their constituent
* parts before any repositioning. Matra characters are classified by which * parts before any repositioning. Matra characters are classified by which
* consonant in a conjunct they have affinity for and are reordered to the * consonant in a conjunct they have affinity for and are reordered to the
@ -1283,7 +1283,7 @@ final_reordering_syllable (const hb_ot_shape_plan_t *plan,
/* This function relies heavily on halant glyphs. Lots of ligation /* This function relies heavily on halant glyphs. Lots of ligation
* and possibly multiplication substitutions happened prior to this * and possibly multiple substitutions happened prior to this
* phase, and that might have messed up our properties. Recover * phase, and that might have messed up our properties. Recover
* from a particular case of that where we're fairly sure that a * from a particular case of that where we're fairly sure that a
* class of OT_H is desired but has been lost. */ * class of OT_H is desired but has been lost. */
@ -1307,7 +1307,7 @@ final_reordering_syllable (const hb_ot_shape_plan_t *plan,
* After the localized forms and basic shaping forms GSUB features have been * After the localized forms and basic shaping forms GSUB features have been
* applied (see below), the shaping engine performs some final glyph * applied (see below), the shaping engine performs some final glyph
* reordering before applying all the remaining font features to the entire * reordering before applying all the remaining font features to the entire
* cluster. * syllable.
*/ */
bool try_pref = !!indic_plan->mask_array[PREF]; bool try_pref = !!indic_plan->mask_array[PREF];
@ -1690,8 +1690,8 @@ final_reordering_syllable (const hb_ot_shape_plan_t *plan,
break; break;
default: default:
/* Uniscribe merges the entire cluster... Except for Tamil & Sinhala. /* Uniscribe merges the entire syllable into a single cluster... Except for Tamil & Sinhala.
* This means, half forms are submerged into the main consonants cluster. * This means, half forms are submerged into the main consonant's cluster.
* This is unnecessary, and makes cursor positioning harder, but that's what * This is unnecessary, and makes cursor positioning harder, but that's what
* Uniscribe does. */ * Uniscribe does. */
buffer->merge_clusters (start, end); buffer->merge_clusters (start, end);