walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[vector] Destruct in pop()

This commit is contained in:
Behdad Esfahbod 2022-01-15 18:00:18 -07:00
parent 7171917b52
commit 5946e945d5
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/hb-vector.hh
View File

@ -325,8 +325,10 @@ struct hb_vector_t
Type pop () Type pop ()
{ {
if (!length) return Null (Type); if (!length) return Null (Type);
return std::move (arrayZ[--length]); /* Does this move actually work? */ Type v = std::move (arrayZ[length - 1]);
// XXX Destruct? arrayZ[length - 1].~Type ();
length--;
return v;
} }
void remove (unsigned int i) void remove (unsigned int i)