walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix requiredFeature stage handling logic 

Originally the way Jonathan had written this was correct in
"continue"ing:

35e28c7a73 (diff-ead86a33a5cc9ad7f6e6381031a0baddR199)

When I rewrote his patch, I messed it up:

da13293798 (diff-ead86a33a5cc9ad7f6e6381031a0baddR209)

the intended behavior was NOT to set found=TRUE and NOT to continue.
This was resulting in feature_index[table_index] being left unset.
Oops!
This commit is contained in:
Behdad Esfahbod 2016-03-02 13:32:42 -08:00
parent 68b6296d33
commit 731a430cd3
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/hb-ot-map.cc
View File

@ -204,11 +204,8 @@ hb_ot_map_builder_t::compile (hb_ot_map_t &m)
for (unsigned int table_index = 0; table_index < 2; table_index++) for (unsigned int table_index = 0; table_index < 2; table_index++)
{ {
if (required_feature_tag[table_index] == info->tag) if (required_feature_tag[table_index] == info->tag)
{
required_feature_stage[table_index] = info->stage[table_index]; required_feature_stage[table_index] = info->stage[table_index];
found = true;
continue;
}
found |= hb_ot_layout_language_find_feature (face, found |= hb_ot_layout_language_find_feature (face,
table_tags[table_index], table_tags[table_index],
script_index[table_index], script_index[table_index],