walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[vector] Remove explicit std::move 

Was confusing compilers. Let them figure it out themselves.

Makes NotoNastaliqu subsetting/1000 benchmark more than twice faster:

Benchmark                                                                       Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------------------------
BM_subset/subset_glyphs/NotoNastaliqUrdu-Regular.ttf/1000                    -0.5064         -0.5065           111            55           110            55
BM_subset/subset_codepoints/NotoNastaliqUrdu-Regular.ttf/1000                -0.5494         -0.5493           132            59           131            59
This commit is contained in:
Behdad Esfahbod 2022-05-12 12:14:07 -06:00
parent c81198b5bc
commit 76fc27713f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hb-vector.hh
View File

@ -340,7 +340,7 @@ struct hb_vector_t : std::conditional<sorted, hb_vector_t<Type, false>, hb_empty
Type pop () Type pop ()
{ {
if (!length) return Null (Type); if (!length) return Null (Type);
Type v = std::move (arrayZ[length - 1]); Type v = arrayZ[length - 1];
arrayZ[length - 1].~Type (); arrayZ[length - 1].~Type ();
length--; length--;
return v; return v;