From 7a76222c203b68a9aa64b537a3e8cda45646a53a Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Wed, 21 Sep 2022 12:22:41 -0600 Subject: [PATCH] [gpos] in PairPos, always advance next-glyph by one only This goes against the spec. https://github.com/harfbuzz/harfbuzz/issues/3824 --- src/OT/Layout/GPOS/PairPosFormat2.hh | 2 -- src/OT/Layout/GPOS/PairSet.hh | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/OT/Layout/GPOS/PairPosFormat2.hh b/src/OT/Layout/GPOS/PairPosFormat2.hh index 83b093b98..b1b291530 100644 --- a/src/OT/Layout/GPOS/PairPosFormat2.hh +++ b/src/OT/Layout/GPOS/PairPosFormat2.hh @@ -243,8 +243,6 @@ struct PairPosFormat2_4 buffer->idx = skippy_iter.idx; - if (len2) - buffer->idx++; return_trace (true); } diff --git a/src/OT/Layout/GPOS/PairSet.hh b/src/OT/Layout/GPOS/PairSet.hh index aa48d933c..e2de81d2a 100644 --- a/src/OT/Layout/GPOS/PairSet.hh +++ b/src/OT/Layout/GPOS/PairSet.hh @@ -128,8 +128,6 @@ struct PairSet if (applied_first || applied_second) buffer->unsafe_to_break (buffer->idx, pos + 1); - if (len2) - pos++; buffer->idx = pos; return_trace (true);