From 863ec70e1240379875fe72baeada79c0d9f79fe4 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Fri, 24 Feb 2023 12:00:29 -0700 Subject: [PATCH] [wasm-shape] Add TODO items --- src/hb-wasm-shape.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/hb-wasm-shape.cc b/src/hb-wasm-shape.cc index fd8612126..781a8d6da 100644 --- a/src/hb-wasm-shape.cc +++ b/src/hb-wasm-shape.cc @@ -161,6 +161,8 @@ _hb_wasm_shape (hb_shape_plan_t *shape_plan, const hb_wasm_face_data_t *face_data = font->face->data.wasm; constexpr uint32_t stack_size = 8092, heap_size = 2 * 1024 * 1024; + /* TODO ensure_native_direction. */ + wasm_module_inst_t module_inst = nullptr; wasm_exec_env_t exec_env = nullptr; wasm_function_inst_t shape_func = nullptr; @@ -215,6 +217,9 @@ _hb_wasm_shape (hb_shape_plan_t *shape_plan, goto fail; } + /* TODO Regularize clusters accordint to direction & cluster level, + * such that client doesn't crash with unmet expectations. */ + if (!results[0].of.i32) { fail: