Minor, make CreateFile compatible with the disabled writable flag

"writable" is not in use and probably we can go in the reverse direction
and remove the flags that are useful for enabled writable, this is just
for the sake of completeness however.
This commit is contained in:
Ebrahim Byagowi 2018-05-11 22:44:44 +04:30 committed by GitHub
parent 33eb1bd23b
commit 8eb53b853d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions

View File

@ -556,8 +556,9 @@ hb_blob_create_from_file (const char *file_name)
if (unlikely (file->contents == MAP_FAILED)) goto fail; if (unlikely (file->contents == MAP_FAILED)) goto fail;
#elif defined(_WIN32) || defined(__CYGWIN__) #elif defined(_WIN32) || defined(__CYGWIN__)
HANDLE fd = CreateFile (file_name, GENERIC_READ, FILE_SHARE_READ, nullptr, HANDLE fd = CreateFile (file_name,
OPEN_EXISTING, writable ? GENERIC_READ|GENERIC_WRITE : GENERIC_READ,
FILE_SHARE_READ, nullptr, OPEN_EXISTING,
FILE_ATTRIBUTE_NORMAL | FILE_FLAG_OVERLAPPED, nullptr); FILE_ATTRIBUTE_NORMAL | FILE_FLAG_OVERLAPPED, nullptr);
# define CLOSE CloseHandle # define CLOSE CloseHandle