From 8ffa528f28a24ae85952ad1c1b0206e736bcfeab Mon Sep 17 00:00:00 2001
From: Behdad Esfahbod <behdad@behdad.org>
Date: Mon, 2 Dec 2013 05:17:14 -0500
Subject: [PATCH] Add note about unsafe shape_plan->face

Will fix by removing shape_plan->face completely.
---
 src/hb-shape-plan.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/hb-shape-plan.cc b/src/hb-shape-plan.cc
index b44a9e2ab..ab7926247 100644
--- a/src/hb-shape-plan.cc
+++ b/src/hb-shape-plan.cc
@@ -396,6 +396,8 @@ retry:
   }
 
   /* Release our reference on face. */
+  /* XXX This is unsafe, since the face can be freed before us,
+   * and we will call hb_face_destroy() in our destroy()! */
   hb_face_destroy (face);
 
   return hb_shape_plan_reference (shape_plan);