walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix signed/unsigned warning (#522) 

Change hb_buffer_diff to explicitly cast result of abs to unsigned when
comparing with position_fuzz to avoid unsafe signed/unsigned comparions
warnings on windows.
This commit is contained in:
Emil A Eklund (eae) 2017-08-15 16:25:18 -07:00 committed by Behdad Esfahbod
parent 587f15ece3
commit 91770e1c56
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/hb-buffer.cc
View File

@ -1925,10 +1925,10 @@ hb_buffer_diff (hb_buffer_t *buffer,
const hb_glyph_position_t *ref_pos = reference->pos;
for (unsigned int i = 0; i < count; i++)
{
if (abs (buf_pos->x_advance - ref_pos->x_advance) > position_fuzz ||
abs (buf_pos->y_advance - ref_pos->y_advance) > position_fuzz ||
abs (buf_pos->x_offset - ref_pos->x_offset) > position_fuzz ||
abs (buf_pos->y_offset - ref_pos->y_offset) > position_fuzz)
if ((unsigned int) abs (buf_pos->x_advance - ref_pos->x_advance) > position_fuzz ||
(unsigned int) abs (buf_pos->y_advance - ref_pos->y_advance) > position_fuzz ||
(unsigned int) abs (buf_pos->x_offset - ref_pos->x_offset) > position_fuzz ||
(unsigned int) abs (buf_pos->y_offset - ref_pos->y_offset) > position_fuzz)
{
result |= HB_BUFFER_DIFF_FLAG_POSITION_MISMATCH;
break;