walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Run valgrind on run-shape-fuzzer only when RUN_VALGRIND is set (#1285)

This commit is contained in:
Ebrahim Byagowi 2018-10-20 07:39:18 +03:30 committed by GitHub
parent f70f994112
commit 964ae32aac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.circleci/config.yml
View File

@ -102,7 +102,7 @@ jobs:
- run: make -j32 - run: make -j32
# run-shape-fuzzer-tests.py automatically runs valgrind if see available # run-shape-fuzzer-tests.py automatically runs valgrind if see available
# but test/api runs it by request, we probably should normalize the approaches # but test/api runs it by request, we probably should normalize the approaches
- run: make check && make -Ctest/api check-valgrind || .ci/fail.sh - run: RUN_VALGRIND=1 make check && make -Ctest/api check-valgrind || .ci/fail.sh
# informational for now # informational for now
- run: make -Ctest/api check-symbols || true - run: make -Ctest/api check-symbols || true

4
test/fuzzing/run-shape-fuzzer-tests.py
View File

@ -67,7 +67,9 @@ please provide it as the first argument to the tool""")
print ('hb_shape_fuzzer:', hb_shape_fuzzer) print ('hb_shape_fuzzer:', hb_shape_fuzzer)
fails = 0 fails = 0
valgrind = which ('valgrind') valgrind = None
if os.environ.get('RUN_VALGRIND', ''):
valgrind = which ('valgrind')
parent_path = os.path.join (srcdir, "fonts") parent_path = os.path.join (srcdir, "fonts")
for file in os.listdir (parent_path): for file in os.listdir (parent_path):