walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add explicit to hb_auto_t 1param constructors

This commit is contained in:
Behdad Esfahbod 2018-08-28 18:18:02 -07:00
parent c0a3f38f78
commit 967741e4c4
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/hb-dsalgs.hh
View File

@ -497,9 +497,10 @@ struct hb_auto_t : Type
*
* Apparently if we template for all types, then gcc seems to
* capture a reference argument in the type, but clang doesn't,
* causing unwanted copies and bugs that come with it. */
template <typename T1> hb_auto_t (T1 *t1) { Type::init (t1); }
template <typename T1> hb_auto_t (T1 &t1) { Type::init (t1); }
* causing unwanted copies and bugs that come with it. Ideally
* we should use C++11-style rvalue reference &&t1. */
template <typename T1> explicit hb_auto_t (T1 *t1) { Type::init (t1); }
template <typename T1> explicit hb_auto_t (T1 &t1) { Type::init (t1); }
~hb_auto_t (void) { Type::fini (); }
private: /* Hide */
void init (void) {}