From 9d3a252030e8f86aff4a35ce56fe77eb718e2071 Mon Sep 17 00:00:00 2001
From: Michiharu Ariza <ariza@adobe.com>
Date: Mon, 18 Mar 2019 15:39:10 -0700
Subject: [PATCH] add api test for tt var advance widths

stripped HVAR from SourceSansVariable-Roman.abc.ttf so glyf gets parsed
---
 src/hb-ot-hmtx-table.hh                       |   1 -
 .../fonts/SourceSansVariable-Roman.abc.ttf    | Bin 3240 -> 3168 bytes
 test/api/test-ot-metrics-tt-var.c             |  37 ++++++++++++++++++
 3 files changed, 37 insertions(+), 1 deletion(-)

diff --git a/src/hb-ot-hmtx-table.hh b/src/hb-ot-hmtx-table.hh
index 08fa2c9cd..d3594467c 100644
--- a/src/hb-ot-hmtx-table.hh
+++ b/src/hb-ot-hmtx-table.hh
@@ -221,7 +221,6 @@ struct hmtxvmtx
       var_table.destroy ();
     }
 
-    /* TODO Add variations version. */
     int get_side_bearing (hb_codepoint_t glyph) const
     {
       if (glyph < num_advances)
diff --git a/test/api/fonts/SourceSansVariable-Roman.abc.ttf b/test/api/fonts/SourceSansVariable-Roman.abc.ttf
index 690d7d5392e21dc9ad01b86dfbe35ce8591c02ac..f2b141b48f41fdc00f46ccd83cd4d2d0b38c0909 100644
GIT binary patch
delta 403
zcmZ1>`9PwcfsuiMK?q2&FetdYxVo7+>54KiaQy&^+PVk$2eZ|ExW>T1(ZayM$mJd!
z>NHujNsNJka{^G_%s0$2Nc)|-C6Ipt$hYwi);EfZEM5jwy8_5h2o7-!;pMvg3}_w;
zkbfqzEU~CkE_Vlze*wr>OU_NKFJO>n3SeMhk^pH)11f0$SIz;nPzA(K&#6q4vp84`
zlm|J$D;+5BHzDON0|U1Okgt)EnwTQG`PD8UTL-A#ECVRO)y@iZ3}XtAuac2lQo*6e
zXav*`G?PIfCqFrn;W0xQkY54hbLA#lRTMDDFfsu(bN~eu@)C1X=Sl5zW?*0jx{$@F
zAiuce|3wC%0URJ7D1bwYkyZZOJnsC-2bgpw|6x*{+{vUcS&=zjfT@5Xf$<rG4U-g*
z-p61zxq&&ElYzkwXx~x>hRrsNzKok6GKaBD{>_!Nxst<;ar1XhHpa=Z+-j4}Ih;1P
Iaw{_e018cB*8l(j

delta 469
zcmaDLu|l$*fsuiMK^RD|Fc`SIxVo7+>54KiaF_r^ZQTR>gW2jnTm$k;7#JA2+=D}%
zCW|(SF)(m80Oid*!W@ILG$$kj`8z;-Um#!mow_BE{{hIi@ekHFii#{=#=yX=0OThG
zhd74ta$SDLz`&&g<ey0_ORO)dl*<Kb=8gags3qqn7BEON1pqZPfHb6)B^I^+E9U@e
z_yOXl=TxT2SsW||I>rWwz0!g5eiKse0`&vcGiqd{CZ>pPezl8%foTg+y;%lOfUBML
z1d#s+$XCh8EvewpV>ANt-vIdnIr(<Ui42b!%76kZfC5~(i4_G5GK@?>eg}}Rke8U7
zI!|h!GtfZ~fI(zbkY8N#{~`m>01gq5{N@%WU&hIuj0)mF9)lgwprt?>6r_x-@*6)-
zkDYA6s3X8sz>vWBjKPLU3P|r`Fq@phs5*HiWBg<ZrsU0+nL}76|K@Vq+{xj_s1Gs~
t0YC=vfQ=Ial0cpV5CUTgY(;>Pmel5BocxTFH8~O{U*%HUY|X982mmI-W=a46

diff --git a/test/api/test-ot-metrics-tt-var.c b/test/api/test-ot-metrics-tt-var.c
index f944f173a..13152509d 100644
--- a/test/api/test-ot-metrics-tt-var.c
+++ b/test/api/test-ot-metrics-tt-var.c
@@ -61,12 +61,49 @@ test_extents_tt_var (void)
   hb_font_destroy (font);
 }
 
+static void
+test_advance_tt_var (void)
+{
+  hb_face_t *face = hb_test_open_font_file ("fonts/SourceSansVariable-Roman.abc.ttf");
+  g_assert (face);
+  hb_font_t *font = hb_font_create (face);
+  hb_face_destroy (face);
+  g_assert (font);
+  hb_ot_font_set_funcs (font);
+
+  hb_position_t x, y;
+  hb_font_get_glyph_advance_for_direction(font, 1, HB_DIRECTION_LTR, &x, &y);
+
+  g_assert_cmpint (x, ==, 486);
+  g_assert_cmpint (y, ==, 0);
+
+  hb_font_get_glyph_advance_for_direction(font, 1, HB_DIRECTION_TTB, &x, &y);
+
+  g_assert_cmpint (x, ==, 0);
+  g_assert_cmpint (y, ==, -1000);
+
+  float coords[1] = { 500.0f };
+  hb_font_set_var_coords_design (font, coords, 1);
+  hb_font_get_glyph_advance_for_direction(font, 1, HB_DIRECTION_LTR, &x, &y);
+
+  g_assert_cmpint (x, ==, 510);
+  g_assert_cmpint (y, ==, 0);
+
+  hb_font_get_glyph_advance_for_direction(font, 1, HB_DIRECTION_TTB, &x, &y);
+
+  g_assert_cmpint (x, ==, 0);
+  g_assert_cmpint (y, ==, -1000);
+
+  hb_font_destroy (font);
+}
+
 int
 main (int argc, char **argv)
 {
   hb_test_init (&argc, &argv);
 
   hb_test_add (test_extents_tt_var);
+  hb_test_add (test_advance_tt_var);
 
   return hb_test_run ();
 }