walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[kerx] Make Format1 work 

Tested using Kannada MN:

$ HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CCd,C95,CCD
[kn_ka.virama=0+1299|kn_ka.vattu=0+115|_blank=0@-115,0+385]

$ HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CCd,C95,CCD --features=-kern
[kn_ka.virama=0+1799|kn_ka.vattu=0+230|_blank=0+0]

I don't see the GPOS table in the font do the same.  ¯\_(ツ)_/¯
This commit is contained in:
Behdad Esfahbod 2018-10-10 21:46:58 -04:00
parent 504cb68fc9
commit 9f450f07b0
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/hb-aat-layout-kerx-table.hh
View File

@ -123,7 +123,7 @@ struct KerxSubTableFormat1
inline driver_context_t (const KerxSubTableFormat1 *table, inline driver_context_t (const KerxSubTableFormat1 *table,
hb_aat_apply_context_t *c_) : hb_aat_apply_context_t *c_) :
c (c_), c (c_),
kernAction (table+table->kernAction), kernAction (&table->machine + table->kernAction),
depth (0) {} depth (0) {}
inline bool is_actionable (StateTableDriver<EntryData> *driver, inline bool is_actionable (StateTableDriver<EntryData> *driver,
@ -159,16 +159,21 @@ struct KerxSubTableFormat1
return false; return false;
} }
for (; depth; depth--) for (unsigned int i = 0; i < depth; i++)
{ {
unsigned int idx = stack[depth - 1]; /* Apparently, when spec says "Each pops one glyph from the kerning stack
* and applies the kerning value to it.", it doesn't mean it in that order.
* The deepest item in the stack corresponds to the first item in the action
* list. Discovered by testing. */
unsigned int idx = stack[i];
int v = *actions++; int v = *actions++;
/* XXX Non-forward direction... */ /* XXX Non-forward direction... */
if (HB_DIRECTION_IS_HORIZONTAL (buffer->props.direction)) if (HB_DIRECTION_IS_HORIZONTAL (buffer->props.direction))
buffer->pos[idx].x_advance += v; buffer->pos[idx].x_advance += c->font->em_scale_x (v);
else else
buffer->pos[idx].y_advance += v; buffer->pos[idx].y_advance += c->font->em_scale_y (v);
} }
depth = 0;
} }
return true; return true;