walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove some TODO items

This commit is contained in:
Behdad Esfahbod 2012-07-31 23:10:11 -04:00
parent 2bc3b9a616
commit a8842e4a44
2 changed files with 2 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
TODO
View File

@ -3,15 +3,9 @@ General fixes:
- mask propagation (when ligation, "or" the masks). - mask propagation (when ligation, "or" the masks).
- fail_shaper that always fails.
- Make map in setup_masks() const, etc.
- Warn at compile time (and runtime with HB_DEBUG?) if no Unicode / font - Warn at compile time (and runtime with HB_DEBUG?) if no Unicode / font
funcs found / set. funcs found / set.
- In hb_shape(), assert if direction is INVALID.
- Fix TT 'kern' on/off and GPOS interaction (move kerning before GPOS). - Fix TT 'kern' on/off and GPOS interaction (move kerning before GPOS).
- Do proper rounding when scaling from font space? May be a non-issue. - Do proper rounding when scaling from font space? May be a non-issue.
@ -20,23 +14,12 @@ General fixes:
* init/medi/fina/isol for non-cursive scripts * init/medi/fina/isol for non-cursive scripts
* vkna,hkna etc for kana, etc * vkna,hkna etc for kana, etc
- Move non-native direction and normalization handling to the generic non-OT
layer, such that other backends can use (Uniscribe doesn't need this).
- Convert NBSP into space glyph.
- Add Pango backend? - Add Pango backend?
- Add ICUlayout backend? - Add ICUlayout backend?
- Add ICUlayout API? - Add ICUlayout API?
- Add Old HarfBuzz backend?
- Add Old HarfBuzz API?
- Add namespace to avoid type clashes with Windows
API issues to fix before 1.0: API issues to fix before 1.0:
============================ ============================
@ -111,13 +94,3 @@ Tests to write:
- hb_set_t - hb_set_t
- hb_cache_t and relatives - hb_cache_t and relatives
Optimizations:
=============
- Avoid allocating blob objects internally for for_data() faces?
- Add caching layer to hb-ft?
- Cache feature-less shape plans internally on the face.

2
src/hb-shape.cc
View File

@ -87,6 +87,8 @@ hb_shape_full (hb_font_t *font,
buffer->guess_properties (); buffer->guess_properties ();
assert (buffer->props.direction != HB_DIRECTION_INVALID);
hb_shape_plan_t *shape_plan = hb_shape_plan_create_cached (font->face, &buffer->props, features, num_features, shaper_list); hb_shape_plan_t *shape_plan = hb_shape_plan_create_cached (font->face, &buffer->props, features, num_features, shaper_list);
hb_bool_t res = hb_shape_plan_execute (shape_plan, font, buffer, features, num_features); hb_bool_t res = hb_shape_plan_execute (shape_plan, font, buffer, features, num_features);
hb_shape_plan_destroy (shape_plan); hb_shape_plan_destroy (shape_plan);