From ac92ed7d6875374451246a2391859fb763329adb Mon Sep 17 00:00:00 2001 From: Ebrahim Byagowi Date: Tue, 8 May 2018 01:05:15 +0430 Subject: [PATCH] Set inline hidden flag only on shared library building To avoid need of CMP0063 which is not available on older CMake versions --- CMakeLists.txt | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 55366c063..9ed7e56e8 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,6 +1,4 @@ cmake_minimum_required(VERSION 2.8.0) -cmake_policy(SET CMP0063 NEW) - project(harfbuzz) enable_testing() @@ -526,17 +524,17 @@ endif () ## Define harfbuzz library add_library(harfbuzz ${project_sources} ${project_extra_sources} ${project_headers}) -set_target_properties(harfbuzz PROPERTIES - VISIBILITY_INLINES_HIDDEN TRUE) target_link_libraries(harfbuzz ${THIRD_PARTY_LIBS}) ## Define harfbuzz-subset library add_library(harfbuzz-subset ${subset_project_sources} ${subset_project_headers}) add_dependencies(harfbuzz-subset harfbuzz) -set_target_properties(harfbuzz-subset PROPERTIES - VISIBILITY_INLINES_HIDDEN TRUE) target_link_libraries(harfbuzz-subset harfbuzz ${THIRD_PARTY_LIBS}) +if (BUILD_SHARED_LIBS) + set_target_properties(harfbuzz harfbuzz-subset PROPERTIES VISIBILITY_INLINES_HIDDEN TRUE) +endif () + if (UNIX OR MINGW) # Make symbols link locally include (CheckCXXCompilerFlag) @@ -566,11 +564,13 @@ if (HB_HAVE_GOBJECT) ${hb_gobject_headers} ${hb_gobject_gen_headers} ) - set_target_properties(harfbuzz-gobject PROPERTIES - VISIBILITY_INLINES_HIDDEN TRUE) include_directories(BEFORE ${CMAKE_CURRENT_BINARY_DIR}/src) add_dependencies(harfbuzz-gobject harfbuzz) target_link_libraries(harfbuzz-gobject harfbuzz ${GOBJECT_LIBRARIES} ${THIRD_PARTY_LIBS}) + + if (BUILD_SHARED_LIBS) + set_target_properties(harfbuzz-gobject PROPERTIES VISIBILITY_INLINES_HIDDEN TRUE) + endif () endif () if (BUILD_SHARED_LIBS AND WIN32 AND NOT MINGW)